10/29/2012 6:43:51 PM
patch revisits d39d45cf344c2e8eea66892b4077916d4478a5f9.
This new implementation is easier to read and enforces that, in all
cases, the first event won't be null.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
|
|
|
|
|
|
|
|
10/27/2012 11:48:51 PM
push notification to include accountId
Harden TestPushNotification
|
10/28/2012 4:44:50 PM
reverts commit d39d45cf344c2e8eea66892b4077916d4478a5f9.
Let's not tackle this issue for the 0.1.41 release, as we're still unclear
on what the fix should be.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
|
|
|
|
10/27/2012 10:26:47 PM
migrated bundles, the last event is likely to be a MIGRATE_BILLING
event, which is ignored in toEvents() when building the events for the transfered
bundle.
This was causing errors when transferring bundles where the destination
subscription wouldn't have any event.
This patch does best effort to find at least one event by building
them as we go (the last non-null one would be used, in this case the one
associated with the MIGRATE_ENTITLEMENT event).
Another solution would be to create a dummy TRANSFER event by default
although this is a bit tricky to build (need to remember the last phase name,
etc.).
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
