|
|
|
|
|
|
|
|
|
|
|
|
8/20/2015 11:18:15 AM
passed
Add tests to verify the integrity of payment and payment transactions: before, when providing an existing payment
external key but no payment id, the code would assume a new payment needed to be created and eventually throw
java.sql.SQLIntegrityConstraintViolationException (Duplicate entry 'XXX' for key 'payments_key').
Remove handling of UNKNOWN transactions from PaymentLeavingStateCallback. This should never be called as there is no
transition allowed out of an _ERRORED (e.g. AUTH_ERRORED) state. The test testApiRetryWithUnknownPaymentTransaction was
passing only because no payment id was set, and so the code assumed to be an INIT state (before bypassing the state machine
in PaymentLeavingStateCallback). Now, an exception is correctly thrown (no available transition out of AUTH_ERRORED).
This should also help simplify the context (see https://github.com/killbill/killbill/issues/378).
This also addresses https://github.com/killbill/killbill/issues/371 by demonstrating we support today multiple PENDING
transactions for the same payment (tracked by https://github.com/killbill/killbill/issues/383).
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
8/20/2015 9:26:34 AM
Pierre-Alexandre Meyer <pierre@mouraf.org>
|
8/20/2015 9:16:57 AM
fixes https://github.com/killbill/killbill/issues/379.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
|
|
