8/29/2012 3:01:41 PM
throws NPE if paymentId is null.
We want to ignore these events in analytics anyways as they are not real
attempts.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
8/29/2012 1:55:34 PM
Pierre-Alexandre Meyer <pierre@ning.com>
|
8/29/2012 1:49:37 PM
previously checking the overdue states by explicitly
calling refresh on the bundle (the configuration parameter
autoReevaluationInterval was so high, that the notification queue never
kicked in).
This wasn't fully testing overdue though. For instance, the test
testOverdueStateIfNoPaymentMethod() would pass even if we don't send
the payment errors on the bus when there is no default payment method
(because we were asking overdue to refresh its state manually).
Since there is no payment retry if the account doesn't have a default
payment method, overdue has to rely on the notification queue to refresh
its state (and make the bundle go through the various overdue stages
when we move the clock).
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
8/29/2012 1:18:53 PM
method
If a payment cannot be processed because there is no default payment
method, we need to post an event on the bus for overdue to refresh the
overdue state.
Note that an event will be posted even if the invoice balance is zero.
Added a Beatrix test for this scenario.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
8/27/2012 8:25:33 PM
change.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
8/27/2012 8:21:29 PM
duplicated setup code
* Make disabled tests pass
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
8/27/2012 7:22:47 PM
Pierre-Alexandre Meyer <pierre@ning.com>
|
8/27/2012 7:22:25 PM
Pierre-Alexandre Meyer <pierre@ning.com>
|
8/27/2012 7:21:18 PM
Add extra checks for invoice items (it's a bit
convoluted because of the extra credit generated).
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
8/27/2012 6:03:43 PM
the START_BILLING_DISABLED event, by setting the
fixed price to null and setting the billing period to NO_BILLING_PERIOD.
Add an overdue test in TestInvoiceDispatcher to verify this works. The
(hardcoded) test scenario is similar to the one in beatrix
(TestOverdueIntegration#testBasicOverdueState).
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
