7/11/2014 5:37:34 PM
(code review from Pierre)
|
7/11/2014 5:30:52 PM
number in the bug report does not seem to match current code)
Add missing Nullable for externalKeys
Add specific null constant NULL_ATTEMPT_ID (to avoid arbitrary null all over api calls)
Check for null transactionExternalKey when checking for uniquness
|
7/11/2014 4:20:54 PM
paymentMethodId on the account, so that payment state machine will still run
and will end up generating a payment bus event (That can be caught by the system, such as the overdue module to move overdue state).
|
7/10/2014 10:36:29 PM
event outside of transaction for when payment did not complete (there was no transaction)
Fix Payment events (remove invoiceId, paymentNumber, ...)
|
|
|
|
|
|
|
7/10/2014 6:10:52 PM
...)
|
7/10/2014 5:38:01 PM
be consistent (and explicit)
|
7/10/2014 5:19:34 PM
to encapsulate (hide) required knowledge about the state machines
and refactor the payment code to rely on those new abstractions.
(We could remove some of the hardcoing existing in these classes by introducing additional attributes on the state machine xml (isTerminal, isSuccess, isInit,...)
but there will always be a bootstrap issue to solve, and so those classes need to exist)
|
