6/28/2013 4:37:43 PM
instead.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/28/2013 3:40:45 PM
bothered adding new tests because I realized we're not
consistent with invoice: some of the null checks are done in higher
levels (DefaultAccountInternalApi) for example.
We should straighten our story here first.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/28/2013 3:11:08 PM
new API when expecting a checked exception.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/28/2013 2:51:30 PM
use remove WithInvoiceApiException in
DefaultInvoiceInternalApi.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/28/2013 2:39:41 PM
use remove WithInvoiceApiException in DefaultInvoicePaymentApi.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/28/2013 1:21:49 PM
stephane brossier <stephane@ning.com>
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/28/2013 1:18:21 PM
name and description attributes are non-NULL as early as possible
to avoid throwing a runtime exception from the transaction back to the
client.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/28/2013 12:49:24 AM
may be null. Take it into consideration when
building NotificationJson.
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/28/2013 12:15:34 AM
creation call idempotent for Tags - the same tag won't
be created twice anymore.
This required the following changes (mainly around being able to catch a checked
exception from a jdbi transaction):
util: - extract getCreateEntitySqlDaoTransactionWrapper and checkEntityAlreadyExists in EntityDaoBase for create call customizations - add a second execute method in EntitySqlDaoTransactionalJdbiWrapper which throws a checked exception - use NULL-safe operation in getByAccountRecordId in EntitySqlDao.sql.stg or the call fails when looking for NULL account_record_id (found in test). This may be required in other EntitySqlDao queries.
jaxrs: - add toString, equals, hashCode to TagJson (found in test)
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
6/27/2013 6:42:17 PM
plugin wasn't found, RefundProcessor would throw an
NPE. This patch refactors and centralizes the calls to the plugin registry
to throw an appropriate exception in case the plugin is not found.
This also removes the unused method: PaymentPluginApi getPaymentProviderPlugin(String, InternalTenantContext)
Signed-off-by: Pierre-Alexandre Meyer <pierre@ning.com>
|
