1/18/2016 11:55:22 AM
was sometimes failing due to multiple events being dispatched.
The root cause was the following sequence of events:
* Bus event claimed and dispatched
* Test listener notified
* Other listeners (e.g. invoice) start processing the event
* Clock moved
* Bus re-dispatching the same event (because the claim time has now passed)
The reason the clock is moved too early is because we don't listen to null invoice events in the tests.
We already had a work-around in TestApiListener (we wait until there is no more entries in bus_events), however
one code path was by-passing it. This fixes it -- the main drawback is that we introduce a 500ms delay in the worst
case scenario. We could reduce that arbitrary sleep delay in case it causes a significant slowdown in the tests.
This should fix https://github.com/killbill/killbill/issues/382: I ran the test successfully twice with invocationCount = 100
(while before I could trigger the bug by running the test manually a few times).
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/17/2016 8:18:40 PM
fixes https://github.com/killbill/killbill/issues/446.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/17/2016 8:09:35 PM
Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/15/2016 5:05:04 PM
to https://github.com/killbill/killbill/issues/174.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/15/2016 1:36:44 PM
Add missing expected PAYMENT event for refund and chargeback
* INVOICE_ADJUSTMENT event is not expected for pro-rations anymore
This fixes https://github.com/killbill/killbill/issues/174.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/14/2016 8:49:35 PM
fixes https://github.com/killbill/killbill/issues/452.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/14/2016 12:45:35 PM
Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/14/2016 12:41:46 PM
date
ClockUtil will in some cases default to clock.getUTCNow() when transforming the local date
into a date time, which can break add-ons cancellations.
This was a known issue but we re-introduced it after the recent reshuffling of the code
to support bulk cancellations.
Relates to https://github.com/killbill/killbill/issues/451.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/13/2016 9:12:10 PM
fixes https://github.com/killbill/killbill/issues/248.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
1/13/2016 8:23:05 PM
Pierre-Alexandre Meyer <pierre@mouraf.org>
|