12/3/2018 7:59:28 AM
the behavior to set the account BCD even for pure usage based
plans.
The implementation relies on the fact that Subscription#dateOfFirstRecurringNonZeroCharge()
is actually the subscription start date in this case.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/30/2018 12:58:23 PM
fixes a couple of other tests.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/30/2018 9:22:29 AM
using the first calculated BCD of the first BillingEvent seen.
This was a bit arbitrary, especially across bundles (since we weren't looking at the date).
We now look at the first BillingEvent with a non-$0 recurring price and use
its effective date to get the account BCD. This matches better our BCD definition:
date of first recurring non-$0 charge.
One side effect is that for pure usage based plans, the account BCD isn't set anymore.
For instance, a consumable in arrear usage plan billed on the 1st would have previously
set the account BCD to the 1st. Now, it is not updated (unless a recurring price is set to the plan).
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/30/2018 7:59:04 AM
Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/30/2018 7:03:33 AM
anymore
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/30/2018 7:01:54 AM
after updating the catalog. If the
Analytics plugin is triggered before updateTenantKeyValue completes
for instance, the wrong catalog could be cached.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/30/2018 7:00:59 AM
Meyer <pierre@mouraf.org>
|
11/30/2018 6:40:37 AM
the start date as the BillingEvent effectiveDate, similar to
how it's done in FixedAndRecurringInvoiceItemGenerator.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/29/2018 7:14:54 AM
recurringBillingMode anymore.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/29/2018 7:02:50 AM
intervals, we need to go through all billing events,
in case the BCD has changed.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
