11/27/2013 12:47:36 PM
patch removes getBlockingAll(UUID blockableId, BlockingStateType blockingStateType, InternalTenantContext context);
from BlockingInternalApi: junction was calling it multiple times for different blockingStateType, which
was breaking the natural ordering of events and hence introducing bugs when computing blocking durations.
Instead, we introduce getBlockingAllForAccount(InternalTenantContext context);
Events are ordered correctly by junction and will return bundle, subscription and account level blocking
events (we were ignoring the subscription level ones before for some reason).
This also:
* fixes the ordering returned by the SQL statements (only really needed for getBlockingStateForService
as we re-order the other calls in ProxyBlockingStateDao).
* removes BillingEventSet#isLast which wasn't used.
This closes #123.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
|
|
|
|
11/20/2013 11:25:08 AM
had a report that this method would pick up soft deleted
tags but I cannot reproduce it.
While we're at it, get rid of the unnecessary accountId parameter
to the method.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/20/2013 10:57:34 AM
Meyer <pierre@mouraf.org>
|
11/20/2013 10:32:38 AM
tenantId
This closes #128.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/20/2013 8:14:16 AM
plan is cancelled prior to an add-on, make sure we return the base plan
cancellation date for the add-on, even if the add-on is effectively cancelled
at a later date (since, if nothing happens, the add-on will be cancelled by the
notification queue when the base plan is cancelled).
See discussion on: https://github.com/killbill/killbill-integration-tests/commit/6aa7c6d30699a259983b4c014180fa421d89354a
This fixes test_future_cancel_bp_prior_future_ao_cancel_date in killbill-integration-tests.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/19/2013 6:10:50 PM
closes #126.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/19/2013 12:39:52 PM
DefaultSubscriptionBaseApiService
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
11/19/2013 12:29:53 PM
base entitlement is cancelled
The code already does the right thing, add a test to confirm it.
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
|
