5/1/2017 10:37:31 AM
Fix build warning DefaultCharset in test Utils class
Warning:
azkaban/azkaban-common/src/test/java/azkaban/jobExecutor/Utils.java:30: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments PrintWriter writer = new PrintWriter(new FileWriter(filename)); ^ (see http://errorprone.info/bugpattern/DefaultCharset) Did you mean 'PrintWriter writer = new PrintWriter(Files.newBufferedWriter(Paths.get(filename), UTF_8));' or 'PrintWriter writer = new PrintWriter(Files.newBufferedWriter(Paths.get(filename), Charset.defaultCharset()));'?
Also: * refactored it to use try with resource. * refactored the delete method to simplify it and check results. * removed all intellij warnings
Testing:
All tests passed.
* Fix a test failure
|
|
|
|
|
4/27/2017 9:37:56 PM
you mean 'PrintWriter out = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new FileOutputStream(_output), UTF_8)));' or 'PrintWriter out = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new FileOutputStream(_output), Charset.defaultCharset())));'? /Users/afaris/work/public/li-afaris_azkaban/azkaban-web-server/src/main/java/azkaban/webapp/servlet/ProjectManagerServlet.java:1809: warning: [ClassCanBeStatic] Inner class is non-static but does not reference enclosing class public class PageSelection { ^ (see http://errorprone.info/bugpattern/ClassCanBeStatic)
|
|
|
|
|
|
|
|
|
4/27/2017 9:03:24 PM
user (#1033)
|
4/27/2017 8:53:57 PM
example is the following:
/Users/afaris/work/public/li-afaris_azkaban/azkaban-web-server/src/main/java/azkaban/webapp/WebMetrics.java:37: warning: [ImmutableEnumChecker] enums should only have immutable fields, the declaration of type 'com.codahale.metrics.Meter' is not annotated @Immutable private final Meter webGetCall; ^ (see http://errorprone.info/bugpattern/ImmutableEnumChecker)
|
