7/23/2017 6:28:08 PM
is intended to prevent the bug happened on #1283. I simply annotate ProjectManager singleton in this patth. When developers guicify other classes relying on ProjectManager in future, they will not need to worry about generating bugs.
|
|
|
7/20/2017 5:52:33 PM
bug was found in local solo server built by July 19th's master
code. Our integration test tried to add trigger, which run every
minutes. The strange observation is that this trigger never run. We
debugged the code and found that the TriggerScannerThread was launched
twice, and newly added triggers were put into the should-not-exist
thread and never run. I noticed that TriggerManager did not bind to
Singleton in Guice Confs. I made this change, and the thread doesn't
launch twice. The bug disappeared.
|
7/19/2017 1:05:11 PM
have the right permissions. (#1237)
Detailed changes:
1. Upload button is enabled only for admin users and users with UPLOADPROJECTS
permission when the property 'lockdown.upload.projects' is set to true.
2. New permission UPLOADPROJECTS is created
3. Handle the case for ajax upload as well
4. Tests included
Verified all changes against the azkaban-solo-server.
|
7/18/2017 8:49:54 PM
(#1277)
* make passwordPlaceHolder and password error message configurable
Some Azkaban instances needs 2FA authentications. The password field in login UI doesn't only include user's password. We modified the UI and make password placeholder configurable, such that Azkaban admins will be able to define.
|
7/12/2017 6:23:04 PM
The `MetricsManager` is the point of contact for any emission of metrics from Azkaban. The current code directly accesses the `MetricsRegistry` class from different places.
- The `MetricsUtility` class has been removed. The static methods have been converted to instance methods in MetricsManager.
- All instances of accessing `MetricsRegistry` directly have been removed except test code.
- Removed dead code: `ConsoleReporter` was never used
|
7/11/2017 10:28:00 PM
library seems to be more actively developed and maintained.
And it handles junit dependency correctly.
|
7/11/2017 8:44:37 PM
(#1272)
The current upload logic is sitting in the ProjectManager class. This change delegates the upload and download to AzkabanProjectLoader class. This makes the upload/download code much easier to manage and test. Added a unit test for upload and download methods.
This change also helps pave the way for subsequent refactors which are required to clean up and simplify the project loading and validating logic.
Note: There is no logic change in this code.
|
7/11/2017 8:39:17 PM
Return json string directly from the LogUtil method
Step 3 of refactoring the log4j appender logic
Change the method return type and name to make unit testing easier.
Add an unit test.
* Code clean up
|
7/11/2017 7:44:58 PM
refactor JDBC Project class to leverage new azkaban-db
This change is aimed at re-constructing JDBC project loader class to
allow db retry feature to be leveraged. In order to make this happen,
there are a few changes made in this patch:
* remove some never-use abstract method in ProjectLoader interface.
* guicify JdbcProjectImpl and make it as the only implementation to
Projectloader.
* Seprate All Project related JDBC handler classes to a ourside static class.
* Bring in memory h2 db to test new JdbcProject class.
* Change azkaban-db interface to allow user to define if rollback should
be enabled.
|
