8/21/2017 10:12:16 PM
to solve issue #1363.
Currently if we setup SLA but with no action specified, there will be no warning, and schedule page will show "has SLA" is true.
However, action should be required when setting up SLA.
This PR added a non empty check on SLA actions when adding SLA for a schedule. Warning window will show up if action is not specified when setting SLA.
Old check was not checking the number of actions at all when updating SLA. The null check was used when uploading project logs.
Verified manually, but will automate the test in the internal integration test framework
|
8/21/2017 9:03:02 PM
I'm rewriting fetchNumExecutableFlows and fetchNumExecutableNodes methods in order to leverage new DB API.
Added corresponding unit tests.
|
8/21/2017 5:32:14 PM
code patch is a follow-up of #1357 . I replaced the DB operations by calling new DB API, and added Unite Tests.
|
8/21/2017 5:01:08 PM
in JdbcExecutorLoader (#1375)
As a follow-up of #1345, I'm rewriting fetchQueuedFlows and fetchRecentlyFinishedFlows methods in order to leverage new DB API.
Added corresponding unit tests.
|
|
|
8/21/2017 12:20:26 PM
possible that if job is killed just before the job gets inside the sync block currently in delayExecution(), it can remain in wait for the full delayStartMs instead of exiting. This is fixed by bringing also the checks for isKilled() into the sync block in delayExecution().
|
8/21/2017 12:13:37 PM
sleeping, replace with more eager waiting
- Add sleep to another place to increase stability
- Extracted common purpose method into a new helper class
|
|
|
8/20/2017 12:19:41 AM
(#1368)
Use Intellij's Delegate-refactor feature to automate moving related member methods to delegate classes, which is also automatically created by Intellij. Didn't change the implementation yet, will change it after all moving process completes.
Added Guice Tests to guarantee guice functionality.
|
8/18/2017 8:11:46 PM
into the above test failure. The cause should be We use two different dataSource to create and query test DB. In this PR, I fixed by creating a new setupDB class via leveraging new DB's API.
I mainly copied azkaban.database.AzkabanDatabaseSetup to the new class. I know this class has some coding issues, and I will refactor them in the follow-up PR
|
