8/23/2017 1:58:43 PM
PR is a follow-up of #1361 , which aimed at clearing the submodule dependency management. We explicitly depend on some internals from azkaban-db. It would be nice if we could hide this detail.
The solution originated from:
https://softnoise.wordpress.com/2014/09/07/gradle-sub-project-test-dependencies-in-multi-project-builds/
|
8/23/2017 11:21:30 AM
currently builds the `Server` and `Context` objects inside itself. The current refactor pulls out these code pieces into separate `@Provider` methods which are being injected by `Guice`. A separate submodule has been created for the purpose.
|
8/22/2017 7:47:38 PM
the change history at https://github
.com/tbroyer/gradle-errorprone-plugin/commits/master
|
8/22/2017 6:07:05 PM
plugin adds an errorprone configuration that automatically uses the latest release of error-prone. You can override it to use a specific version "
see https://github.com/tbroyer/gradle-errorprone-plugin
It appears that by latest version it will use the last locally cached
version. This caused inconsistency in builds.
## Fix:
Specify a fixed version
Will update to the latest version after the internal Artifactory
is updated with the latest version.
## Test:
Deleted the gradle cache and run the build again and verified in the
console output that the specified version was downloaded.
|
8/22/2017 5:25:23 PM
3.33.0
PR is a follow-up of #1345. Last but not least, I'm moving assignExecutor and UnAssignExecutor to a new DAO file.
The reason I don't create a new test file:
Not usre how much in-memory h2 database consume resources. We could use only one test class (in-memory h2) to do testing.
|
8/22/2017 3:15:23 PM
Fix build failure by suppressing MissingFail warning
* Explicitly fail the test if no exception is thrown.
|
8/21/2017 10:12:16 PM
to solve issue #1363.
Currently if we setup SLA but with no action specified, there will be no warning, and schedule page will show "has SLA" is true.
However, action should be required when setting up SLA.
This PR added a non empty check on SLA actions when adding SLA for a schedule. Warning window will show up if action is not specified when setting SLA.
Old check was not checking the number of actions at all when updating SLA. The null check was used when uploading project logs.
Verified manually, but will automate the test in the internal integration test framework
|
8/21/2017 9:03:02 PM
I'm rewriting fetchNumExecutableFlows and fetchNumExecutableNodes methods in order to leverage new DB API.
Added corresponding unit tests.
|
8/21/2017 5:32:14 PM
code patch is a follow-up of #1357 . I replaced the DB operations by calling new DB API, and added Unite Tests.
|
8/21/2017 5:01:08 PM
in JdbcExecutorLoader (#1375)
As a follow-up of #1345, I'm rewriting fetchQueuedFlows and fetchRecentlyFinishedFlows methods in order to leverage new DB API.
Added corresponding unit tests.
|
