9/15/2017 2:13:54 PM
brought a feature that AZ admins can publish messages in banner bar on the top of AZ UI. There exists an issue reported by the user:
I cannot click on the "Job List", "Flow Log", and "Stats" tabs until the orange message banner disappears after about 30 seconds.
The cause is that container-fill (css class) uses absolute position, when the top div elements moves down, it will override the div beneath. I figured out there are a number of places using container-fill. So I'd like not change the original place. The proposed fix is that we just let flow view page's div to be static, such that it will move downward along with top div.
|
|
|
9/15/2017 1:22:48 PM
code patch is to create az-core sub module and move some utils class to here. The discussion of this proposal is at https://github.com/azkaban/azkaban/issues/1462.
Used Intellij to do the refactor.
|
|
|
9/14/2017 3:58:51 PM
(#1442)
- Now instead of fixed 1s sleep we wait for max 10s for the node update count to be 2.
- This lets us use the luxury of additional sleep time (1s->2s) before killing the flow, so that there's a better chance for job getting inside its delayExecution() block.
Test failure was:
azkaban.execapp.JobRunnerTest > testDelayedExecutionCancelledJob FAILED java.lang.AssertionError: expected:<2> but was:<1>
It was faithfully reproduced when I removed the 1s sleep before assert on getNodeUpdateCount().
|
9/14/2017 3:25:40 PM
to move metrics foundation class to a common place, I am creating az-core sub module. Since Metrics relies on some utils class in azkaban-common, the first step of this series of refactor is to clean up some methods in `azkaban-common', and it facilitate me to do those refactor in the following PRs.
In this code patch:
* I move addCommonFlowProperties out of PropsUtils, so that we can move PropsUtil to az-core in the next PR easily.
* Also, this method is not suitable to stay in PropsUtils.
|
9/13/2017 8:21:51 PM
[Refactor] (#1459)
constructing Quartz Test, which needs to create tables in h2-in-memory. This PR does:
* Remove unknown code
* simplify logic
|
9/13/2017 4:07:05 PM
(#1458)
build: Enable gradle scans on travis CI to debug #1448
|
9/13/2017 12:20:00 PM
to azkaban.properties to be able to override mail
hostname and port number links. // User facing web server configurations used to construct the user facing server URLs. They are useful when there is a reverse proxy between Azkaban web servers and users. // enduser -> myazkabanhost:443 -> proxy -> localhost:8081 // when this parameters set then these parameters are used to generate email links. // if these parameters are not set then jetty.hostname, and jetty.port(if ssl configured jetty.ssl.port) are used. public static final String AZKABAN_WEBSERVER_EXTERNAL_HOSTNAME = "azkaban.webserver.external_hostname"; public static final String AZKABAN_WEBSERVER_EXTERNAL_SSL_PORT = "azkaban.webserver.external_ssl_port"; public static final String AZKABAN_WEBSERVER_EXTERNAL_PORT = "azkaban.webserver.external_port";
|
9/12/2017 5:05:57 PM
(#1454)
This method is only used in tests.
Make the name more descriptive.
This is particularly helpful when doing code reviews.
|
