5/2/2017 7:36:33 PM
3.21.0
(#1049)
This is required by the internal build system and it needs to be fixed
prior to clean up of this code
|
5/1/2017 9:52:20 PM
Refactor the code for getting OS free memory information
Replaced SwapCache with SwapFree
See https://bbs.archlinux.org/viewtopic.php?id=133604
SwapCache doesn't represent the available swap space.
Switched the logger to lsf4j.
Will make another pull request to switch to Guice.
Fixed all the intellij and ErrorProne warnings.
* Fix [FutureReturnValueIgnored] errorprone warning
|
5/1/2017 2:43:48 PM
(#1044)
@RunWith(Suite.class)
@SuiteClasses({ JavaProcessJobTest.class, ProcessJobTest.class, PythonJobTest.class })
|
5/1/2017 1:07:05 PM
(#1045)
Warnings:
azkaban/azkaban-common/src/test/java/azkaban/jobExecutor/WordCountLocal.java:59: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments new BufferedReader(new InputStreamReader(new FileInputStream(_input))); ^ (see http://errorprone.info/bugpattern/DefaultCharset) Did you mean 'new BufferedReader(new InputStreamReader(new FileInputStream(_input), UTF_8));' or 'new BufferedReader(new InputStreamReader(new FileInputStream(_input), Charset.defaultCharset()));'?
azkaban/azkaban-common/src/test/java/azkaban/jobExecutor/WordCountLocal.java:83: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments PrintWriter out = new PrintWriter(new FileOutputStream(_output)); ^ (see http://errorprone.info/bugpattern/DefaultCharset)
Also fixed:
Intellij warnings
Removed two unnecessary override methods.
Renamed local variables to confirm to the coding standard.
|
5/1/2017 10:37:31 AM
Fix build warning DefaultCharset in test Utils class
Warning:
azkaban/azkaban-common/src/test/java/azkaban/jobExecutor/Utils.java:30: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments PrintWriter writer = new PrintWriter(new FileWriter(filename)); ^ (see http://errorprone.info/bugpattern/DefaultCharset) Did you mean 'PrintWriter writer = new PrintWriter(Files.newBufferedWriter(Paths.get(filename), UTF_8));' or 'PrintWriter writer = new PrintWriter(Files.newBufferedWriter(Paths.get(filename), Charset.defaultCharset()));'?
Also: * refactored it to use try with resource. * refactored the delete method to simplify it and check results. * removed all intellij warnings
Testing:
All tests passed.
* Fix a test failure
|
|
|
|
|
4/27/2017 9:37:56 PM
you mean 'PrintWriter out = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new FileOutputStream(_output), UTF_8)));' or 'PrintWriter out = new PrintWriter(new BufferedWriter(new OutputStreamWriter(new FileOutputStream(_output), Charset.defaultCharset())));'? /Users/afaris/work/public/li-afaris_azkaban/azkaban-web-server/src/main/java/azkaban/webapp/servlet/ProjectManagerServlet.java:1809: warning: [ClassCanBeStatic] Inner class is non-static but does not reference enclosing class public class PageSelection { ^ (see http://errorprone.info/bugpattern/ClassCanBeStatic)
|
|
|
|
|
