9/6/2017 3:19:57 PM
Create a singleton of ExecutorApiClient with Guice
- Mock it with Mockito in unit tests
|
9/6/2017 2:04:37 PM
package (#1434)
Use IntelliJ to find and replace all occurrences. This PR is a follow-up of #1428.
|
|
|
9/6/2017 1:42:10 PM
Ruby and Script job types and the LongArgJob class.
These job types are not documented and not maintained. e.g. they don't
support execute-as-user security feature which is a security hole.
Command job type can be used to provide the equivalent functionality.
|
9/6/2017 1:17:23 PM
(#1428)
There still exists a few places where we bind class to singleton in guice module class. As discussed a few weeks ago, we decided to enforce using @Singleton annotation, rather than the binding statement. The benefit is to manage and view singleton class easily.
This code patch tries to fix/replace this issue.
|
9/6/2017 11:47:50 AM
failures. It's quick, too.
* Applied Save actions plugin.
* Stability to assertPipelineLevel2
On Travis this failed on the condition Assert.assertTrue(minParentDiff < 500 || minDiff < 500). This can happen occasionally on slower test runs, so can't really have this kind of tight check.
* Use ExecutionsTestUtil
* Use TemporaryFolder rule for working dir
|
9/5/2017 2:47:35 PM
exit with error msg if log4j.properties file not exist.
|
9/5/2017 2:29:16 PM
(#1427)
|
|
|
9/5/2017 1:10:40 PM
to the Google style guide.
See https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment
- Remove unnecessary descriptions. They are not the essence of the
contract.
|
