5/11/2018 5:42:37 PM
itself
#1486
The code is not used yet.
See earlier prototype and change history at #1487
More unit tests and refactoring will follow.
Node state machine diagram
|
5/11/2018 2:35:40 PM
InputStream by using try-with-resources
- Better isolation as EmailerTest depends on TestUtils instead of DefaultMailCreatorTest
|
5/9/2018 7:29:16 PM
jobs (#1756)
A quartz job is identified by job name and group name. Group name is the combination of project id and flow id. But job name was a constant string. This PR replaces it with dynamic job name variable.
For flow trigger, the job name is FLOW_TRIGGER. This is to provide flexibility in case where same flow could have multiple scheduled quartz jobs in the future.
|
5/8/2018 1:30:49 AM
Don't use static fields (to have isolated mocks for each `@Test` method)
- Apply save actions
- Replace static sleep method with async callback to avoid extra wait
|
5/4/2018 12:58:07 AM
(#1750)
The thinking behind that is scheduled flow trigger needs to be paused if something goes south, e.x: the triggered flow is consuming too much azkaban resource. One way to stop the schedule is reupload a new project with new flow config with flow trigger turned off, but allowing the project admin to pause/resume schedule is apparently much more convenient option.
Tested manually. Unit test will follow up.
|
5/1/2018 7:23:09 PM
move duplicate code to methods.
Related previous PRs:
#1690
#1691
|
4/30/2018 9:45:47 PM
were previously ignored. Some refactoring was needed to inject dependencies.
Builds on #1690 which should be merged first (1st commit is the same)
For the actual scope of this PR, see the 2nd commit only: 2f5014b
|
4/30/2018 7:03:41 PM
PR adds purging mechanism of old flow trigger execution records from the db table. Otherwise the table will keep growing indefinitely as more triggers are executed, leading to excessive query time on the table - e.x recovering incomplete trigger instances or querying historic trigger instances
The cleanup policy is removing trigger instances finishing older than 20 days back, and will be practiced every 10 mins.
|
4/24/2018 12:45:28 AM
search bug
|
4/23/2018 7:26:14 PM
won't support schedule like:
run every second
run every 2 second
run every minute at 2nd second.
The check is done on project uploading.
|
