5/22/2018 12:29:58 PM
Refactor DagService shutdown method and add tests
Part of #1486
Create a new utility class to encapsulate the generic shutdown logic to
make it easier to test and allow better code reuse.
Change the shutdown API to take a Duration type instead of a long. This is more precise and flexible. Also reduced the shutdown timeout from 60 seconds to 10 seconds.
After this change, the dag package will have 100% line
coverage.
|
5/21/2018 9:26:09 PM
line coverage, the logical coverage is more
limited. This change improves that.
|
5/21/2018 9:09:49 PM
state such as killing won't have
any effect.
With this change, the DAG class has 100% code coverage.
Also make ImmutableSet in the Status enum more strongly typed.
|
5/17/2018 8:14:35 PM
failed. (#1764)
With this test, the Node class has 100% code coverage.
|
5/17/2018 5:07:37 PM
3.47.0
to discover the node corresponding to a subdag when
the subdag starts to run.
The find node by name method is no longer needed for now.
|
5/17/2018 2:31:08 PM
an exception when circular dependency is detected when building a
dag.
|
5/16/2018 2:58:52 PM
dag creation from dag execution
This eliminates a class of program errors caused by changing the dag
states while it is running.
The dag creation classes can be used separately in the future. To
detect circular dependencies for example.
|
5/11/2018 5:42:37 PM
itself
#1486
The code is not used yet.
See earlier prototype and change history at #1487
More unit tests and refactoring will follow.
Node state machine diagram
|
5/11/2018 2:35:40 PM
InputStream by using try-with-resources
- Better isolation as EmailerTest depends on TestUtils instead of DefaultMailCreatorTest
|
5/9/2018 7:29:16 PM
jobs (#1756)
A quartz job is identified by job name and group name. Group name is the combination of project id and flow id. But job name was a constant string. This PR replaces it with dynamic job name variable.
For flow trigger, the job name is FLOW_TRIGGER. This is to provide flexibility in case where same flow could have multiple scheduled quartz jobs in the future.
|
