5/31/2018 6:27:58 PM
user zip to AZ (#1722)
A user is able to user.to.proxy any user in Reportal today. This has been a security vulnerability issue for long time. This PR proposes a fix to validate user.to.proxy configuration before the zip being uploaded to AZ. If the session user is not part of userToProxy user, error is returned to browser to prevent users saving the Reportal.
|
5/31/2018 3:08:20 AM
name to survive (#1694)
Users reported that log missed when composed job name was too long. The reason is that Mysql doesn't allow to insert a row when name's length is bigger than 128. This PR increases the length to allow long job name to survive.
Since we don't know the Mysql prefix settings for other Azkaban users, we try to meet the requirement for defaults. In Default Mysql settings, the index key prefix length limit is 767 bytes for innoDB. We have to assume most users using innoDB.
Besides, users should gain difference regarding character seeting in Mysql. In latin1, each character is exactly one byte long. In utf8, a character can consist of more than one byte, usually 3 or 4. At our settings, we use latin1, so we can hold 512 character long name for a job.
Because varchar size enhancement is not a necessary upgrade, schema update file is not recommended here. If people run into the issues above, they should follow the below instructions:
maximize the Mysql varchar size limit introduced in this PR.
change the Mysql character setting to latin1, if your Azkaban only stores English or other latin characters.
For h2 database, there is no limit for the following entities, except the memory and storage capacity: maximum identifier length (table name, column name, and so on)
http://www.h2database.com/html/advanced.html#limits_limitations
|
5/29/2018 7:15:43 PM
methods never throw ServletException.
|
5/29/2018 6:31:15 PM
(#1773)
Original error message is misleading -
1. it doesn't clarify the error is from web server or executor.
2. executor service sometimes rejects new flow submission because it's being shut down after executor's shutdown api is called, but the message still indicates the reason as exceeding the thread pool limit.
|
5/28/2018 12:42:30 AM
which is > 6 months old.
4.7 is the latest version as of today.
Updated using
`./gradlew wrapper --gradle-version 4.6`
Remove the gradle version in the wrapper task config since this information
is included in the checkedin gradle-warpper.properties already.
See
https://docs.gradle.org/current/userguide/gradle_wrapper.html
https://gradle.org/releases/
|
5/26/2018 4:01:46 PM
test ExecutorServiceUtilsTest
Failure on Travis:
azkaban.utils.ExecutorServiceUtilsTest > force_shutdown_after_timeout FAILED java.lang.AssertionError: Expecting: <11L> to be less than: <10L> at azkaban.utils.ExecutorServiceUtilsTest.force_shutdown_after_timeout(ExecutorServiceUtilsTest.java:60)
azkaban.utils.ExecutorServiceUtilsTest
Cause:
When the test host is busy, the execution time may be greater.
Fix:
Add buffer and a comment to explain the test.
* Assert that the test thread is indeed interrupted
The previous test will continue to succeed even if the task is not terminated.
|
5/25/2018 10:09:22 PM
logger.error call
|
5/25/2018 7:35:16 PM
(#1770)
|
5/22/2018 12:29:58 PM
Refactor DagService shutdown method and add tests
Part of #1486
Create a new utility class to encapsulate the generic shutdown logic to
make it easier to test and allow better code reuse.
Change the shutdown API to take a Duration type instead of a long. This is more precise and flexible. Also reduced the shutdown timeout from 60 seconds to 10 seconds.
After this change, the dag package will have 100% line
coverage.
|
5/21/2018 9:26:09 PM
line coverage, the logical coverage is more
limited. This change improves that.
|
