keycloak-uncached

[KEYCLOAK-6321] - NPE when deleting a resource with admin events …

2/21/2018 9:34:11 AM

enabled

pedroigor

Commit: d590600

Tree: 05cfe1d

Parents: 12a2f23

Changes

model/jpa/src/main/java/org/keycloak/authorization/jpa/store/JPAResourceStore.java 36(+30 -6)

Details

model/jpa/src/main/java/org/keycloak/authorization/jpa/store/JPAResourceStore.java 36(+30 -6)

diff --git a/model/jpa/src/main/java/org/keycloak/authorization/jpa/store/JPAResourceStore.java b/model/jpa/src/main/java/org/keycloak/authorization/jpa/store/JPAResourceStore.java
index 7a505ab..de83c42 100644
--- a/model/jpa/src/main/java/org/keycloak/authorization/jpa/store/JPAResourceStore.java
+++ b/model/jpa/src/main/java/org/keycloak/authorization/jpa/store/JPAResourceStore.java
@@ -99,7 +99,11 @@ public class JPAResourceStore implements ResourceStore {
         ResourceStore resourceStore = provider.getStoreFactory().getResourceStore();
 
         for (String id : result) {
-            list.add(resourceStore.findById(id, resourceServerId));
+            Resource resource = resourceStore.findById(id, resourceServerId);
+
+            if (resource != null) {
+                list.add(resource);
+            }
         }
 
         return list;
@@ -118,7 +122,11 @@ public class JPAResourceStore implements ResourceStore {
         ResourceStore resourceStore = provider.getStoreFactory().getResourceStore();
 
         for (String id : result) {
-            list.add(resourceStore.findById(id, resourceServerId));
+            Resource resource = resourceStore.findById(id, resourceServerId);
+
+            if (resource != null) {
+                list.add(resource);
+            }
         }
 
         return list;
@@ -135,7 +143,11 @@ public class JPAResourceStore implements ResourceStore {
         ResourceStore resourceStore = provider.getStoreFactory().getResourceStore();
 
         for (String id : result) {
-            list.add(resourceStore.findById(id, resourceServerId));
+            Resource resource = resourceStore.findById(id, resourceServerId);
+
+            if (resource != null) {
+                list.add(resource);
+            }
         }
 
         return list;
@@ -177,7 +189,11 @@ public class JPAResourceStore implements ResourceStore {
         ResourceStore resourceStore = provider.getStoreFactory().getResourceStore();
 
         for (String id : result) {
-            list.add(resourceStore.findById(id, resourceServerId));
+            Resource resource = resourceStore.findById(id, resourceServerId);
+
+            if (resource != null) {
+                list.add(resource);
+            }
         }
 
         return list;
@@ -196,7 +212,11 @@ public class JPAResourceStore implements ResourceStore {
         ResourceStore resourceStore = provider.getStoreFactory().getResourceStore();
 
         for (String id : result) {
-            list.add(resourceStore.findById(id, resourceServerId));
+            Resource resource = resourceStore.findById(id, resourceServerId);
+
+            if (resource != null) {
+                list.add(resource);
+            }
         }
 
         return list;
@@ -231,7 +251,11 @@ public class JPAResourceStore implements ResourceStore {
         ResourceStore resourceStore = provider.getStoreFactory().getResourceStore();
 
         for (String id : result) {
-            list.add(resourceStore.findById(id, resourceServerId));
+            Resource resource = resourceStore.findById(id, resourceServerId);
+
+            if (resource != null) {
+                list.add(resource);
+            }
         }
 
         return list;