Details
diff --git a/payment/src/main/java/org/killbill/billing/payment/core/PaymentExecutors.java b/payment/src/main/java/org/killbill/billing/payment/core/PaymentExecutors.java
index 18fcb1e..d58c304 100644
--- a/payment/src/main/java/org/killbill/billing/payment/core/PaymentExecutors.java
+++ b/payment/src/main/java/org/killbill/billing/payment/core/PaymentExecutors.java
@@ -21,6 +21,7 @@ import java.util.concurrent.ExecutorService;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ThreadFactory;
+import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
import javax.inject.Inject;
@@ -43,7 +44,7 @@ public class PaymentExecutors {
private final PaymentConfig paymentConfig;
- private volatile ExecutorService pluginExecutorService;
+ private volatile ThreadPoolExecutor pluginExecutorService;
private volatile ScheduledExecutorService janitorExecutorService;
@Inject
@@ -54,6 +55,7 @@ public class PaymentExecutors {
public void initialize() {
this.pluginExecutorService = createPluginExecutorService();
+ this.pluginExecutorService.prestartAllCoreThreads();
this.janitorExecutorService = createJanitorExecutorService();
}
@@ -77,7 +79,7 @@ public class PaymentExecutors {
return janitorExecutorService;
}
- private ExecutorService createPluginExecutorService() {
+ private ThreadPoolExecutor createPluginExecutorService() {
final int minThreadNb = DEFAULT_MIN_PLUGIN_THREADS < paymentConfig.getPaymentPluginThreadNb() ? DEFAULT_MIN_PLUGIN_THREADS : paymentConfig.getPaymentPluginThreadNb();
return new WithProfilingThreadPoolExecutor(minThreadNb,
paymentConfig.getPaymentPluginThreadNb(),
diff --git a/payment/src/main/java/org/killbill/billing/payment/dispatcher/CallableWithRequestData.java b/payment/src/main/java/org/killbill/billing/payment/dispatcher/CallableWithRequestData.java
index d8012d2..01b15f1 100644
--- a/payment/src/main/java/org/killbill/billing/payment/dispatcher/CallableWithRequestData.java
+++ b/payment/src/main/java/org/killbill/billing/payment/dispatcher/CallableWithRequestData.java
@@ -17,6 +17,7 @@
package org.killbill.billing.payment.dispatcher;
+import java.util.Map;
import java.util.Random;
import java.util.concurrent.Callable;
@@ -26,6 +27,7 @@ import org.apache.shiro.util.ThreadContext;
import org.killbill.billing.util.UUIDs;
import org.killbill.commons.request.Request;
import org.killbill.commons.request.RequestData;
+import org.slf4j.MDC;
public class CallableWithRequestData<T> implements Callable<T> {
@@ -33,13 +35,20 @@ public class CallableWithRequestData<T> implements Callable<T> {
private final Random random;
private final SecurityManager securityManager;
private final Subject subject;
+ private final Map<String, String> mdcContextMap;
private final Callable<T> delegate;
- public CallableWithRequestData(final RequestData requestData, final Random random, final SecurityManager securityManager, final Subject subject, final Callable<T> delegate) {
+ public CallableWithRequestData(final RequestData requestData,
+ final Random random,
+ final SecurityManager securityManager,
+ final Subject subject,
+ final Map<String, String> mdcContextMap,
+ final Callable<T> delegate) {
this.requestData = requestData;
this.random = random;
this.securityManager = securityManager;
this.subject = subject;
+ this.mdcContextMap = mdcContextMap;
this.delegate = delegate;
}
@@ -50,12 +59,14 @@ public class CallableWithRequestData<T> implements Callable<T> {
UUIDs.setRandom(random);
ThreadContext.bind(securityManager);
ThreadContext.bind(subject);
+ MDC.setContextMap(mdcContextMap);
return delegate.call();
} finally {
Request.resetPerThreadRequestData();
UUIDs.setRandom(null);
ThreadContext.unbindSecurityManager();
ThreadContext.unbindSubject();
+ MDC.clear();
}
}
}
diff --git a/payment/src/main/java/org/killbill/billing/payment/dispatcher/PluginDispatcher.java b/payment/src/main/java/org/killbill/billing/payment/dispatcher/PluginDispatcher.java
index fa65e1b..c31bbbe 100644
--- a/payment/src/main/java/org/killbill/billing/payment/dispatcher/PluginDispatcher.java
+++ b/payment/src/main/java/org/killbill/billing/payment/dispatcher/PluginDispatcher.java
@@ -31,6 +31,7 @@ import org.killbill.billing.util.UUIDs;
import org.killbill.commons.profiling.Profiling;
import org.killbill.commons.profiling.ProfilingData;
import org.killbill.commons.request.Request;
+import org.slf4j.MDC;
import com.google.common.annotations.VisibleForTesting;
@@ -62,6 +63,7 @@ public class PluginDispatcher<ReturnType> {
UUIDs.getRandom(),
ThreadContext.getSecurityManager(),
ThreadContext.getSubject(),
+ MDC.getCopyOfContextMap(),
task);
final Future<PluginDispatcherReturnType<ReturnType>> future = pluginExecutor.submit(callableWithRequestData);
diff --git a/payment/src/test/java/org/killbill/billing/payment/dispatcher/TestPluginDispatcher.java b/payment/src/test/java/org/killbill/billing/payment/dispatcher/TestPluginDispatcher.java
index f2cd9c8..b582f33 100644
--- a/payment/src/test/java/org/killbill/billing/payment/dispatcher/TestPluginDispatcher.java
+++ b/payment/src/test/java/org/killbill/billing/payment/dispatcher/TestPluginDispatcher.java
@@ -30,6 +30,7 @@ import org.killbill.billing.payment.dispatcher.PluginDispatcher.PluginDispatcher
import org.killbill.billing.util.UUIDs;
import org.killbill.commons.request.Request;
import org.killbill.commons.request.RequestData;
+import org.slf4j.MDC;
import org.testng.Assert;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
@@ -140,6 +141,7 @@ public class TestPluginDispatcher extends PaymentTestSuiteNoDB {
UUIDs.getRandom(),
null,
null,
+ MDC.getCopyOfContextMap(),
delegate);
final String actualRequestId = stringPluginDispatcher.dispatchWithTimeout(callable, 100, TimeUnit.MILLISECONDS);