killbill-aplcache
Changes
beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationWithCatalogUpdate.java 2(+1 -1)
Details
diff --git a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationWithCatalogUpdate.java b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationWithCatalogUpdate.java
index c314ac2..3f81642 100644
--- a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationWithCatalogUpdate.java
+++ b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationWithCatalogUpdate.java
@@ -201,7 +201,7 @@ public class TestIntegrationWithCatalogUpdate extends TestIntegrationBase {
final PlanPhaseSpecifier spec = new PlanPhaseSpecifier("bar-monthly", null);
final List<PlanPhasePriceOverride> overrides = new ArrayList<PlanPhasePriceOverride>();
- overrides.add(new DefaultPlanPhasePriceOverride(plan.getFinalPhase().getName(), account.getCurrency(), null, BigDecimal.ONE));
+ overrides.add(new DefaultPlanPhasePriceOverride(plan.getFinalPhase().getName(), account.getCurrency(), null, BigDecimal.ONE, null));
final Entitlement baseEntitlement = createEntitlement(spec, overrides, true);
List<Invoice> invoices = invoiceUserApi.getInvoicesByAccount(account.getId(), false, testCallContext);
diff --git a/catalog/src/main/java/org/killbill/billing/catalog/caching/EhCacheOverriddenPlanCache.java b/catalog/src/main/java/org/killbill/billing/catalog/caching/EhCacheOverriddenPlanCache.java
index 1c1f404..1ffc03a 100644
--- a/catalog/src/main/java/org/killbill/billing/catalog/caching/EhCacheOverriddenPlanCache.java
+++ b/catalog/src/main/java/org/killbill/billing/catalog/caching/EhCacheOverriddenPlanCache.java
@@ -165,7 +165,6 @@ public class EhCacheOverriddenPlanCache implements OverriddenPlanCache {
public boolean apply(final CatalogOverrideTierDefinitionModelDao input) {
final List<CatalogOverrideBlockDefinitionModelDao> blockDefs = overrideDao.getOverriddenTierBlocks(input.getRecordId(), context);
for(CatalogOverrideBlockDefinitionModelDao blockDef : blockDefs) {
-
String unitName = blockDef.getParentUnitName();
Double max = blockDef.getMax();
Double size = blockDef.getSize();
diff --git a/catalog/src/main/java/org/killbill/billing/catalog/dao/CatalogOverrideUsageDefinitionModelDao.java b/catalog/src/main/java/org/killbill/billing/catalog/dao/CatalogOverrideUsageDefinitionModelDao.java
index 542054e..8dbd183 100644
--- a/catalog/src/main/java/org/killbill/billing/catalog/dao/CatalogOverrideUsageDefinitionModelDao.java
+++ b/catalog/src/main/java/org/killbill/billing/catalog/dao/CatalogOverrideUsageDefinitionModelDao.java
@@ -6,7 +6,6 @@ import java.math.BigDecimal;
public class CatalogOverrideUsageDefinitionModelDao {
-
private Long recordId;
private String parentUsageName;
private String parentUsageType;
diff --git a/catalog/src/main/java/org/killbill/billing/catalog/DefaultPlanPhase.java b/catalog/src/main/java/org/killbill/billing/catalog/DefaultPlanPhase.java
index 55dbad6..83f330b 100644
--- a/catalog/src/main/java/org/killbill/billing/catalog/DefaultPlanPhase.java
+++ b/catalog/src/main/java/org/killbill/billing/catalog/DefaultPlanPhase.java
@@ -42,6 +42,7 @@ import javax.xml.bind.annotation.XmlAttribute;
import javax.xml.bind.annotation.XmlElement;
import javax.xml.bind.annotation.XmlElementWrapper;
import java.net.URI;
+import java.util.Arrays;
@XmlAccessorType(XmlAccessType.NONE)
public class DefaultPlanPhase extends ValidatingConfig<StandaloneCatalog> implements PlanPhase {
diff --git a/catalog/src/main/java/org/killbill/billing/catalog/DefaultTier.java b/catalog/src/main/java/org/killbill/billing/catalog/DefaultTier.java
index 0485363..be3729c 100644
--- a/catalog/src/main/java/org/killbill/billing/catalog/DefaultTier.java
+++ b/catalog/src/main/java/org/killbill/billing/catalog/DefaultTier.java
@@ -83,7 +83,6 @@ public class DefaultTier extends ValidatingConfig<StandaloneCatalog> implements
}
}).orNull();
-
blocks[i] = (overriddenTierBlock != null) ? new DefaultTieredBlock(in.getTieredBlocks()[i], overriddenTierBlock, currency) :
(DefaultTieredBlock) in.getTieredBlocks()[i];
}
diff --git a/catalog/src/main/java/org/killbill/billing/catalog/DefaultUsage.java b/catalog/src/main/java/org/killbill/billing/catalog/DefaultUsage.java
index fcc27a7..3cdbf00 100644
--- a/catalog/src/main/java/org/killbill/billing/catalog/DefaultUsage.java
+++ b/catalog/src/main/java/org/killbill/billing/catalog/DefaultUsage.java
@@ -112,25 +112,23 @@ public class DefaultUsage extends ValidatingConfig<StandaloneCatalog> implements
@Override
public boolean apply(final TierPriceOverride input) {
- if(input !=null) {
- final List<TieredBlockPriceOverride> blockPriceOverrides = input.getTieredBlockPriceOverrides();
- for (TieredBlockPriceOverride blockDef : blockPriceOverrides) {
- String unitName = blockDef.getUnitName();
- Double max = blockDef.getMax();
- Double size = blockDef.getSize();
-
- for (TieredBlock curTieredBlock : curTieredBlocks)
- if (unitName.equals(curTieredBlock.getUnit().getName()) &&
- Double.compare(size, curTieredBlock.getSize()) == 0 &&
- Double.compare(max, curTieredBlock.getMax()) == 0) {
- return true;
- }
- }
- }
- return false;
+ if(input !=null) {
+ final List<TieredBlockPriceOverride> blockPriceOverrides = input.getTieredBlockPriceOverrides();
+ for (TieredBlockPriceOverride blockDef : blockPriceOverrides) {
+ String unitName = blockDef.getUnitName();
+ Double max = blockDef.getMax();
+ Double size = blockDef.getSize();
+ for (TieredBlock curTieredBlock : curTieredBlocks)
+ if (unitName.equals(curTieredBlock.getUnit().getName()) &&
+ Double.compare(size, curTieredBlock.getSize()) == 0 &&
+ Double.compare(max, curTieredBlock.getMax()) == 0) {
+ return true;
+ }
+ }
+ }
+ return false;
}
}).orNull();
-
tiers[i] = (overriddenTier != null) ? new DefaultTier(in.getTiers()[i], overriddenTier, currency) : (DefaultTier)in.getTiers()[i] ;
}
else {