killbill-aplcache
Changes
profiles/killbill/pom.xml 2(+1 -1)
Details
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/AccountResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/AccountResource.java
index 49d3e49..d80364a 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/AccountResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/AccountResource.java
@@ -379,7 +379,8 @@ public class AccountResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/{accountId:" + UUID_PATTERN + "}")
@ApiOperation(value = "Update account")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account data supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account data supplied")})
public Response updateAccount(@PathParam("accountId") final UUID accountId,
final AccountJson json,
@QueryParam(QUERY_ACCOUNT_TREAT_NULL_AS_RESET) @DefaultValue("false") final Boolean treatNullValueAsReset,
@@ -395,7 +396,7 @@ public class AccountResource extends JaxRsResourceBase {
} else {
accountUserApi.updateAccount(accountId, data, context.createCallContextWithAccountId(accountId, createdBy, reason, comment, request));
}
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -403,7 +404,8 @@ public class AccountResource extends JaxRsResourceBase {
@Path("/{accountId:" + UUID_PATTERN + "}")
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Close account")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied")})
public Response closeAccount(@PathParam("accountId") final UUID accountId,
@QueryParam(QUERY_CANCEL_ALL_SUBSCRIPTIONS) @DefaultValue("false") final Boolean cancelAllSubscriptions,
@QueryParam(QUERY_WRITE_OFF_UNPAID_INVOICES) @DefaultValue("false") final Boolean writeOffUnpaidInvoices,
@@ -469,8 +471,7 @@ public class AccountResource extends JaxRsResourceBase {
notificationQueue.removeFutureNotificationsForSearchKeys(accountRecordId, tenantRecordId);
}
}
-
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -631,7 +632,8 @@ public class AccountResource extends JaxRsResourceBase {
@Path("/{accountId:" + UUID_PATTERN + "}/" + EMAIL_NOTIFICATIONS)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Retrieve account email notification", response = InvoiceEmailJson.class)
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied"),
@ApiResponse(code = 404, message = "Account not found")})
public Response getEmailNotificationsForAccount(@PathParam("accountId") final UUID accountId,
@javax.ws.rs.core.Context final HttpServletRequest request) throws AccountApiException {
@@ -647,7 +649,8 @@ public class AccountResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Set account email notification")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied"),
@ApiResponse(code = 404, message = "Account not found")})
public Response setEmailNotificationsForAccount(@PathParam("accountId") final UUID accountId,
final InvoiceEmailJson json,
@@ -664,7 +667,7 @@ public class AccountResource extends JaxRsResourceBase {
mutableAccountData.setIsNotifiedForInvoices(json.isNotifiedForInvoices());
accountUserApi.updateAccount(accountId, mutableAccountData, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
/*
@@ -676,7 +679,8 @@ public class AccountResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Rebalance account CBA")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied")})
public Response rebalanceExistingCBAOnAccount(@PathParam("accountId") final UUID accountId,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -684,7 +688,7 @@ public class AccountResource extends JaxRsResourceBase {
@javax.ws.rs.core.Context final HttpServletRequest request) throws AccountApiException {
final CallContext callContext = context.createCallContextWithAccountId(accountId, createdBy, reason, comment, request);
invoiceApi.consumeExstingCBAOnAccountWithUnpaidInvoices(accountId, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@@ -763,7 +767,7 @@ public class AccountResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Path("/{accountId:" + UUID_PATTERN + "}/" + INVOICE_PAYMENTS)
@ApiOperation(value = "Trigger a payment for all unpaid invoices")
- @ApiResponses(value = {@ApiResponse(code = 200, message = "Successful operation"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
@ApiResponse(code = 404, message = "Invalid account id supplied")})
public Response payAllInvoices(@PathParam("accountId") final UUID accountId,
@QueryParam(QUERY_PAYMENT_EXTERNAL) @DefaultValue("false") final Boolean externalPayment,
@@ -807,7 +811,7 @@ public class AccountResource extends JaxRsResourceBase {
if (externalPayment && remainingRequestPayment.compareTo(BigDecimal.ZERO) > 0) {
invoiceApi.insertCredit(account.getId(), remainingRequestPayment, clock.getUTCToday(), account.getCurrency(), true, "pay all invoices", null, callContext);
}
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -889,7 +893,8 @@ public class AccountResource extends JaxRsResourceBase {
@Path("/{accountId:" + UUID_PATTERN + "}/" + PAYMENT_METHODS + "/refresh")
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Refresh account payment methods")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied"),
@ApiResponse(code = 404, message = "Account not found")})
public Response refreshPaymentMethods(@PathParam("accountId") final UUID accountId,
@QueryParam(QUERY_PAYMENT_PLUGIN_NAME) final String pluginName,
@@ -909,7 +914,7 @@ public class AccountResource extends JaxRsResourceBase {
paymentApi.refreshPaymentMethods(account, pluginProperties, callContext);
}
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -918,7 +923,7 @@ public class AccountResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/{accountId:" + UUID_PATTERN + "}/" + PAYMENT_METHODS + "/{paymentMethodId:" + UUID_PATTERN + "}/" + PAYMENT_METHODS_DEFAULT_PATH_POSTFIX)
@ApiOperation(value = "Set the default payment method")
- @ApiResponses(value = {/* @ApiResponse(code = 200, message = "Successful"),*/
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
@ApiResponse(code = 400, message = "Invalid account id or payment method id supplied"),
@ApiResponse(code = 404, message = "Account not found")})
public Response setDefaultPaymentMethod(@PathParam("accountId") final UUID accountId,
@@ -941,7 +946,7 @@ public class AccountResource extends JaxRsResourceBase {
createPurchaseForInvoice(account, invoice.getId(), invoice.getBalance(), paymentMethodId, false, null, null, pluginProperties, callContext);
}
}
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
/*
@@ -1227,7 +1232,8 @@ public class AccountResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to account")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied")})
public Response modifyAccountCustomFields(@PathParam(ID_PARAM_NAME) final UUID accountId,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -1244,7 +1250,8 @@ public class AccountResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from account")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied")})
public Response deleteAccountCustomFields(@PathParam(ID_PARAM_NAME) final UUID accountId,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -1317,7 +1324,8 @@ public class AccountResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove tags from account")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied or account does not have a default payment method (AUTO_PAY_OFF tag only)")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied or account does not have a default payment method (AUTO_PAY_OFF tag only)")})
public Response deleteAccountTags(@PathParam(ID_PARAM_NAME) final UUID accountId,
@QueryParam(QUERY_TAG) final List<UUID> tagList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -1411,7 +1419,8 @@ public class AccountResource extends JaxRsResourceBase {
@Path("/{accountId:" + UUID_PATTERN + "}/" + EMAILS + "/{email}")
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Delete email from account")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied")})
public Response removeEmail(@PathParam(ID_PARAM_NAME) final UUID accountId,
@PathParam("email") final String email,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -1426,7 +1435,7 @@ public class AccountResource extends JaxRsResourceBase {
accountUserApi.removeEmail(accountId, accountEmail, context.createCallContextWithAccountId(accountId, createdBy, reason, comment, request));
}
}
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@Override
@@ -1468,7 +1477,8 @@ public class AccountResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Move a given child credit to the parent level")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Account does not have credit"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Account does not have credit"),
@ApiResponse(code = 404, message = "Account not found")})
public Response transferChildCreditToParent(@PathParam("childAccountId") final UUID childAccountId,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -1480,7 +1490,7 @@ public class AccountResource extends JaxRsResourceBase {
final CallContext callContext = context.createCallContextWithAccountId(childAccountId, createdBy, reason, comment, request);
invoiceApi.transferChildCreditToParent(childAccountId, callContext);
- return Response.status(Response.Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
}
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/AdminResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/AdminResource.java
index da3b25c..963c891 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/AdminResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/AdminResource.java
@@ -234,7 +234,8 @@ public class AdminResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/payments/{paymentId:" + UUID_PATTERN + "}/transactions/{paymentTransactionId:" + UUID_PATTERN + "}")
@ApiOperation(value = "Update existing paymentTransaction and associated payment state")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account data supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account data supplied")})
public Response updatePaymentTransactionState(@PathParam("paymentId") final UUID paymentId,
@PathParam("paymentTransactionId") final UUID paymentTransactionId,
final AdminPaymentJson json,
@@ -255,7 +256,7 @@ public class AdminResource extends JaxRsResourceBase {
adminPaymentApi.fixPaymentTransactionState(payment, paymentTransaction, TransactionStatus.valueOf(json.getTransactionStatus()),
json.getLastSuccessPaymentState(), json.getCurrentPaymentStateName(), ImmutableList.<PluginProperty>of(), callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@POST
@@ -263,7 +264,8 @@ public class AdminResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/invoices")
@ApiOperation(value = "Trigger an invoice generation for all parked accounts")
- @ApiResponses(value = {@ApiResponse(code = 200, message = "Successful operation")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 200, message = "Successful operation")})
public Response triggerInvoiceGenerationForParkedAccounts(@QueryParam(QUERY_SEARCH_OFFSET) @DefaultValue("0") final Long offset,
@QueryParam(QUERY_SEARCH_LIMIT) @DefaultValue("100") final Long limit,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -325,7 +327,8 @@ public class AdminResource extends JaxRsResourceBase {
@Path("/" + CACHE)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Invalidates the given Cache if specified, otherwise invalidates all caches")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Cache name does not exist or is not alive")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Cache name does not exist or is not alive")})
public Response invalidatesCache(@QueryParam("cacheName") final String cacheName,
@javax.ws.rs.core.Context final HttpServletRequest request) {
if (null != cacheName && !cacheName.isEmpty()) {
@@ -341,14 +344,15 @@ public class AdminResource extends JaxRsResourceBase {
// if not given a specific cacheName, clear all
cacheControllerDispatcher.clearAll();
}
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@DELETE
@Path("/" + CACHE + "/" + ACCOUNTS + "/{accountId:" + UUID_PATTERN + "}/")
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Invalidates Caches per account level")
- @ApiResponses(value = {})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id supplied")})
public Response invalidatesCacheByAccount(@PathParam("accountId") final UUID accountId,
@javax.ws.rs.core.Context final HttpServletRequest request) {
@@ -367,14 +371,14 @@ public class AdminResource extends JaxRsResourceBase {
final CacheController<UUID, Integer> accountBCDCacheController = cacheControllerDispatcher.getCacheController(CacheType.ACCOUNT_BCD);
accountBCDCacheController.remove(accountId);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@DELETE
@Path("/" + CACHE + "/" + TENANTS)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Invalidates Caches per tenant level")
- @ApiResponses(value = {})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation")})
public Response invalidatesCacheByTenant(@javax.ws.rs.core.Context final HttpServletRequest request) throws TenantApiException {
// creating Tenant Context from Request
@@ -420,27 +424,27 @@ public class AdminResource extends JaxRsResourceBase {
final CacheController<Long, Catalog> tenantCatalogCacheController = cacheControllerDispatcher.getCacheController(CacheType.TENANT_CATALOG);
tenantCatalogCacheController.remove(tenantRecordId);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@PUT
@Path("/" + HEALTHCHECK)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Put the host back into rotation")
- @ApiResponses(value = {})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation")})
public Response putInRotation(@javax.ws.rs.core.Context final HttpServletRequest request) {
killbillHealthcheck.putInRotation();
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@DELETE
@Path("/" + HEALTHCHECK)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Put the host out of rotation")
- @ApiResponses(value = {})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation")})
public Response putOutOfRotation(@javax.ws.rs.core.Context final HttpServletRequest request) {
killbillHealthcheck.putOutOfRotation();
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
private Iterable<NotificationEventWithMetadata<NotificationEvent>> getNotifications(@Nullable final String queueName,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/BundleResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/BundleResource.java
index 78ffb7a..89af32f 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/BundleResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/BundleResource.java
@@ -234,7 +234,8 @@ public class BundleResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Pause a bundle")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid bundle id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid bundle id supplied"),
@ApiResponse(code = 404, message = "Bundle not found")})
public Response pauseBundle(@PathParam(ID_PARAM_NAME) final UUID bundleId,
@QueryParam(QUERY_REQUESTED_DT) final String requestedDate,
@@ -247,7 +248,7 @@ public class BundleResource extends JaxRsResourceBase {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
final LocalDate inputLocalDate = toLocalDate(requestedDate);
entitlementApi.pause(bundleId, inputLocalDate, pluginProperties, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -256,7 +257,8 @@ public class BundleResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Resume a bundle")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid bundle id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid bundle id supplied"),
@ApiResponse(code = 404, message = "Bundle not found")})
public Response resumeBundle(@PathParam(ID_PARAM_NAME) final UUID bundleId,
@QueryParam(QUERY_REQUESTED_DT) final String requestedDate,
@@ -269,7 +271,7 @@ public class BundleResource extends JaxRsResourceBase {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
final LocalDate inputLocalDate = toLocalDate(requestedDate);
entitlementApi.resume(bundleId, inputLocalDate, pluginProperties, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -333,7 +335,8 @@ public class BundleResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to bundle")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid bundle id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid bundle id supplied")})
public Response modifyBundleCustomFields(@PathParam(ID_PARAM_NAME) final UUID bundleId,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -353,7 +356,8 @@ public class BundleResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from bundle")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid bundle id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid bundle id supplied")})
public Response deleteBundleCustomFields(@PathParam(ID_PARAM_NAME) final UUID bundleId,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -418,7 +422,8 @@ public class BundleResource extends JaxRsResourceBase {
@Path("/{bundleId:" + UUID_PATTERN + "}/" + RENAME_KEY)
@Consumes(APPLICATION_JSON)
@ApiOperation(value = "Update a bundle externalKey")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid argumnent supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid argumnent supplied"),
@ApiResponse(code = 404, message = "Bundle not found")})
public Response renameExternalKey(@PathParam(ID_PARAM_NAME) final UUID bundleId,
final BundleJson json,
@@ -434,7 +439,7 @@ public class BundleResource extends JaxRsResourceBase {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
subscriptionApi.updateExternalKey(bundleId, json.getExternalKey(), callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@@ -464,7 +469,8 @@ public class BundleResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove tags from bundle")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid bundle id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid bundle id supplied")})
public Response deleteBundleTags(@PathParam(ID_PARAM_NAME) final UUID bundleId,
@QueryParam(QUERY_TAG) final List<UUID> tagList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/CatalogResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/CatalogResource.java
index 23ebb79..bdf5a1c 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/CatalogResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/CatalogResource.java
@@ -448,7 +448,7 @@ public class CatalogResource extends JaxRsResourceBase {
@DELETE
@ApiOperation(value = "Delete all versions for a per tenant catalog")
- @ApiResponses(value = {})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation")})
public Response deleteCatalog(@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@HeaderParam(HDR_COMMENT) final String comment,
@@ -456,7 +456,7 @@ public class CatalogResource extends JaxRsResourceBase {
@javax.ws.rs.core.Context final HttpServletRequest request) throws TenantApiException, CatalogApiException {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
catalogUserApi.deleteCatalog(callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
}
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceItemResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceItemResource.java
index 445a96b..0c46744 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceItemResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceItemResource.java
@@ -115,7 +115,8 @@ public class InvoiceItemResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to invoice item")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid invoice item id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid invoice item id supplied")})
public Response modifyInvoiceItemCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -133,7 +134,8 @@ public class InvoiceItemResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from invoice item")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid invoice item id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid invoice item id supplied")})
public Response deleteInvoiceItemCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -187,7 +189,8 @@ public class InvoiceItemResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove tags from invoice item")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid invoice item id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid invoice item id supplied")})
public Response deleteInvoiceItemTags(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_TAG) final List<UUID> tagList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoicePaymentResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoicePaymentResource.java
index 630c184..6efd741 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoicePaymentResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoicePaymentResource.java
@@ -268,7 +268,7 @@ public class InvoicePaymentResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Complete an existing transaction")
- @ApiResponses(value = {@ApiResponse(code = 200, message = "Payment transaction created successfully"),
+ @ApiResponses(value = {@ApiResponse(code = 201, message = "Payment transaction created successfully"),
@ApiResponse(code = 400, message = "Invalid paymentId supplied"),
@ApiResponse(code = 404, message = "Account or payment not found"),
@ApiResponse(code = 402, message = "Transaction declined by gateway"),
@@ -352,7 +352,8 @@ public class InvoicePaymentResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to payment")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid payment id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid payment id supplied")})
public Response modifyInvoicePaymentCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -370,7 +371,8 @@ public class InvoicePaymentResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from payment")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid payment id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid payment id supplied")})
public Response deleteInvoicePaymentCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -424,7 +426,8 @@ public class InvoicePaymentResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove tags from payment")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid payment id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid payment id supplied")})
public Response deleteInvoicePaymentTags(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_TAG) final List<UUID> tagList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceResource.java
index ef61369..e2ca068 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceResource.java
@@ -412,7 +412,8 @@ public class InvoiceResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Delete a CBA item")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid account id, invoice id or invoice item id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid account id, invoice id or invoice item id supplied"),
@ApiResponse(code = 404, message = "Account or invoice not found")})
public Response deleteCBA(@PathParam("invoiceId") final UUID invoiceId,
@PathParam("invoiceItemId") final UUID invoiceItemId,
@@ -427,7 +428,7 @@ public class InvoiceResource extends JaxRsResourceBase {
invoiceApi.deleteCBA(account.getId(), invoiceId, invoiceItemId, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -914,7 +915,8 @@ public class InvoiceResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to invoice")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid invoice id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid invoice id supplied")})
public Response modifyInvoiceCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -931,7 +933,8 @@ public class InvoiceResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from invoice")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid invoice id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid invoice id supplied")})
public Response deleteInvoiceCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -983,7 +986,8 @@ public class InvoiceResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove tags from invoice")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid invoice id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid invoice id supplied")})
public Response deleteInvoiceTags(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_TAG) final List<UUID> tagList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -1000,7 +1004,8 @@ public class InvoiceResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Perform the invoice status transition from DRAFT to COMMITTED")
- @ApiResponses(value = {@ApiResponse(code = 404, message = "Invoice not found")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 404, message = "Invoice not found")})
public Response commitInvoice(@PathParam("invoiceId") final UUID invoiceId,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -1010,7 +1015,7 @@ public class InvoiceResource extends JaxRsResourceBase {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
invoiceApi.commitInvoice(invoiceId, callContext);
- return Response.status(Response.Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -1019,7 +1024,8 @@ public class InvoiceResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Perform the action of voiding an invoice")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid invoice id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid invoice id supplied"),
@ApiResponse(code = 404, message = "Invoice not found")})
public Response voidInvoice(@PathParam("invoiceId") final UUID invoiceId,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -1030,7 +1036,7 @@ public class InvoiceResource extends JaxRsResourceBase {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
invoiceApi.voidInvoice(invoiceId, callContext);
- return Response.status(Response.Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@Override
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/JaxRsResourceBase.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/JaxRsResourceBase.java
index b40c4fc..c91e5be 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/JaxRsResourceBase.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/JaxRsResourceBase.java
@@ -233,7 +233,7 @@ public abstract class JaxRsResourceBase implements JaxrsResource {
final List<UUID> tagList,
final CallContext context) throws TagApiException {
tagUserApi.removeTags(id, getObjectType(), tagList, context);
- return Response.status(Response.Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
protected Response getCustomFields(final UUID id, final AuditMode auditMode, final TenantContext context) {
@@ -279,7 +279,7 @@ public abstract class JaxRsResourceBase implements JaxrsResource {
}
customFieldUserApi.updateCustomFields(input, context);
- return Response.status(Response.Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
/**
@@ -316,7 +316,7 @@ public abstract class JaxRsResourceBase implements JaxrsResource {
final List<CustomField> input = ImmutableList.<CustomField>copyOf(inputIterable);
customFieldUserApi.removeCustomFields(input, context);
}
- return Response.status(Response.Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
protected <E extends Entity, J extends JsonBase> Response buildStreamingPaginationResponse(final Pagination<E> entities,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/NodesInfoResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/NodesInfoResource.java
index 79a6a29..7467e14 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/NodesInfoResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/NodesInfoResource.java
@@ -146,7 +146,7 @@ public class NodesInfoResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Trigger a node command")
- @ApiResponses(value = {@ApiResponse(code = 200, message = "Success"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
@ApiResponse(code = 400, message = "Invalid node command supplied")})
public Response triggerNodeCommand(final NodeCommandJson json,
@QueryParam(QUERY_LOCAL_NODE_ONLY) @DefaultValue("false") final Boolean localNodeOnly,
@@ -174,7 +174,7 @@ public class NodesInfoResource extends JaxRsResourceBase {
};
killbillInfoApi.triggerNodeCommand(nodeCommand, localNodeOnly);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/PaymentMethodResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/PaymentMethodResource.java
index d0dd4da..4a8e6cc 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/PaymentMethodResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/PaymentMethodResource.java
@@ -260,7 +260,8 @@ public class PaymentMethodResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/{paymentMethodId:" + UUID_PATTERN + "}")
@ApiOperation(value = "Delete a payment method")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid paymentMethodId supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid paymentMethodId supplied"),
@ApiResponse(code = 404, message = "Account or payment method not found")})
public Response deletePaymentMethod(@PathParam("paymentMethodId") final UUID paymentMethodId,
@QueryParam(QUERY_DELETE_DEFAULT_PM_WITH_AUTO_PAY_OFF) @DefaultValue("false") final Boolean deleteDefaultPaymentMethodWithAutoPayOff,
@@ -278,7 +279,7 @@ public class PaymentMethodResource extends JaxRsResourceBase {
paymentApi.deletePaymentMethod(account, paymentMethodId, deleteDefaultPaymentMethodWithAutoPayOff, forceDefaultPaymentMethodDeletion, pluginProperties, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -319,7 +320,8 @@ public class PaymentMethodResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to payment method")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid payment method id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid payment method id supplied")})
public Response modifyPaymentMethodCustomFields(@PathParam("paymentMethodId") final UUID paymentMethodId,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -337,7 +339,8 @@ public class PaymentMethodResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from payment method")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid payment method id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid payment method id supplied")})
public Response deletePaymentMethodCustomFields(@PathParam("paymentMethodId") final UUID paymentMethodId,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/PaymentResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/PaymentResource.java
index f4de22e..e4cdfd0 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/PaymentResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/PaymentResource.java
@@ -749,7 +749,8 @@ public class PaymentResource extends ComboPaymentResource {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Cancels a scheduled payment attempt retry")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid paymentTransactionId supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid paymentTransactionId supplied")})
public Response cancelScheduledPaymentTransactionById(@PathParam("paymentTransactionId") final UUID paymentTransactionId,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -758,7 +759,7 @@ public class PaymentResource extends ComboPaymentResource {
@javax.ws.rs.core.Context final HttpServletRequest request) throws PaymentApiException, AccountApiException {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
paymentApi.cancelScheduledPaymentTransaction(paymentTransactionId, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource(name = "cancelScheduledPaymentTransaction")
@@ -767,7 +768,8 @@ public class PaymentResource extends ComboPaymentResource {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Cancels a scheduled payment attempt retry")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid paymentTransactionExternalKey supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid paymentTransactionExternalKey supplied")})
public Response cancelScheduledPaymentTransactionByExternalKey(@ApiParam(required=true) @QueryParam(QUERY_TRANSACTION_EXTERNAL_KEY) final String paymentTransactionExternalKey,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -776,12 +778,11 @@ public class PaymentResource extends ComboPaymentResource {
@javax.ws.rs.core.Context final HttpServletRequest request) throws PaymentApiException, AccountApiException {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
paymentApi.cancelScheduledPaymentTransaction(paymentTransactionExternalKey, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
-
@TimedResource
@GET
@Path("/{paymentId:" + UUID_PATTERN + "}/" + CUSTOM_FIELDS)
@@ -819,7 +820,8 @@ public class PaymentResource extends ComboPaymentResource {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to payment")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid payment id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid payment id supplied")})
public Response modifyPaymentCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -836,7 +838,8 @@ public class PaymentResource extends ComboPaymentResource {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from payment payment")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid payment id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid payment id supplied")})
public Response deletePaymentCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -888,7 +891,8 @@ public class PaymentResource extends ComboPaymentResource {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove tags from payment payment")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid payment id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid payment id supplied")})
public Response deletePaymentTags(@PathParam(ID_PARAM_NAME) final UUID paymentId,
@QueryParam(QUERY_TAG) final List<UUID> tagList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/SecurityResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/SecurityResource.java
index d5e8322..f9900a1 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/SecurityResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/SecurityResource.java
@@ -134,6 +134,7 @@ public class SecurityResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/users/{username:" + ANYTHING_PATTERN + "}/password")
@ApiOperation(value = "Update a user password")
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation")})
public Response updateUserPassword(@PathParam("username") final String username,
final UserRolesJson json,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -142,7 +143,7 @@ public class SecurityResource extends JaxRsResourceBase {
@javax.ws.rs.core.Context final HttpServletRequest request,
@javax.ws.rs.core.Context final UriInfo uriInfo) throws SecurityApiException {
securityApi.updateUserPassword(username, json.getPassword(), context.createCallContextNoAccountId(createdBy, reason, comment, request));
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -164,7 +165,8 @@ public class SecurityResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/users/{username:" + ANYTHING_PATTERN + "}/roles")
@ApiOperation(value = "Update roles associated to a user")
- public Response updateUserRoles(@PathParam("username") final String username,
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation")})
+ public Response updateUserRoles(@PathParam("username") final String username,
final UserRolesJson json,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -172,7 +174,7 @@ public class SecurityResource extends JaxRsResourceBase {
@javax.ws.rs.core.Context final HttpServletRequest request,
@javax.ws.rs.core.Context final UriInfo uriInfo) throws SecurityApiException {
securityApi.updateUserRoles(username, json.getRoles(), context.createCallContextNoAccountId(createdBy, reason, comment, request));
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -181,6 +183,7 @@ public class SecurityResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/users/{username:" + ANYTHING_PATTERN + "}")
@ApiOperation(value = "Invalidate an existing user")
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation")})
public Response invalidateUser(@PathParam("username") final String username,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -230,6 +233,7 @@ public class SecurityResource extends JaxRsResourceBase {
@Produces(APPLICATION_JSON)
@Path("/roles")
@ApiOperation(value = "Update a new role definition)")
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation")})
public Response updateRoleDefinition(final RoleDefinitionJson json,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -237,7 +241,7 @@ public class SecurityResource extends JaxRsResourceBase {
@javax.ws.rs.core.Context final HttpServletRequest request,
@javax.ws.rs.core.Context final UriInfo uriInfo) throws SecurityApiException {
securityApi.updateRoleDefinition(json.getRole(), json.getPermissions(), context.createCallContextNoAccountId(createdBy, reason, comment, request));
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
}
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/SubscriptionResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/SubscriptionResource.java
index f0ebac5..7172209 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/SubscriptionResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/SubscriptionResource.java
@@ -48,7 +48,6 @@ import org.killbill.billing.account.api.Account;
import org.killbill.billing.account.api.AccountApiException;
import org.killbill.billing.account.api.AccountUserApi;
import org.killbill.billing.catalog.api.BillingActionPolicy;
-import org.killbill.billing.catalog.api.BillingPeriod;
import org.killbill.billing.catalog.api.CatalogApiException;
import org.killbill.billing.catalog.api.Currency;
import org.killbill.billing.catalog.api.PhaseType;
@@ -87,7 +86,6 @@ import org.killbill.billing.jaxrs.util.JaxrsUriBuilder;
import org.killbill.billing.jaxrs.util.KillbillEventHandler;
import org.killbill.billing.payment.api.PaymentApi;
import org.killbill.billing.payment.api.PluginProperty;
-import org.killbill.billing.util.api.AuditLevel;
import org.killbill.billing.util.api.AuditUserApi;
import org.killbill.billing.util.api.CustomFieldApiException;
import org.killbill.billing.util.api.CustomFieldUserApi;
@@ -508,7 +506,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
@Path("/{subscriptionId:" + UUID_PATTERN + "}/" + UNDO_CANCEL)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Un-cancel an entitlement")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid subscription id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid subscription id supplied"),
@ApiResponse(code = 404, message = "Entitlement not found")})
public Response uncancelSubscriptionPlan(@PathParam("subscriptionId") final UUID subscriptionId,
@QueryParam(QUERY_PLUGIN_PROPERTY) final List<String> pluginPropertiesString,
@@ -519,7 +518,7 @@ public class SubscriptionResource extends JaxRsResourceBase {
final Iterable<PluginProperty> pluginProperties = extractPluginProperties(pluginPropertiesString);
final Entitlement current = entitlementApi.getEntitlementForId(subscriptionId, context.createCallContextNoAccountId(createdBy, reason, comment, request));
current.uncancelEntitlement(pluginProperties, context.createCallContextNoAccountId(createdBy, reason, comment, request));
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -527,7 +526,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
@Path("/{subscriptionId:" + UUID_PATTERN + "}/" + UNDO_CHANGE_PLAN)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Undo a pending change plan on an entitlement")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid subscription id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid subscription id supplied"),
@ApiResponse(code = 404, message = "Entitlement not found")})
public Response undoChangeSubscriptionPlan(@PathParam("subscriptionId") final UUID subscriptionId,
@QueryParam(QUERY_PLUGIN_PROPERTY) final List<String> pluginPropertiesString,
@@ -538,7 +538,7 @@ public class SubscriptionResource extends JaxRsResourceBase {
final Iterable<PluginProperty> pluginProperties = extractPluginProperties(pluginPropertiesString);
final Entitlement current = entitlementApi.getEntitlementForId(subscriptionId, context.createCallContextNoAccountId(createdBy, reason, comment, request));
current.undoChangePlan(pluginProperties, context.createCallContextNoAccountId(createdBy, reason, comment, request));
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@TimedResource
@@ -547,7 +547,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Path("/{subscriptionId:" + UUID_PATTERN + "}")
@ApiOperation(value = "Change entitlement plan")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid subscription id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid subscription id supplied"),
@ApiResponse(code = 404, message = "Entitlement not found")})
public Response changeSubscriptionPlan(@PathParam("subscriptionId") final UUID subscriptionId,
final SubscriptionJson entitlement,
@@ -600,7 +601,7 @@ public class SubscriptionResource extends JaxRsResourceBase {
isImmediateOp = newEntitlement.getLastActiveProduct().getName().equals(entitlement.getProductName()) &&
newEntitlement.getLastActivePlan().getRecurringBillingPeriod() == entitlement.getBillingPeriod() &&
newEntitlement.getLastActivePriceList().getName().equals(entitlement.getPriceList());
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@Override
@@ -613,7 +614,7 @@ public class SubscriptionResource extends JaxRsResourceBase {
if (operationResponse.getStatus() != Status.OK.getStatusCode()) {
return operationResponse;
}
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
};
@@ -648,7 +649,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
@Path("/{subscriptionId:" + UUID_PATTERN + "}")
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Cancel an entitlement plan")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid subscription id supplied"),
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid subscription id supplied"),
@ApiResponse(code = 404, message = "Entitlement not found")})
public Response cancelSubscriptionPlan(@PathParam("subscriptionId") final UUID subscriptionId,
@QueryParam(QUERY_REQUESTED_DT) final String requestedDate,
@@ -692,7 +694,7 @@ public class SubscriptionResource extends JaxRsResourceBase {
final LocalDate nowInAccountTimeZone = new LocalDate(clock.getUTCNow(), subscription.getBillingEndDate().getChronology().getZone());
isImmediateOp = subscription.getBillingEndDate() != null &&
!subscription.getBillingEndDate().isAfter(nowInAccountTimeZone);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@Override
@@ -716,7 +718,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Path("/{subscriptionId:" + UUID_PATTERN + "}/" + BCD)
@ApiOperation(value = "Update the BCD associated to a subscription")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid entitlement supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid entitlement supplied")})
public Response updateSubscriptionBCD(@PathParam(ID_PARAM_NAME) final UUID subscriptionId,
final SubscriptionJson json,
@QueryParam(QUERY_ENTITLEMENT_EFFECTIVE_FROM_DT) final String effectiveFromDateStr,
@@ -753,9 +756,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
break;
}
}
-
entitlement.updateBCD(json.getBillCycleDayLocal(), effectiveFromDate, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
private static final class CompletionUserRequestEntitlement extends CompletionUserRequestBase {
@@ -894,7 +896,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to subscription")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid subscription id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid subscription id supplied")})
public Response modifySubscriptionCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -910,7 +913,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from subscription")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid subscription id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid subscription id supplied")})
public Response deleteSubscriptionCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -959,7 +963,8 @@ public class SubscriptionResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove tags from subscription")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid subscription id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid subscription id supplied")})
public Response deleteSubscriptionTags(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_TAG) final List<UUID> tagList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TagDefinitionResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TagDefinitionResource.java
index 44b2efe..2ef7f96 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TagDefinitionResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TagDefinitionResource.java
@@ -144,7 +144,8 @@ public class TagDefinitionResource extends JaxRsResourceBase {
@Path("/{tagDefinitionId:" + UUID_PATTERN + "}")
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Delete a tag definition")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid tagDefinitionId supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid tagDefinitionId supplied")})
public Response deleteTagDefinition(@PathParam("tagDefinitionId") final UUID tagDefId,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TenantResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TenantResource.java
index be9a9cd..2f99d6d 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TenantResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TenantResource.java
@@ -179,7 +179,8 @@ public class TenantResource extends JaxRsResourceBase {
@DELETE
@Path("/" + REGISTER_NOTIFICATION_CALLBACK)
@ApiOperation(value = "Delete a push notification")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid tenantId supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid tenantId supplied")})
public Response deletePushNotificationCallbacks(@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@HeaderParam(HDR_COMMENT) final String comment,
@@ -222,7 +223,8 @@ public class TenantResource extends JaxRsResourceBase {
@DELETE
@Path("/" + UPLOAD_PLUGIN_CONFIG + "/{pluginName:" + ANYTHING_PATTERN + "}")
@ApiOperation(value = "Delete a per tenant configuration for a plugin")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid tenantId supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid tenantId supplied")})
public Response deletePluginConfiguration(@PathParam("pluginName") final String pluginName,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -282,7 +284,8 @@ public class TenantResource extends JaxRsResourceBase {
@DELETE
@Path("/" + UPLOAD_PER_TENANT_CONFIG)
@ApiOperation(value = "Delete a per tenant configuration (system properties)")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid tenantId supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid tenantId supplied")})
public Response deletePerTenantConfiguration(@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@HeaderParam(HDR_COMMENT) final String comment,
@@ -323,7 +326,8 @@ public class TenantResource extends JaxRsResourceBase {
@DELETE
@Path("/" + UPLOAD_PLUGIN_PAYMENT_STATE_MACHINE_CONFIG + "/{pluginName:" + ANYTHING_PATTERN + "}")
@ApiOperation(value = "Delete a per tenant payment state machine for a plugin")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid tenantId supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid tenantId supplied")})
public Response deletePluginPaymentStateMachineConfig(@PathParam("pluginName") final String pluginName,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -371,7 +375,8 @@ public class TenantResource extends JaxRsResourceBase {
@DELETE
@Path("/" + USER_KEY_VALUE + "/{keyName:" + ANYTHING_PATTERN + "}")
@ApiOperation(value = "Delete a per tenant user key/value")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid tenantId supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid tenantId supplied")})
public Response deleteUserKeyValue(@PathParam("keyName") final String key,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@HeaderParam(HDR_REASON) final String reason,
@@ -379,7 +384,7 @@ public class TenantResource extends JaxRsResourceBase {
@javax.ws.rs.core.Context final HttpServletRequest request) throws TenantApiException {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
tenantApi.deleteTenantKey(key, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@@ -421,7 +426,7 @@ public class TenantResource extends JaxRsResourceBase {
final CallContext callContext = context.createCallContextNoAccountId(createdBy, reason, comment, request);
final String tenantKey = keyPostfix != null ? key.toString() + keyPostfix : key.toString();
tenantApi.deleteTenantKey(tenantKey, callContext);
- return Response.status(Status.OK).build();
+ return Response.status(Status.NO_CONTENT).build();
}
@Override
diff --git a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TransactionResource.java b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TransactionResource.java
index 8a7e112..79d79e9 100644
--- a/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TransactionResource.java
+++ b/jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/TransactionResource.java
@@ -184,7 +184,8 @@ public class TransactionResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Modify custom fields to payment transaction")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid transaction id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid transaction id supplied")})
public Response modifyTransactionCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
final List<CustomFieldJson> customFields,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -202,7 +203,8 @@ public class TransactionResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove custom fields from payment transaction")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid transaction id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid transaction id supplied")})
public Response deleteTransactionCustomFields(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_CUSTOM_FIELD) final List<UUID> customFieldList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
@@ -254,7 +256,8 @@ public class TransactionResource extends JaxRsResourceBase {
@Consumes(APPLICATION_JSON)
@Produces(APPLICATION_JSON)
@ApiOperation(value = "Remove tags from payment transaction")
- @ApiResponses(value = {@ApiResponse(code = 400, message = "Invalid transaction id supplied")})
+ @ApiResponses(value = {@ApiResponse(code = 204, message = "Successful operation"),
+ @ApiResponse(code = 400, message = "Invalid transaction id supplied")})
public Response deleteTransactionTags(@PathParam(ID_PARAM_NAME) final UUID id,
@QueryParam(QUERY_TAG) final List<UUID> tagList,
@HeaderParam(HDR_CREATED_BY) final String createdBy,
profiles/killbill/pom.xml 2(+1 -1)
diff --git a/profiles/killbill/pom.xml b/profiles/killbill/pom.xml
index 6835d48..020b7d2 100644
--- a/profiles/killbill/pom.xml
+++ b/profiles/killbill/pom.xml
@@ -263,7 +263,7 @@
<dependency>
<groupId>org.kill-bill.billing</groupId>
<artifactId>killbill-client-java-swagger-gen-exp</artifactId>
- <version>0.0.3</version>
+ <version>0.0.4</version>
</dependency>
<dependency>
<groupId>org.kill-bill.billing</groupId>