Details
diff --git a/api/src/main/java/com/ning/billing/payment/api/PaymentApi.java b/api/src/main/java/com/ning/billing/payment/api/PaymentApi.java
index 479966a..f6e6eea 100644
--- a/api/src/main/java/com/ning/billing/payment/api/PaymentApi.java
+++ b/api/src/main/java/com/ning/billing/payment/api/PaymentApi.java
@@ -25,9 +25,6 @@ import com.ning.billing.util.callcontext.CallContext;
public interface PaymentApi {
- public Payment createPayment(final String accountKey, final UUID invoiceId, final BigDecimal amount, final CallContext context)
- throws PaymentApiException;
-
public Payment createPayment(final Account account, final UUID invoiceId, final BigDecimal amount, final CallContext context)
throws PaymentApiException;
diff --git a/payment/src/main/java/com/ning/billing/payment/api/DefaultPaymentApi.java b/payment/src/main/java/com/ning/billing/payment/api/DefaultPaymentApi.java
index 9e2f0af..c2e2fb2 100644
--- a/payment/src/main/java/com/ning/billing/payment/api/DefaultPaymentApi.java
+++ b/payment/src/main/java/com/ning/billing/payment/api/DefaultPaymentApi.java
@@ -17,13 +17,10 @@
package com.ning.billing.payment.api;
import java.math.BigDecimal;
-import java.util.ArrayList;
import java.util.List;
import java.util.Set;
import java.util.UUID;
-import com.google.common.base.Function;
-import com.google.common.collect.Collections2;
import com.google.inject.Inject;
import com.ning.billing.ErrorCode;
import com.ning.billing.account.api.Account;
@@ -49,12 +46,6 @@ public class DefaultPaymentApi implements PaymentApi {
}
@Override
- public Payment createPayment(final String accountKey, final UUID invoiceId, final BigDecimal amount, final CallContext context)
- throws PaymentApiException {
- return paymentProcessor.createPayment(accountKey, invoiceId, amount, context, true);
- }
-
- @Override
public Payment createPayment(final Account account, final UUID invoiceId,
final BigDecimal amount, final CallContext context) throws PaymentApiException {
return paymentProcessor.createPayment(account, invoiceId, amount, context, true);
diff --git a/payment/src/main/java/com/ning/billing/payment/core/PaymentProcessor.java b/payment/src/main/java/com/ning/billing/payment/core/PaymentProcessor.java
index f820705..c6d29a0 100644
--- a/payment/src/main/java/com/ning/billing/payment/core/PaymentProcessor.java
+++ b/payment/src/main/java/com/ning/billing/payment/core/PaymentProcessor.java
@@ -197,19 +197,6 @@ public class PaymentProcessor extends ProcessorBase {
}
}
-
- public Payment createPayment(final String accountKey, final UUID invoiceId, final BigDecimal inputAmount, final CallContext context, final boolean isInstantPayment)
- throws PaymentApiException {
- try {
- final Account account = accountUserApi.getAccountByKey(accountKey);
- return createPayment(account, invoiceId, inputAmount, context, isInstantPayment);
- } catch (AccountApiException e) {
- throw new PaymentApiException(e);
- }
- }
-
-
-
public Payment createPayment(final Account account, final UUID invoiceId, final BigDecimal inputAmount, final CallContext context, final boolean isInstantPayment)
throws PaymentApiException {
final PaymentPluginApi plugin = getPaymentProviderPlugin(account);
diff --git a/payment/src/test/java/com/ning/billing/payment/api/TestPaymentApi.java b/payment/src/test/java/com/ning/billing/payment/api/TestPaymentApi.java
index a1a649e..88369bf 100644
--- a/payment/src/test/java/com/ning/billing/payment/api/TestPaymentApi.java
+++ b/payment/src/test/java/com/ning/billing/payment/api/TestPaymentApi.java
@@ -157,7 +157,7 @@ public class TestPaymentApi extends PaymentTestSuite {
Currency.USD));
try {
- final Payment paymentInfo = paymentApi.createPayment(account.getExternalKey(), invoice.getId(), requestedAmount, context);
+ final Payment paymentInfo = paymentApi.createPayment(account, invoice.getId(), requestedAmount, context);
if (expectedAmount == null) {
fail("Expected to fail because requested amount > invoice amount");
}
diff --git a/payment/src/test/java/com/ning/billing/payment/TestRetryService.java b/payment/src/test/java/com/ning/billing/payment/TestRetryService.java
index 9a002cb..aef8f1b 100644
--- a/payment/src/test/java/com/ning/billing/payment/TestRetryService.java
+++ b/payment/src/test/java/com/ning/billing/payment/TestRetryService.java
@@ -172,7 +172,7 @@ public class TestRetryService extends PaymentTestSuite {
setPaymentFailure(failureType);
boolean failed = false;
try {
- paymentProcessor.createPayment(account.getExternalKey(), invoice.getId(), amount, context, false);
+ paymentProcessor.createPayment(account, invoice.getId(), amount, context, false);
} catch (PaymentApiException e) {
failed = true;
}