killbill-aplcache
Changes
analytics/src/main/java/com/ning/billing/analytics/BusinessSubscriptionTransitionRecorder.java 12(+6 -6)
analytics/src/main/java/com/ning/billing/analytics/dao/BusinessSubscriptionTransitionDaoProvider.java 6(+3 -3)
analytics/src/main/java/com/ning/billing/analytics/dao/BusinessSubscriptionTransitionSqlDao.java 2(+1 -1)
analytics/src/main/resources/com/ning/billing/analytics/dao/BusinessInvoiceItemSqlDao.sql.stg 0(+0 -0)
analytics/src/main/resources/com/ning/billing/analytics/dao/BusinessInvoicePaymentSqlDao.sql.stg 0(+0 -0)
analytics/src/main/resources/com/ning/billing/analytics/dao/BusinessOverdueStatusSqlDao.sql.stg 0(+0 -0)
analytics/src/main/resources/com/ning/billing/analytics/dao/BusinessSubscriptionTransitionSqlDao.sql.stg 0(+0 -0)
Details
diff --git a/analytics/src/main/java/com/ning/billing/analytics/BusinessAccountRecorder.java b/analytics/src/main/java/com/ning/billing/analytics/BusinessAccountRecorder.java
index c540daf..7f69fef 100644
--- a/analytics/src/main/java/com/ning/billing/analytics/BusinessAccountRecorder.java
+++ b/analytics/src/main/java/com/ning/billing/analytics/BusinessAccountRecorder.java
@@ -32,7 +32,7 @@ import com.ning.billing.account.api.AccountApiException;
import com.ning.billing.account.api.AccountData;
import com.ning.billing.account.api.AccountUserApi;
import com.ning.billing.account.api.ChangedField;
-import com.ning.billing.analytics.dao.BusinessAccountDao;
+import com.ning.billing.analytics.dao.BusinessAccountSqlDao;
import com.ning.billing.analytics.model.BusinessAccount;
import com.ning.billing.invoice.api.Invoice;
import com.ning.billing.invoice.api.InvoiceUserApi;
@@ -47,17 +47,17 @@ import com.ning.billing.util.tag.Tag;
public class BusinessAccountRecorder {
private static final Logger log = LoggerFactory.getLogger(BusinessAccountRecorder.class);
- private final BusinessAccountDao dao;
+ private final BusinessAccountSqlDao sqlDao;
private final AccountUserApi accountApi;
private final InvoiceUserApi invoiceUserApi;
private final PaymentApi paymentApi;
private final TagUserApi tagUserApi;
@Inject
- public BusinessAccountRecorder(final BusinessAccountDao dao, final AccountUserApi accountApi,
+ public BusinessAccountRecorder(final BusinessAccountSqlDao sqlDao, final AccountUserApi accountApi,
final InvoiceUserApi invoiceUserApi, final PaymentApi paymentApi,
final TagUserApi tagUserApi) {
- this.dao = dao;
+ this.sqlDao = sqlDao;
this.accountApi = accountApi;
this.invoiceUserApi = invoiceUserApi;
this.paymentApi = paymentApi;
@@ -72,7 +72,7 @@ public class BusinessAccountRecorder {
final BusinessAccount bac = createBusinessAccountFromAccount(account, new ArrayList<Tag>(tags.values()));
log.info("ACCOUNT CREATION " + bac);
- dao.createAccount(bac);
+ sqlDao.createAccount(bac);
} catch (AccountApiException e) {
log.warn("Error encountered creating BusinessAccount", e);
}
@@ -118,15 +118,15 @@ public class BusinessAccountRecorder {
return;
}
- BusinessAccount bac = dao.getAccount(account.getExternalKey());
+ BusinessAccount bac = sqlDao.getAccount(account.getExternalKey());
if (bac == null) {
bac = createBusinessAccountFromAccount(account, new ArrayList<Tag>(tags.values()));
log.info("ACCOUNT CREATION " + bac);
- dao.createAccount(bac);
+ sqlDao.createAccount(bac);
} else {
updateBusinessAccountFromAccount(account, bac);
log.info("ACCOUNT UPDATE " + bac);
- dao.saveAccount(bac);
+ sqlDao.saveAccount(bac);
}
} catch (AccountApiException e) {
log.warn("Error encountered creating BusinessAccount", e);
diff --git a/analytics/src/main/java/com/ning/billing/analytics/BusinessSubscriptionTransitionRecorder.java b/analytics/src/main/java/com/ning/billing/analytics/BusinessSubscriptionTransitionRecorder.java
index 37733c3..04e3547 100644
--- a/analytics/src/main/java/com/ning/billing/analytics/BusinessSubscriptionTransitionRecorder.java
+++ b/analytics/src/main/java/com/ning/billing/analytics/BusinessSubscriptionTransitionRecorder.java
@@ -26,7 +26,7 @@ import com.google.inject.Inject;
import com.ning.billing.account.api.Account;
import com.ning.billing.account.api.AccountApiException;
import com.ning.billing.account.api.AccountUserApi;
-import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionDao;
+import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionSqlDao;
import com.ning.billing.analytics.model.BusinessSubscription;
import com.ning.billing.analytics.model.BusinessSubscriptionEvent;
import com.ning.billing.analytics.model.BusinessSubscriptionTransition;
@@ -40,14 +40,14 @@ import com.ning.billing.entitlement.api.user.SubscriptionEvent;
public class BusinessSubscriptionTransitionRecorder {
private static final Logger log = LoggerFactory.getLogger(BusinessSubscriptionTransitionRecorder.class);
- private final BusinessSubscriptionTransitionDao dao;
+ private final BusinessSubscriptionTransitionSqlDao sqlDao;
private final EntitlementUserApi entitlementApi;
private final AccountUserApi accountApi;
private final CatalogService catalogService;
@Inject
- public BusinessSubscriptionTransitionRecorder(final BusinessSubscriptionTransitionDao dao, final CatalogService catalogService, final EntitlementUserApi entitlementApi, final AccountUserApi accountApi) {
- this.dao = dao;
+ public BusinessSubscriptionTransitionRecorder(final BusinessSubscriptionTransitionSqlDao sqlDao, final CatalogService catalogService, final EntitlementUserApi entitlementApi, final AccountUserApi accountApi) {
+ this.sqlDao = sqlDao;
this.catalogService = catalogService;
this.entitlementApi = entitlementApi;
this.accountApi = accountApi;
@@ -106,7 +106,7 @@ public class BusinessSubscriptionTransitionRecorder {
DateTime previousEffectiveTransitionTime = null;
// For creation events, the prev subscription will always be null
if (event.getEventType() != BusinessSubscriptionEvent.EventType.ADD) {
- final List<BusinessSubscriptionTransition> transitions = dao.getTransitions(externalKey);
+ final List<BusinessSubscriptionTransition> transitions = sqlDao.getTransitions(externalKey);
if (transitions != null && transitions.size() > 0) {
final BusinessSubscriptionTransition lastTransition = transitions.get(transitions.size() - 1);
if (lastTransition != null && lastTransition.getNextSubscription() != null) {
@@ -147,6 +147,6 @@ public class BusinessSubscriptionTransitionRecorder {
);
log.info(transition.getEvent() + " " + transition);
- dao.createTransition(transition);
+ sqlDao.createTransition(transition);
}
}
diff --git a/analytics/src/main/java/com/ning/billing/analytics/dao/BusinessAccountDaoProvider.java b/analytics/src/main/java/com/ning/billing/analytics/dao/BusinessAccountDaoProvider.java
index f2a9bf4..1ec176c 100644
--- a/analytics/src/main/java/com/ning/billing/analytics/dao/BusinessAccountDaoProvider.java
+++ b/analytics/src/main/java/com/ning/billing/analytics/dao/BusinessAccountDaoProvider.java
@@ -21,7 +21,7 @@ import org.skife.jdbi.v2.IDBI;
import com.google.inject.Inject;
import com.google.inject.Provider;
-public class BusinessAccountDaoProvider implements Provider<BusinessAccountDao> {
+public class BusinessAccountDaoProvider implements Provider<BusinessAccountSqlDao> {
private final IDBI dbi;
@Inject
@@ -30,7 +30,7 @@ public class BusinessAccountDaoProvider implements Provider<BusinessAccountDao>
}
@Override
- public BusinessAccountDao get() {
- return dbi.onDemand(BusinessAccountDao.class);
+ public BusinessAccountSqlDao get() {
+ return dbi.onDemand(BusinessAccountSqlDao.class);
}
}
diff --git a/analytics/src/main/java/com/ning/billing/analytics/dao/BusinessSubscriptionTransitionDaoProvider.java b/analytics/src/main/java/com/ning/billing/analytics/dao/BusinessSubscriptionTransitionDaoProvider.java
index 3519011..922614f 100644
--- a/analytics/src/main/java/com/ning/billing/analytics/dao/BusinessSubscriptionTransitionDaoProvider.java
+++ b/analytics/src/main/java/com/ning/billing/analytics/dao/BusinessSubscriptionTransitionDaoProvider.java
@@ -21,7 +21,7 @@ import org.skife.jdbi.v2.IDBI;
import com.google.inject.Inject;
import com.google.inject.Provider;
-public class BusinessSubscriptionTransitionDaoProvider implements Provider<BusinessSubscriptionTransitionDao> {
+public class BusinessSubscriptionTransitionDaoProvider implements Provider<BusinessSubscriptionTransitionSqlDao> {
private final IDBI dbi;
@Inject
@@ -30,7 +30,7 @@ public class BusinessSubscriptionTransitionDaoProvider implements Provider<Busin
}
@Override
- public BusinessSubscriptionTransitionDao get() {
- return dbi.onDemand(BusinessSubscriptionTransitionDao.class);
+ public BusinessSubscriptionTransitionSqlDao get() {
+ return dbi.onDemand(BusinessSubscriptionTransitionSqlDao.class);
}
}
diff --git a/analytics/src/main/java/com/ning/billing/analytics/setup/AnalyticsModule.java b/analytics/src/main/java/com/ning/billing/analytics/setup/AnalyticsModule.java
index 2233e1e..d6f0197 100644
--- a/analytics/src/main/java/com/ning/billing/analytics/setup/AnalyticsModule.java
+++ b/analytics/src/main/java/com/ning/billing/analytics/setup/AnalyticsModule.java
@@ -23,16 +23,16 @@ import com.ning.billing.analytics.BusinessAccountRecorder;
import com.ning.billing.analytics.BusinessSubscriptionTransitionRecorder;
import com.ning.billing.analytics.api.AnalyticsService;
import com.ning.billing.analytics.api.DefaultAnalyticsService;
-import com.ning.billing.analytics.dao.BusinessAccountDao;
+import com.ning.billing.analytics.dao.BusinessAccountSqlDao;
import com.ning.billing.analytics.dao.BusinessAccountDaoProvider;
-import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionDao;
+import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionSqlDao;
import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionDaoProvider;
public class AnalyticsModule extends AbstractModule {
@Override
protected void configure() {
- bind(BusinessSubscriptionTransitionDao.class).toProvider(BusinessSubscriptionTransitionDaoProvider.class).asEagerSingleton();
- bind(BusinessAccountDao.class).toProvider(BusinessAccountDaoProvider.class).asEagerSingleton();
+ bind(BusinessSubscriptionTransitionSqlDao.class).toProvider(BusinessSubscriptionTransitionDaoProvider.class).asEagerSingleton();
+ bind(BusinessAccountSqlDao.class).toProvider(BusinessAccountDaoProvider.class).asEagerSingleton();
bind(BusinessSubscriptionTransitionRecorder.class).asEagerSingleton();
bind(BusinessAccountRecorder.class).asEagerSingleton();
diff --git a/analytics/src/test/java/com/ning/billing/analytics/api/TestAnalyticsService.java b/analytics/src/test/java/com/ning/billing/analytics/api/TestAnalyticsService.java
index 1b98b83..23209b9 100644
--- a/analytics/src/test/java/com/ning/billing/analytics/api/TestAnalyticsService.java
+++ b/analytics/src/test/java/com/ning/billing/analytics/api/TestAnalyticsService.java
@@ -37,6 +37,7 @@ import com.ning.billing.account.api.AccountCreationEvent;
import com.ning.billing.account.api.AccountUserApi;
import com.ning.billing.account.api.user.DefaultAccountCreationEvent;
import com.ning.billing.analytics.AnalyticsTestModule;
+import com.ning.billing.analytics.dao.BusinessAccountSqlDao;
import com.ning.billing.analytics.model.BusinessSubscription;
import com.ning.billing.analytics.model.BusinessSubscriptionEvent;
import com.ning.billing.analytics.model.BusinessSubscriptionTransition;
@@ -46,8 +47,7 @@ import com.ning.billing.analytics.MockPhase;
import com.ning.billing.analytics.MockPlan;
import com.ning.billing.analytics.MockProduct;
import com.ning.billing.analytics.TestWithEmbeddedDB;
-import com.ning.billing.analytics.dao.BusinessAccountDao;
-import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionDao;
+import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionSqlDao;
import com.ning.billing.catalog.MockPriceList;
import com.ning.billing.catalog.api.Catalog;
import com.ning.billing.catalog.api.CatalogApiException;
@@ -122,10 +122,10 @@ public class TestAnalyticsService extends TestWithEmbeddedDB {
private Bus bus;
@Inject
- private BusinessSubscriptionTransitionDao subscriptionDao;
+ private BusinessSubscriptionTransitionSqlDao subscriptionSqlDao;
@Inject
- private BusinessAccountDao accountDao;
+ private BusinessAccountSqlDao accountSqlDao;
private SubscriptionEvent transition;
private BusinessSubscriptionTransition expectedTransition;
@@ -261,23 +261,23 @@ public class TestAnalyticsService extends TestWithEmbeddedDB {
Assert.fail("Unable to start the bus or service! " + t);
}
- Assert.assertNull(accountDao.getAccount(ACCOUNT_KEY));
+ Assert.assertNull(accountSqlDao.getAccount(ACCOUNT_KEY));
// Send events and wait for the async part...
bus.post(transition);
bus.post(accountCreationNotification);
Thread.sleep(5000);
- Assert.assertEquals(subscriptionDao.getTransitions(EXTERNAL_KEY).size(), 1);
- Assert.assertEquals(subscriptionDao.getTransitions(EXTERNAL_KEY).get(0), expectedTransition);
+ Assert.assertEquals(subscriptionSqlDao.getTransitions(EXTERNAL_KEY).size(), 1);
+ Assert.assertEquals(subscriptionSqlDao.getTransitions(EXTERNAL_KEY).get(0), expectedTransition);
// Test invoice integration - the account creation notification has triggered a BAC update
- Assert.assertTrue(accountDao.getAccount(ACCOUNT_KEY).getTotalInvoiceBalance().compareTo(INVOICE_AMOUNT) == 0);
+ Assert.assertTrue(accountSqlDao.getAccount(ACCOUNT_KEY).getTotalInvoiceBalance().compareTo(INVOICE_AMOUNT) == 0);
// Post the same invoice event again - the invoice balance shouldn't change
bus.post(invoiceCreationNotification);
Thread.sleep(5000);
- Assert.assertTrue(accountDao.getAccount(ACCOUNT_KEY).getTotalInvoiceBalance().compareTo(INVOICE_AMOUNT) == 0);
+ Assert.assertTrue(accountSqlDao.getAccount(ACCOUNT_KEY).getTotalInvoiceBalance().compareTo(INVOICE_AMOUNT) == 0);
// Test payment integration - the fields have already been populated, just make sure the code is exercised
bus.post(paymentInfoNotification);
diff --git a/analytics/src/test/java/com/ning/billing/analytics/dao/TestAnalyticsDao.java b/analytics/src/test/java/com/ning/billing/analytics/dao/TestAnalyticsDao.java
index 1ccbc00..5d6b3a6 100644
--- a/analytics/src/test/java/com/ning/billing/analytics/dao/TestAnalyticsDao.java
+++ b/analytics/src/test/java/com/ning/billing/analytics/dao/TestAnalyticsDao.java
@@ -60,9 +60,9 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
private final Plan plan = new MockPlan("platinum-monthly", product);
private final PlanPhase phase = new MockPhase(PhaseType.EVERGREEN, plan, MockDuration.UNLIMITED(), 25.95);
- private BusinessSubscriptionTransitionDao businessSubscriptionTransitionDao;
+ private BusinessSubscriptionTransitionSqlDao businessSubscriptionTransitionSqlDao;
private BusinessSubscriptionTransition transition;
- private BusinessAccountDao businessAccountDao;
+ private BusinessAccountSqlDao businessAccountSqlDao;
private BusinessAccount account;
private final CatalogService catalogService = Mockito.mock(CatalogService.class);
@@ -88,11 +88,11 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
transition = new BusinessSubscriptionTransition(TOTAL_ORDERING, EXTERNAL_KEY, ACCOUNT_KEY, requestedTimestamp, event, prevSubscription, nextSubscription);
final IDBI dbi = helper.getDBI();
- businessSubscriptionTransitionDao = dbi.onDemand(BusinessSubscriptionTransitionDao.class);
+ businessSubscriptionTransitionSqlDao = dbi.onDemand(BusinessSubscriptionTransitionSqlDao.class);
// Healthcheck test to make sure MySQL is setup properly
try {
- businessSubscriptionTransitionDao.test();
+ businessSubscriptionTransitionSqlDao.test();
} catch (Throwable t) {
Assert.fail(t.toString());
}
@@ -102,11 +102,11 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
account = new BusinessAccount(ACCOUNT_KEY, UUID.randomUUID().toString(), BigDecimal.ONE, new DateTime(DateTimeZone.UTC), BigDecimal.TEN, "ERROR_NOT_ENOUGH_FUNDS", "CreditCard", "Visa", "FRANCE");
final IDBI dbi = helper.getDBI();
- businessAccountDao = dbi.onDemand(BusinessAccountDao.class);
+ businessAccountSqlDao = dbi.onDemand(BusinessAccountSqlDao.class);
// Healthcheck test to make sure MySQL is setup properly
try {
- businessAccountDao.test();
+ businessAccountSqlDao.test();
} catch (Throwable t) {
Assert.fail(t.toString());
}
@@ -124,13 +124,13 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
transition.getNextSubscription()
);
- businessSubscriptionTransitionDao.createTransition(transitionWithNullPrev);
- List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ businessSubscriptionTransitionSqlDao.createTransition(transitionWithNullPrev);
+ List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
Assert.assertEquals(transitions.get(0), transitionWithNullPrev);
// Try to add the same transition, with the same UUID - we should only store one though
- businessSubscriptionTransitionDao.createTransition(transitionWithNullPrev);
- transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ businessSubscriptionTransitionSqlDao.createTransition(transitionWithNullPrev);
+ transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
Assert.assertEquals(transitions.get(0), transitionWithNullPrev);
@@ -144,8 +144,8 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
null,
transition.getNextSubscription()
);
- businessSubscriptionTransitionDao.createTransition(secondTransitionWithNullPrev);
- transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ businessSubscriptionTransitionSqlDao.createTransition(secondTransitionWithNullPrev);
+ transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 2);
Assert.assertTrue(transitions.contains(transitionWithNullPrev));
Assert.assertTrue(transitions.contains(secondTransitionWithNullPrev));
@@ -162,9 +162,9 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
null,
transition.getNextSubscription()
);
- businessSubscriptionTransitionDao.createTransition(transitionWithNullPrev);
+ businessSubscriptionTransitionSqlDao.createTransition(transitionWithNullPrev);
- final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
Assert.assertEquals(transitions.get(0), transitionWithNullPrev);
}
@@ -180,9 +180,9 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
transition.getPreviousSubscription(),
null
);
- businessSubscriptionTransitionDao.createTransition(transitionWithNullNext);
+ businessSubscriptionTransitionSqlDao.createTransition(transitionWithNullNext);
- final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
Assert.assertEquals(transitions.get(0), transitionWithNullNext);
}
@@ -199,9 +199,9 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
subscriptionWithNullFields,
subscriptionWithNullFields
);
- businessSubscriptionTransitionDao.createTransition(transitionWithNullFields);
+ businessSubscriptionTransitionSqlDao.createTransition(transitionWithNullFields);
- final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
Assert.assertEquals(transitions.get(0), transitionWithNullFields);
}
@@ -218,9 +218,9 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
subscriptionWithNullPlanAndPhase,
subscriptionWithNullPlanAndPhase
);
- businessSubscriptionTransitionDao.createTransition(transitionWithNullPlanAndPhase);
+ businessSubscriptionTransitionSqlDao.createTransition(transitionWithNullPlanAndPhase);
- final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
Assert.assertEquals(transitions.get(0).getExternalKey(), transition.getExternalKey());
Assert.assertEquals(transitions.get(0).getRequestedTimestamp(), transition.getRequestedTimestamp());
@@ -241,9 +241,9 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
subscriptionWithNullPlan,
subscriptionWithNullPlan
);
- businessSubscriptionTransitionDao.createTransition(transitionWithNullPlan);
+ businessSubscriptionTransitionSqlDao.createTransition(transitionWithNullPlan);
- final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
// Null Plan but Phase - we don't turn the subscription into a null
Assert.assertEquals(transitions.get(0), transitionWithNullPlan);
@@ -261,9 +261,9 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
subscriptionWithNullPhase,
subscriptionWithNullPhase
);
- businessSubscriptionTransitionDao.createTransition(transitionWithNullPhase);
+ businessSubscriptionTransitionSqlDao.createTransition(transitionWithNullPhase);
- final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
Assert.assertEquals(transitions.get(0).getExternalKey(), transition.getExternalKey());
Assert.assertEquals(transitions.get(0).getRequestedTimestamp(), transition.getRequestedTimestamp());
@@ -277,20 +277,20 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
@Test(groups = "slow")
public void testCreateAndRetrieveTransitions() {
- businessSubscriptionTransitionDao.createTransition(transition);
+ businessSubscriptionTransitionSqlDao.createTransition(transition);
- final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionDao.getTransitions(EXTERNAL_KEY);
+ final List<BusinessSubscriptionTransition> transitions = businessSubscriptionTransitionSqlDao.getTransitions(EXTERNAL_KEY);
Assert.assertEquals(transitions.size(), 1);
Assert.assertEquals(transitions.get(0), transition);
- Assert.assertEquals(businessSubscriptionTransitionDao.getTransitions("Doesn't exist").size(), 0);
+ Assert.assertEquals(businessSubscriptionTransitionSqlDao.getTransitions("Doesn't exist").size(), 0);
}
@Test(groups = "slow")
public void testCreateSaveAndRetrieveAccounts() {
// Create and retrieve an account
- businessAccountDao.createAccount(account);
- final BusinessAccount foundAccount = businessAccountDao.getAccount(ACCOUNT_KEY);
+ businessAccountSqlDao.createAccount(account);
+ final BusinessAccount foundAccount = businessAccountSqlDao.getAccount(ACCOUNT_KEY);
Assert.assertNotNull(foundAccount.getCreatedDt());
Assert.assertEquals(foundAccount.getCreatedDt(), foundAccount.getUpdatedDt());
// Verify the dates by backfilling them
@@ -302,14 +302,14 @@ public class TestAnalyticsDao extends TestWithEmbeddedDB {
final DateTime previousUpdatedDt = account.getUpdatedDt();
account.setBalance(BigDecimal.TEN);
account.setPaymentMethod("PayPal");
- businessAccountDao.saveAccount(account);
+ businessAccountSqlDao.saveAccount(account);
// Verify the save worked as expected
- account = businessAccountDao.getAccount(ACCOUNT_KEY);
+ account = businessAccountSqlDao.getAccount(ACCOUNT_KEY);
Assert.assertEquals(Rounder.round(BigDecimal.TEN), account.getRoundedBalance());
Assert.assertEquals("PayPal", account.getPaymentMethod());
Assert.assertTrue(account.getUpdatedDt().compareTo(previousUpdatedDt) > 0);
// ACCOUNT not found
- Assert.assertNull(businessAccountDao.getAccount("Doesn't exist"));
+ Assert.assertNull(businessAccountSqlDao.getAccount("Doesn't exist"));
}
}
diff --git a/analytics/src/test/java/com/ning/billing/analytics/TestAnalyticsListener.java b/analytics/src/test/java/com/ning/billing/analytics/TestAnalyticsListener.java
index 4dc8eeb..2d29f08 100644
--- a/analytics/src/test/java/com/ning/billing/analytics/TestAnalyticsListener.java
+++ b/analytics/src/test/java/com/ning/billing/analytics/TestAnalyticsListener.java
@@ -51,7 +51,7 @@ public class TestAnalyticsListener extends AnalyticsTestSuite {
private static final String ACCOUNT_KEY = "pierre-1234";
private final Currency CURRENCY = Currency.BRL;
- private final MockBusinessSubscriptionTransitionDao dao = new MockBusinessSubscriptionTransitionDao();
+ private final MockBusinessSubscriptionTransitionSqlDao dao = new MockBusinessSubscriptionTransitionSqlDao();
private final UUID subscriptionId = UUID.randomUUID();
private final UUID bundleUUID = UUID.randomUUID();
private final Product product = new MockProduct("platinium", "subscription", ProductCategory.BASE);
diff --git a/analytics/src/test/java/com/ning/billing/analytics/TestBusinessSubscriptionTransitionRecorder.java b/analytics/src/test/java/com/ning/billing/analytics/TestBusinessSubscriptionTransitionRecorder.java
index 0896ae7..531ab7b 100644
--- a/analytics/src/test/java/com/ning/billing/analytics/TestBusinessSubscriptionTransitionRecorder.java
+++ b/analytics/src/test/java/com/ning/billing/analytics/TestBusinessSubscriptionTransitionRecorder.java
@@ -26,7 +26,7 @@ import org.testng.annotations.Test;
import com.ning.billing.account.api.Account;
import com.ning.billing.account.api.AccountUserApi;
-import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionDao;
+import com.ning.billing.analytics.dao.BusinessSubscriptionTransitionSqlDao;
import com.ning.billing.analytics.model.BusinessSubscription;
import com.ning.billing.analytics.model.BusinessSubscriptionEvent;
import com.ning.billing.analytics.model.BusinessSubscriptionTransition;
@@ -48,7 +48,7 @@ public class TestBusinessSubscriptionTransitionRecorder extends AnalyticsTestSui
Mockito.when(catalogService.getFullCatalog()).thenReturn(Mockito.mock(Catalog.class));
// Setup the dao
- final BusinessSubscriptionTransitionDao dao = new MockBusinessSubscriptionTransitionDao();
+ final BusinessSubscriptionTransitionSqlDao sqlDao = new MockBusinessSubscriptionTransitionSqlDao();
// Add a previous subscription to make sure it doesn't impact the addon
final BusinessSubscription nextPrevSubscription = new BusinessSubscription(UUID.randomUUID().toString(),
UUID.randomUUID().toString(),
@@ -59,7 +59,7 @@ public class TestBusinessSubscriptionTransitionRecorder extends AnalyticsTestSui
UUID.randomUUID(),
UUID.randomUUID(),
catalogService.getFullCatalog());
- dao.createTransition(new BusinessSubscriptionTransition(10L,
+ sqlDao.createTransition(new BusinessSubscriptionTransition(10L,
externalKey.toString(),
UUID.randomUUID().toString(),
new DateTime(DateTimeZone.UTC),
@@ -79,7 +79,7 @@ public class TestBusinessSubscriptionTransitionRecorder extends AnalyticsTestSui
final AccountUserApi accountApi = Mockito.mock(AccountUserApi.class);
Mockito.when(accountApi.getAccountById(bundle.getAccountId())).thenReturn(account);
- final BusinessSubscriptionTransitionRecorder recorder = new BusinessSubscriptionTransitionRecorder(dao, catalogService, entitlementApi, accountApi);
+ final BusinessSubscriptionTransitionRecorder recorder = new BusinessSubscriptionTransitionRecorder(sqlDao, catalogService, entitlementApi, accountApi);
// Create an new subscription event
final SubscriptionEvent event = Mockito.mock(SubscriptionEvent.class);
@@ -90,8 +90,8 @@ public class TestBusinessSubscriptionTransitionRecorder extends AnalyticsTestSui
Mockito.when(event.getSubscriptionStartDate()).thenReturn(new DateTime(DateTimeZone.UTC));
recorder.subscriptionCreated(event);
- Assert.assertEquals(dao.getTransitions(externalKey.toString()).size(), 2);
- final BusinessSubscriptionTransition transition = dao.getTransitions(externalKey.toString()).get(1);
+ Assert.assertEquals(sqlDao.getTransitions(externalKey.toString()).size(), 2);
+ final BusinessSubscriptionTransition transition = sqlDao.getTransitions(externalKey.toString()).get(1);
Assert.assertEquals(transition.getTotalOrdering(), (long) event.getTotalOrdering());
Assert.assertEquals(transition.getAccountKey(), externalKey.toString());
// Make sure all the prev_ columns are null