Details
diff --git a/entitlement/src/main/java/com/ning/billing/entitlement/api/billing/DefaultChargeThruApi.java b/entitlement/src/main/java/com/ning/billing/entitlement/api/billing/DefaultChargeThruApi.java
index 145a06e..13b1a16 100644
--- a/entitlement/src/main/java/com/ning/billing/entitlement/api/billing/DefaultChargeThruApi.java
+++ b/entitlement/src/main/java/com/ning/billing/entitlement/api/billing/DefaultChargeThruApi.java
@@ -54,7 +54,7 @@ public class DefaultChargeThruApi implements ChargeThruApi {
@Override
public void setChargedThroughDate(final UUID subscriptionId, final LocalDate ctd, final CallContext context) {
- final SubscriptionData subscription = (SubscriptionData) entitlementDao.getSubscriptionFromId(subscriptionFactory, subscriptionId, internalCallContextFactory.createInternalCallContext(context));
+ final SubscriptionData subscription = (SubscriptionData) entitlementDao.getSubscriptionFromId(subscriptionFactory, subscriptionId, internalCallContextFactory.createInternalTenantContext(context));
final DateTime chargedThroughDate = ctd.toDateTime(new LocalTime(subscription.getStartDate(), DateTimeZone.UTC), DateTimeZone.UTC);
final SubscriptionBuilder builder = new SubscriptionBuilder(subscription)
.setChargedThroughDate(chargedThroughDate)
diff --git a/invoice/src/main/java/com/ning/billing/invoice/api/invoice/DefaultInvoicePaymentApi.java b/invoice/src/main/java/com/ning/billing/invoice/api/invoice/DefaultInvoicePaymentApi.java
index 2414a36..88b2425 100644
--- a/invoice/src/main/java/com/ning/billing/invoice/api/invoice/DefaultInvoicePaymentApi.java
+++ b/invoice/src/main/java/com/ning/billing/invoice/api/invoice/DefaultInvoicePaymentApi.java
@@ -35,7 +35,6 @@ import com.ning.billing.invoice.api.InvoicePaymentApi;
import com.ning.billing.invoice.dao.InvoiceDao;
import com.ning.billing.invoice.model.DefaultInvoicePayment;
import com.ning.billing.util.callcontext.CallContext;
-import com.ning.billing.util.callcontext.InternalCallContext;
import com.ning.billing.util.callcontext.InternalCallContextFactory;
import com.ning.billing.util.callcontext.InternalTenantContext;
import com.ning.billing.util.callcontext.TenantContext;
@@ -107,7 +106,7 @@ public class DefaultInvoicePaymentApi implements InvoicePaymentApi {
final InvoicePayment invoicePayment = new DefaultInvoicePayment(InvoicePaymentType.ATTEMPT, paymentId, invoiceId, paymentDate, amount, currency);
// Retrieve the account id for the internal call context
- final Invoice invoice = dao.getById(invoiceId, internalCallContextFactory.createInternalCallContext(context));
+ final Invoice invoice = dao.getById(invoiceId, internalCallContextFactory.createInternalTenantContext(context));
final UUID accountId = invoice.getAccountId();
dao.notifyOfPayment(invoicePayment, internalCallContextFactory.createInternalCallContext(accountId, context));
@@ -152,7 +151,7 @@ public class DefaultInvoicePaymentApi implements InvoicePaymentApi {
}
// Retrieve the account id for the internal call context
- final InternalCallContext internalCallContextNoAccountId = internalCallContextFactory.createInternalCallContext(context);
+ final InternalTenantContext internalCallContextNoAccountId = internalCallContextFactory.createInternalTenantContext(context);
final List<InvoicePayment> invoicePayments = dao.getInvoicePayments(paymentId, internalCallContextNoAccountId);
final UUID accountId = dao.getAccountIdFromInvoicePaymentId(invoicePayments.get(0).getId(), internalCallContextNoAccountId);
@@ -173,7 +172,7 @@ public class DefaultInvoicePaymentApi implements InvoicePaymentApi {
@Override
public InvoicePayment doHandle() throws InvoiceApiException {
// Retrieve the account id for the internal call context
- final UUID accountId = dao.getAccountIdFromInvoicePaymentId(invoicePaymentId, internalCallContextFactory.createInternalCallContext(context));
+ final UUID accountId = dao.getAccountIdFromInvoicePaymentId(invoicePaymentId, internalCallContextFactory.createInternalTenantContext(context));
return dao.postChargeback(invoicePaymentId, amount, internalCallContextFactory.createInternalCallContext(accountId, context));
}
});
diff --git a/invoice/src/main/java/com/ning/billing/invoice/api/user/DefaultInvoiceUserApi.java b/invoice/src/main/java/com/ning/billing/invoice/api/user/DefaultInvoiceUserApi.java
index eba5843..e63066d 100644
--- a/invoice/src/main/java/com/ning/billing/invoice/api/user/DefaultInvoiceUserApi.java
+++ b/invoice/src/main/java/com/ning/billing/invoice/api/user/DefaultInvoiceUserApi.java
@@ -95,7 +95,7 @@ public class DefaultInvoiceUserApi implements InvoiceUserApi {
@Override
public void notifyOfPayment(final InvoicePayment invoicePayment, final CallContext context) throws InvoiceApiException {
// Retrieve the account id for the internal call context
- final UUID accountId = dao.getAccountIdFromInvoicePaymentId(invoicePayment.getId(), internalCallContextFactory.createInternalCallContext(context));
+ final UUID accountId = dao.getAccountIdFromInvoicePaymentId(invoicePayment.getId(), internalCallContextFactory.createInternalTenantContext(context));
dao.notifyOfPayment(invoicePayment, internalCallContextFactory.createInternalCallContext(accountId, context));
}
@@ -151,7 +151,7 @@ public class DefaultInvoiceUserApi implements InvoiceUserApi {
tagUserApi.addTag(invoiceId, ObjectType.INVOICE, ControlTagType.WRITTEN_OFF.getId(), context);
// Retrieve the invoice for the account id
- final Invoice invoice = dao.getById(invoiceId, internalCallContextFactory.createInternalCallContext(context));
+ final Invoice invoice = dao.getById(invoiceId, internalCallContextFactory.createInternalTenantContext(context));
// This is for overdue
notifyBusOfInvoiceAdjustment(invoiceId, invoice.getAccountId(), context.getUserToken());
}
@@ -162,7 +162,7 @@ public class DefaultInvoiceUserApi implements InvoiceUserApi {
tagUserApi.removeTag(invoiceId, ObjectType.INVOICE, ControlTagType.WRITTEN_OFF.getId(), context);
// Retrieve the invoice for the account id
- final Invoice invoice = dao.getById(invoiceId, internalCallContextFactory.createInternalCallContext(context));
+ final Invoice invoice = dao.getById(invoiceId, internalCallContextFactory.createInternalTenantContext(context));
// This is for overdue
notifyBusOfInvoiceAdjustment(invoiceId, invoice.getAccountId(), context.getUserToken());
}
diff --git a/invoice/src/test/java/com/ning/billing/invoice/tests/InvoiceTestUtils.java b/invoice/src/test/java/com/ning/billing/invoice/tests/InvoiceTestUtils.java
index 0bace86..d572117 100644
--- a/invoice/src/test/java/com/ning/billing/invoice/tests/InvoiceTestUtils.java
+++ b/invoice/src/test/java/com/ning/billing/invoice/tests/InvoiceTestUtils.java
@@ -75,12 +75,12 @@ public class InvoiceTestUtils {
final List<InvoiceItem> invoiceItems = new ArrayList<InvoiceItem>();
for (final BigDecimal amount : amounts) {
final InvoiceItem invoiceItem = createInvoiceItem(clock, invoiceId, accountId, amount, currency);
- invoiceItemSqlDao.create(invoiceItem, internalCallContextFactory.createInternalCallContext(callContext));
+ invoiceItemSqlDao.create(invoiceItem, internalCallContextFactory.createInternalCallContext(accountId, callContext));
invoiceItems.add(invoiceItem);
}
Mockito.when(invoice.getInvoiceItems()).thenReturn(invoiceItems);
- invoiceSqlDao.create(invoice, internalCallContextFactory.createInternalCallContext(callContext));
+ invoiceSqlDao.create(invoice, internalCallContextFactory.createInternalCallContext(accountId, callContext));
return invoice;
}
diff --git a/util/src/main/java/com/ning/billing/util/callcontext/InternalCallContextFactory.java b/util/src/main/java/com/ning/billing/util/callcontext/InternalCallContextFactory.java
index b19bea7..fac8975 100644
--- a/util/src/main/java/com/ning/billing/util/callcontext/InternalCallContextFactory.java
+++ b/util/src/main/java/com/ning/billing/util/callcontext/InternalCallContextFactory.java
@@ -56,7 +56,7 @@ public class InternalCallContextFactory {
return createInternalTenantContext(INTERNAL_TENANT_RECORD_ID, null);
}
- // Used for r/o or update/delete operations - we don't need the account id in that case
+ // Used for r/o operations - we don't need the account id in that case
public InternalTenantContext createInternalTenantContext(final TenantContext context) {
return createInternalTenantContext(getTenantRecordId(context), null);
}
@@ -114,7 +114,7 @@ public class InternalCallContextFactory {
return createInternalCallContext(getTenantRecordId(context), accountRecordId, context);
}
- // Used for r/o or update/delete operations - we don't need the account id in that case
+ // Used for update/delete operations - we don't need the account id in that case
// Used also when we don't have an account_record_id column (e.g. tenants, tag_definitions)
public InternalCallContext createInternalCallContext(final CallContext context) {
return createInternalCallContext(getTenantRecordId(context), null, context);