killbill-memoizeit
Changes
invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java 9(+3 -6)
invoice/src/test/java/org/killbill/billing/invoice/template/formatters/TestDefaultInvoiceFormatter.java 18(+9 -9)
pom.xml 2(+1 -1)
Details
diff --git a/invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java b/invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java
index 337a9b5..44f2a30 100644
--- a/invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java
+++ b/invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java
@@ -26,7 +26,6 @@ import java.util.Collection;
import java.util.Iterator;
import java.util.List;
import java.util.Locale;
-import java.util.Map;
import java.util.UUID;
import org.joda.money.CurrencyUnit;
@@ -72,11 +71,10 @@ public class DefaultInvoiceFormatter implements InvoiceFormatter {
private final CurrencyConversionApi currencyConversionApi;
private final InternalTenantContext context;
private final ResourceBundleFactory bundleFactory;
- private final Map<java.util.Currency, Locale> currencyLocaleMap;
public DefaultInvoiceFormatter(final TranslatorConfig config, final Invoice invoice, final Locale locale,
final CurrencyConversionApi currencyConversionApi, final ResourceBundleFactory bundleFactory,
- final InternalTenantContext context, final Map<java.util.Currency, Locale> currencyLocaleMap) {
+ final InternalTenantContext context) {
this.config = config;
this.invoice = invoice;
this.dateFormatter = DateTimeFormat.mediumDate().withLocale(locale);
@@ -84,7 +82,6 @@ public class DefaultInvoiceFormatter implements InvoiceFormatter {
this.currencyConversionApi = currencyConversionApi;
this.bundleFactory = bundleFactory;
this.context = context;
- this.currencyLocaleMap = currencyLocaleMap;
}
@Override
@@ -240,8 +237,8 @@ public class DefaultInvoiceFormatter implements InvoiceFormatter {
dfs.setInternationalCurrencySymbol(currencyUnit.getCurrencyCode());
try {
- final java.util.Currency currency = java.util.Currency.getInstance(invoiceCurrencyCode);
- dfs.setCurrencySymbol(currency.getSymbol(currencyLocaleMap.get(currency)));
+ Currency currency = Currency.fromCode(invoiceCurrencyCode);
+ dfs.setCurrencySymbol(currency.getSymbol());
} catch (final IllegalArgumentException e) {
dfs.setCurrencySymbol(currencyUnit.getSymbol(locale));
}
diff --git a/invoice/src/test/java/org/killbill/billing/invoice/template/formatters/TestDefaultInvoiceFormatter.java b/invoice/src/test/java/org/killbill/billing/invoice/template/formatters/TestDefaultInvoiceFormatter.java
index 3fa01dd..df82930 100644
--- a/invoice/src/test/java/org/killbill/billing/invoice/template/formatters/TestDefaultInvoiceFormatter.java
+++ b/invoice/src/test/java/org/killbill/billing/invoice/template/formatters/TestDefaultInvoiceFormatter.java
@@ -202,13 +202,13 @@ public class TestDefaultInvoiceFormatter extends InvoiceTestSuiteNoDB {
" <td class=\"amount\"><strong>{{invoice.formattedBalance}}</strong></td>\n" +
"</tr>",
"<tr>\n" +
- " <td class=\"amount\"><strong>1 499,958 ر.ع.\u200F</strong></td>\n" +
+ " <td class=\"amount\"><strong>1 499,958 ر.ع</strong></td>\n" +
"</tr>\n" +
"<tr>\n" +
- " <td class=\"amount\"><strong>0,000 ر.ع.\u200F</strong></td>\n" +
+ " <td class=\"amount\"><strong>0,000 ر.ع</strong></td>\n" +
"</tr>\n" +
"<tr>\n" +
- " <td class=\"amount\"><strong>1 499,958 ر.ع.\u200F</strong></td>\n" +
+ " <td class=\"amount\"><strong>1 499,958 ر.ع</strong></td>\n" +
"</tr>",
Locale.FRANCE);
}
@@ -232,13 +232,13 @@ public class TestDefaultInvoiceFormatter extends InvoiceTestSuiteNoDB {
" <td class=\"amount\"><strong>{{invoice.formattedBalance}}</strong></td>\n" +
"</tr>",
"<tr>\n" +
- " <td class=\"amount\"><strong>1 500 ¥</strong></td>\n" +
+ " <td class=\"amount\"><strong>1 500 ¥</strong></td>\n" +
"</tr>\n" +
"<tr>\n" +
- " <td class=\"amount\"><strong>0 ¥</strong></td>\n" +
+ " <td class=\"amount\"><strong>0 ¥</strong></td>\n" +
"</tr>\n" +
"<tr>\n" +
- " <td class=\"amount\"><strong>1 500 ¥</strong></td>\n" +
+ " <td class=\"amount\"><strong>1 500 ¥</strong></td>\n" +
"</tr>",
Locale.FRANCE);
}
@@ -262,13 +262,13 @@ public class TestDefaultInvoiceFormatter extends InvoiceTestSuiteNoDB {
" <td class=\"amount\"><strong>{{invoice.formattedBalance}}</strong></td>\n" +
"</tr>",
"<tr>\n" +
- " <td class=\"amount\"><strong>BTC1,105.28843439</strong></td>\n" +
+ " <td class=\"amount\"><strong>Ƀ1,105.28843439</strong></td>\n" +
"</tr>\n" +
"<tr>\n" +
- " <td class=\"amount\"><strong>BTC0.00000000</strong></td>\n" +
+ " <td class=\"amount\"><strong>Ƀ0.00000000</strong></td>\n" +
"</tr>\n" +
"<tr>\n" +
- " <td class=\"amount\"><strong>BTC1,105.28843439</strong></td>\n" +
+ " <td class=\"amount\"><strong>Ƀ1,105.28843439</strong></td>\n" +
"</tr>",
Locale.US);
}
pom.xml 2(+1 -1)
diff --git a/pom.xml b/pom.xml
index 77300c1..4abb7b2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -21,7 +21,7 @@
<parent>
<artifactId>killbill-oss-parent</artifactId>
<groupId>org.kill-bill.billing</groupId>
- <version>0.129</version>
+ <version>0.130-SNAPSHOT</version>
</parent>
<artifactId>killbill</artifactId>
<version>0.17.5-SNAPSHOT</version>