Details
diff --git a/api/src/main/java/org/killbill/billing/callcontext/TimeAwareContext.java b/api/src/main/java/org/killbill/billing/callcontext/TimeAwareContext.java
index 78d0008..cc040b8 100644
--- a/api/src/main/java/org/killbill/billing/callcontext/TimeAwareContext.java
+++ b/api/src/main/java/org/killbill/billing/callcontext/TimeAwareContext.java
@@ -36,11 +36,6 @@ public class TimeAwareContext {
/// Generic functions
/// TODO Move to ClockUtil
- // From JDK to Joda (see http://www.joda.org/joda-time/userguide.html#JDK_Interoperability)
- public DateTime toUTCDateTime(final Date date) {
- return toUTCDateTime(new DateTime(date));
- }
-
// Create a DateTime object forcing the time zone to be UTC
protected DateTime toUTCDateTime(final DateTime dateTime) {
return toDateTime(dateTime, DateTimeZone.UTC);
diff --git a/catalog/src/main/java/org/killbill/billing/catalog/CatalogDateHelper.java b/catalog/src/main/java/org/killbill/billing/catalog/CatalogDateHelper.java
new file mode 100644
index 0000000..0eb59ff
--- /dev/null
+++ b/catalog/src/main/java/org/killbill/billing/catalog/CatalogDateHelper.java
@@ -0,0 +1,31 @@
+/*
+ * Copyright 2016 Groupon, Inc
+ * Copyright 2016 The Billing Project, LLC
+ *
+ * The Billing Project licenses this file to you under the Apache License, version 2.0
+ * (the "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.killbill.billing.catalog;
+
+import java.util.Date;
+
+import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;
+
+public abstract class CatalogDateHelper {
+
+ // From JDK to Joda (see http://www.joda.org/joda-time/userguide.html#JDK_Interoperability)
+ public static DateTime toUTCDateTime(final Date date) {
+ return new DateTime(date).toDateTime(DateTimeZone.UTC);
+ }
+}
diff --git a/catalog/src/main/java/org/killbill/billing/catalog/StandaloneCatalogWithPriceOverride.java b/catalog/src/main/java/org/killbill/billing/catalog/StandaloneCatalogWithPriceOverride.java
index 5fcece4..d80bbd4 100644
--- a/catalog/src/main/java/org/killbill/billing/catalog/StandaloneCatalogWithPriceOverride.java
+++ b/catalog/src/main/java/org/killbill/billing/catalog/StandaloneCatalogWithPriceOverride.java
@@ -140,7 +140,7 @@ public class StandaloneCatalogWithPriceOverride extends ValidatingConfig<Standal
}
final InternalCallContext internalCallContext = internalCallContextFactory.createInternalCallContext(overrides.getCallContext());
- return priceOverride.getOrCreateOverriddenPlan(defaultPlan, internalCallContext.toUTCDateTime(getEffectiveDate()), overrides.getOverrides(), internalCallContext);
+ return priceOverride.getOrCreateOverriddenPlan(defaultPlan, CatalogDateHelper.toUTCDateTime(getEffectiveDate()), overrides.getOverrides(), internalCallContext);
}
@Override
diff --git a/catalog/src/main/java/org/killbill/billing/catalog/VersionedCatalog.java b/catalog/src/main/java/org/killbill/billing/catalog/VersionedCatalog.java
index a47477d..b4a222a 100644
--- a/catalog/src/main/java/org/killbill/billing/catalog/VersionedCatalog.java
+++ b/catalog/src/main/java/org/killbill/billing/catalog/VersionedCatalog.java
@@ -65,7 +65,6 @@ import org.killbill.xmlloader.ValidationErrors;
public class VersionedCatalog extends ValidatingConfig<StandaloneCatalogWithPriceOverride> implements Catalog, StaticCatalog {
private final Clock clock;
- private final InternalTenantContext internalTenantContext;
@XmlElement(name = "catalogVersion", required = true)
private final List<StandaloneCatalogWithPriceOverride> versions;
private String catalogName;
@@ -75,13 +74,11 @@ public class VersionedCatalog extends ValidatingConfig<StandaloneCatalogWithPric
public VersionedCatalog() {
this.clock = null;
this.versions = new ArrayList<StandaloneCatalogWithPriceOverride>();
- this.internalTenantContext = new InternalTenantContext(null);
}
public VersionedCatalog(final Clock clock) {
this.clock = clock;
this.versions = new ArrayList<StandaloneCatalogWithPriceOverride>();
- this.internalTenantContext = new InternalTenantContext(null);
}
public VersionedCatalog(final Clock clock, final String catalogName, final BillingMode recurringBillingMode, final List<StandaloneCatalogWithPriceOverride> versions, final InternalTenantContext tenantContext) {
@@ -93,7 +90,6 @@ public class VersionedCatalog extends ValidatingConfig<StandaloneCatalogWithPric
final StandaloneCatalogWithPriceOverride catalogWithTenantInfo = new StandaloneCatalogWithPriceOverride(cur, tenantContext);
this.versions.add(catalogWithTenantInfo);
}
- this.internalTenantContext = tenantContext;
}
//
@@ -174,12 +170,12 @@ public class VersionedCatalog extends ValidatingConfig<StandaloneCatalogWithPric
}
}
- final DateTime catalogEffectiveDate = internalTenantContext.toUTCDateTime(c.getEffectiveDate());
+ final DateTime catalogEffectiveDate = CatalogDateHelper.toUTCDateTime(c.getEffectiveDate());
if (!subscriptionStartDate.isBefore(catalogEffectiveDate)) { // Its a new subscription this plan always applies
return plan;
} else { //Its an existing subscription
if (plan.getEffectiveDateForExistingSubscriptons() != null) { //if it is null any change to this does not apply to existing subscriptions
- final DateTime existingSubscriptionDate = internalTenantContext.toUTCDateTime(plan.getEffectiveDateForExistingSubscriptons());
+ final DateTime existingSubscriptionDate = CatalogDateHelper.toUTCDateTime(plan.getEffectiveDateForExistingSubscriptons());
if (requestedDate.isAfter(existingSubscriptionDate)) { // this plan is now applicable to existing subs
return plan;
}