Details
diff --git a/junction/src/main/java/com/ning/billing/junction/dao/BlockingStateSqlDao.java b/junction/src/main/java/com/ning/billing/junction/dao/BlockingStateSqlDao.java
index 0f45bfd..cb91383 100644
--- a/junction/src/main/java/com/ning/billing/junction/dao/BlockingStateSqlDao.java
+++ b/junction/src/main/java/com/ning/billing/junction/dao/BlockingStateSqlDao.java
@@ -56,7 +56,6 @@ public interface BlockingStateSqlDao extends EntitySqlDao<BlockingStateModelDao,
throws SQLException {
final UUID id;
- final DateTime timestamp;
final UUID blockableId;
final String stateName;
final String service;
@@ -64,12 +63,10 @@ public interface BlockingStateSqlDao extends EntitySqlDao<BlockingStateModelDao,
final boolean blockEntitlement;
final boolean blockBilling;
final Type type;
- DateTime createdDate;
- DateTime updatedDate;
+ final DateTime createdDate;
try {
id = UUID.fromString(r.getString("id"));
- timestamp = getDateTime(r, "created_date");
blockableId = UUID.fromString(r.getString("blockable_id"));
stateName = r.getString("state") == null ? DefaultBlockingState.CLEAR_STATE_NAME : r.getString("state");
type = Type.get(r.getString("type"));
diff --git a/junction/src/main/java/com/ning/billing/junction/dao/DefaultBlockingStateDao.java b/junction/src/main/java/com/ning/billing/junction/dao/DefaultBlockingStateDao.java
index ec1945e..1ea8e5a 100644
--- a/junction/src/main/java/com/ning/billing/junction/dao/DefaultBlockingStateDao.java
+++ b/junction/src/main/java/com/ning/billing/junction/dao/DefaultBlockingStateDao.java
@@ -24,8 +24,6 @@ import javax.annotation.Nullable;
import javax.inject.Inject;
import org.skife.jdbi.v2.IDBI;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import com.ning.billing.junction.api.Blockable;
import com.ning.billing.junction.api.BlockingState;
@@ -42,39 +40,31 @@ import com.google.common.collect.Collections2;
public class DefaultBlockingStateDao implements BlockingStateDao {
-
- private static final Logger log = LoggerFactory.getLogger(DefaultBlockingStateDao.class);
-
- private final Clock clock;
private final EntitySqlDaoTransactionalJdbiWrapper transactionalSqlDao;
@Inject
- public DefaultBlockingStateDao(final IDBI dbi, final Clock clock) {
- this.clock = clock;
+ public DefaultBlockingStateDao(final IDBI dbi) {
this.transactionalSqlDao = new EntitySqlDaoTransactionalJdbiWrapper(dbi);
}
-
@Override
public BlockingState getBlockingStateFor(final UUID blockableId, final InternalTenantContext context) {
return transactionalSqlDao.execute(new EntitySqlDaoTransactionWrapper<BlockingState>() {
@Override
public BlockingState inTransaction(final EntitySqlDaoWrapperFactory<EntitySqlDao> entitySqlDaoWrapperFactory) throws Exception {
- final BlockingStateModelDao model = entitySqlDaoWrapperFactory.become(BlockingStateSqlDao.class).getBlockingStateFor(blockableId, context);
+ final BlockingStateModelDao model = entitySqlDaoWrapperFactory.become(BlockingStateSqlDao.class).getBlockingStateFor(blockableId, context);
return BlockingStateModelDao.toBlockingState(model);
}
});
}
-
-
@Override
public List<BlockingState> getBlockingHistoryFor(final UUID blockableId, final InternalTenantContext context) {
return transactionalSqlDao.execute(new EntitySqlDaoTransactionWrapper<List<BlockingState>>() {
@Override
public List<BlockingState> inTransaction(final EntitySqlDaoWrapperFactory<EntitySqlDao> entitySqlDaoWrapperFactory) throws Exception {
- List<BlockingStateModelDao> models = entitySqlDaoWrapperFactory.become(BlockingStateSqlDao.class).getBlockingHistoryFor(blockableId, context);
+ final List<BlockingStateModelDao> models = entitySqlDaoWrapperFactory.become(BlockingStateSqlDao.class).getBlockingHistoryFor(blockableId, context);
return new ArrayList<BlockingState>(Collections2.transform(models, new Function<BlockingStateModelDao, BlockingState>() {
@Override
public BlockingState apply(@Nullable final BlockingStateModelDao src) {
diff --git a/junction/src/test/java/com/ning/billing/junction/api/blocking/TestDefaultBlockingApi.java b/junction/src/test/java/com/ning/billing/junction/api/blocking/TestDefaultBlockingApi.java
index 13f84ba..e763464 100644
--- a/junction/src/test/java/com/ning/billing/junction/api/blocking/TestDefaultBlockingApi.java
+++ b/junction/src/test/java/com/ning/billing/junction/api/blocking/TestDefaultBlockingApi.java
@@ -31,7 +31,6 @@ import com.ning.billing.junction.api.Blockable.Type;
import com.ning.billing.junction.api.svcs.DefaultInternalBlockingApi;
import com.ning.billing.junction.api.BlockingState;
import com.ning.billing.junction.dao.BlockingStateDao;
-import com.ning.billing.junction.dao.BlockingStateSqlDao;
import com.ning.billing.junction.dao.DefaultBlockingStateDao;
import com.ning.billing.util.clock.ClockMock;
import com.ning.billing.util.svcapi.junction.DefaultBlockingState;
@@ -44,7 +43,7 @@ public class TestDefaultBlockingApi extends JunctionTestSuiteWithEmbeddedDB {
@BeforeMethod(groups = "slow")
public void setUp() throws Exception {
- final BlockingStateDao blockingStateDao = new DefaultBlockingStateDao(getMysqlTestingHelper().getDBI(), clock);
+ final BlockingStateDao blockingStateDao = new DefaultBlockingStateDao(getMysqlTestingHelper().getDBI());
blockingApi = new DefaultInternalBlockingApi(blockingStateDao, clock);
}
diff --git a/util/src/main/java/com/ning/billing/util/callcontext/InternalCallContextFactory.java b/util/src/main/java/com/ning/billing/util/callcontext/InternalCallContextFactory.java
index afa2926..f72d061 100644
--- a/util/src/main/java/com/ning/billing/util/callcontext/InternalCallContextFactory.java
+++ b/util/src/main/java/com/ning/billing/util/callcontext/InternalCallContextFactory.java
@@ -283,6 +283,4 @@ public class InternalCallContextFactory {
}
return tenantRecordId;
}
-
-
}