killbill-memoizeit

payment: Fixes #374 Change behavior of janitor task IncompletePaymentTransactionTask

9/8/2015 9:52:43 PM

Details

diff --git a/payment/src/main/java/org/killbill/billing/payment/core/janitor/IncompletePaymentTransactionTask.java b/payment/src/main/java/org/killbill/billing/payment/core/janitor/IncompletePaymentTransactionTask.java
index 94d318b..8133904 100644
--- a/payment/src/main/java/org/killbill/billing/payment/core/janitor/IncompletePaymentTransactionTask.java
+++ b/payment/src/main/java/org/killbill/billing/payment/core/janitor/IncompletePaymentTransactionTask.java
@@ -186,12 +186,11 @@ public class IncompletePaymentTransactionTask extends CompletionTaskBase<Payment
                 newPaymentState = paymentStateMachineHelper.getFailureStateForTransaction(paymentTransaction.getTransactionType());
                 break;
             case PLUGIN_FAILURE:
+                newPaymentState = paymentStateMachineHelper.getErroredStateForTransaction(paymentTransaction.getTransactionType());
+                break;
             case UNKNOWN:
             default:
-                if (transactionStatus == paymentTransaction.getTransactionStatus()) {
-                    log.debug("Janitor IncompletePaymentTransactionTask unable to repair payment {}, transaction {}: {} -> {}",
-                              payment.getId(), paymentTransaction.getId(), paymentTransaction.getTransactionStatus(), transactionStatus);
-                } else {
+                if (transactionStatus != paymentTransaction.getTransactionStatus()) {
                     log.info("Janitor IncompletePaymentTransactionTask unable to repair payment {}, transaction {}: {} -> {}",
                              payment.getId(), paymentTransaction.getId(), paymentTransaction.getTransactionStatus(), transactionStatus);
                 }