killbill-memoizeit

payment: reduce Janitor logging Signed-off-by: Pierre-Alexandre

4/24/2015 10:44:24 AM

Details

diff --git a/payment/src/main/java/org/killbill/billing/payment/core/janitor/AttemptCompletionTask.java b/payment/src/main/java/org/killbill/billing/payment/core/janitor/AttemptCompletionTask.java
index 95fe5bc..542a883 100644
--- a/payment/src/main/java/org/killbill/billing/payment/core/janitor/AttemptCompletionTask.java
+++ b/payment/src/main/java/org/killbill/billing/payment/core/janitor/AttemptCompletionTask.java
@@ -63,7 +63,9 @@ final class AttemptCompletionTask extends CompletionTaskBase<PaymentAttemptModel
     @Override
     public List<PaymentAttemptModelDao> getItemsForIteration() {
         final List<PaymentAttemptModelDao> incompleteAttempts = paymentDao.getPaymentAttemptsByState(retrySMHelper.getInitialState().getName(), getCreatedDateBefore(), completionTaskCallContext);
-        log.info("Janitor AttemptCompletionTask start run : found " + incompleteAttempts.size() + " incomplete attempts");
+        if (!incompleteAttempts.isEmpty()) {
+            log.info("Janitor AttemptCompletionTask start run: found {} incomplete attempts", incompleteAttempts.size());
+        }
         return incompleteAttempts;
     }
 
diff --git a/payment/src/main/java/org/killbill/billing/payment/core/janitor/ErroredPaymentTask.java b/payment/src/main/java/org/killbill/billing/payment/core/janitor/ErroredPaymentTask.java
index 922e369..54d09f9 100644
--- a/payment/src/main/java/org/killbill/billing/payment/core/janitor/ErroredPaymentTask.java
+++ b/payment/src/main/java/org/killbill/billing/payment/core/janitor/ErroredPaymentTask.java
@@ -75,7 +75,9 @@ public class ErroredPaymentTask extends CompletionTaskBase<PaymentModelDao> {
         final DateTime createdAfterDate = clock.getUTCNow().minusDays(OLDER_PAYMENTS_IN_DAYS);
 
         final List<PaymentModelDao> result = paymentDao.getPaymentsByStates(paymentStateMachineHelper.getErroredStateNames(), createdBeforeDate, createdAfterDate, MAX_ITEMS_PER_LOOP, completionTaskCallContext);
-        log.info("Janitor ErroredPaymentTask start run : found {} errored/unknown payments", result.size());
+        if (!result.isEmpty()) {
+            log.info("Janitor ErroredPaymentTask start run: found {} errored/unknown payments", result.size());
+        }
         return result;
     }