killbill-memoizeit
Changes
entitlement/src/test/java/org/killbill/billing/entitlement/EntitlementTestSuiteWithEmbeddedDB.java 8(+1 -7)
subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteNoDB.java 1(+1 -0)
Details
diff --git a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationBase.java b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationBase.java
index 1b13cf2..6c98b7a 100644
--- a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationBase.java
+++ b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationBase.java
@@ -299,6 +299,7 @@ public class TestIntegrationBase extends BeatrixTestSuiteWithEmbeddedDB implemen
protected ConfigurableInvoiceConfig invoiceConfig;
+ @Override
protected void assertListenerStatus() {
busHandler.assertListenerStatus();
}
@@ -346,20 +347,6 @@ public class TestIntegrationBase extends BeatrixTestSuiteWithEmbeddedDB implemen
log.debug("DONE WITH TEST");
}
- // Note: assertions should not be run in before / after hooks, as the associated test result won't be correctly updated.
- // Use this wrapper instead.
- @Override
- public void run(final IHookCallBack callBack, final ITestResult testResult) {
- // Make sure we start with a clean state
- assertListenerStatus();
-
- // Run the actual test
- callBack.runTestMethod(testResult);
-
- // Make sure we finish in a clean state
- assertListenerStatus();
- }
-
protected void checkNoMoreInvoiceToGenerate(final Account account) {
busHandler.pushExpectedEvent(NextEvent.NULL_INVOICE);
try {
diff --git a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestPublicBus.java b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestPublicBus.java
index c603090..288c217 100644
--- a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestPublicBus.java
+++ b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestPublicBus.java
@@ -137,9 +137,6 @@ public class TestPublicBus extends TestIntegrationBase {
paymentPlugin.clear();
this.externalBusCount = new AtomicInteger(0);
-
- // Make sure we start with a clean state
- assertListenerStatus();
}
@AfterMethod(groups = "slow")
diff --git a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestWithFakeKPMPlugin.java b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestWithFakeKPMPlugin.java
index 851718e..60e3176 100644
--- a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestWithFakeKPMPlugin.java
+++ b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestWithFakeKPMPlugin.java
@@ -330,9 +330,6 @@ public class TestWithFakeKPMPlugin extends TestIntegrationBase {
externalBus.register(new FakeKPMPlugin());
lifecycle.fireStartupSequencePostEventRegistration();
-
- // Make sure we start with a clean state
- assertListenerStatus();
}
@Test(groups = "slow")
diff --git a/entitlement/src/test/java/org/killbill/billing/entitlement/EntitlementTestSuiteWithEmbeddedDB.java b/entitlement/src/test/java/org/killbill/billing/entitlement/EntitlementTestSuiteWithEmbeddedDB.java
index 9f6f218..120548c 100644
--- a/entitlement/src/test/java/org/killbill/billing/entitlement/EntitlementTestSuiteWithEmbeddedDB.java
+++ b/entitlement/src/test/java/org/killbill/billing/entitlement/EntitlementTestSuiteWithEmbeddedDB.java
@@ -140,9 +140,6 @@ public class EntitlementTestSuiteWithEmbeddedDB extends GuicyKillbillTestSuiteWi
startTestFamework(testListener, clock, busService, subscriptionBaseService, entitlementService);
this.catalog = initCatalog(catalogService);
- // Make sure we start with a clean state
- assertListenerStatus();
-
configureShiro();
login("EntitlementUser");
}
@@ -174,12 +171,8 @@ public class EntitlementTestSuiteWithEmbeddedDB extends GuicyKillbillTestSuiteWi
@AfterMethod(groups = "slow")
public void afterMethod() throws Exception {
-
securityApi.logout();
- // Make sure we finish in a clean state
- assertListenerStatus();
-
stopTestFramework(testListener, busService, subscriptionBaseService, entitlementService);
}
@@ -289,6 +282,7 @@ public class EntitlementTestSuiteWithEmbeddedDB extends GuicyKillbillTestSuiteWi
return account;
}
+ @Override
protected void assertListenerStatus() {
testListener.assertListenerStatus();
}
diff --git a/junction/src/test/java/org/killbill/billing/junction/JunctionTestSuiteWithEmbeddedDB.java b/junction/src/test/java/org/killbill/billing/junction/JunctionTestSuiteWithEmbeddedDB.java
index 4eced64..859d024 100644
--- a/junction/src/test/java/org/killbill/billing/junction/JunctionTestSuiteWithEmbeddedDB.java
+++ b/junction/src/test/java/org/killbill/billing/junction/JunctionTestSuiteWithEmbeddedDB.java
@@ -108,16 +108,10 @@ public abstract class JunctionTestSuiteWithEmbeddedDB extends GuicyKillbillTestS
super.beforeMethod();
startTestFamework();
this.catalog = initCatalog(catalogService);
-
- // Make sure we start with a clean state
- assertListenerStatus();
}
@AfterMethod(groups = "slow")
public void afterMethod() throws Exception {
- // Make sure we finish in a clean state
- assertListenerStatus();
-
stopTestFramework();
}
@@ -219,6 +213,7 @@ public abstract class JunctionTestSuiteWithEmbeddedDB extends GuicyKillbillTestS
return account;
}
+ @Override
protected void assertListenerStatus() {
testListener.assertListenerStatus();
}
diff --git a/payment/src/test/java/org/killbill/billing/payment/TestJanitor.java b/payment/src/test/java/org/killbill/billing/payment/TestJanitor.java
index 73d4bbd..cc247ca 100644
--- a/payment/src/test/java/org/killbill/billing/payment/TestJanitor.java
+++ b/payment/src/test/java/org/killbill/billing/payment/TestJanitor.java
@@ -115,6 +115,11 @@ public class TestJanitor extends PaymentTestSuiteWithEmbeddedDB {
);
}
+ @Override
+ protected void assertListenerStatus() {
+ testListener.assertListenerStatus();
+ }
+
@BeforeClass(groups = "slow")
protected void beforeClass() throws Exception {
super.beforeClass();
@@ -133,16 +138,12 @@ public class TestJanitor extends PaymentTestSuiteWithEmbeddedDB {
eventBus.register(testListener);
mockPaymentProviderPlugin.clear();
account = testHelper.createTestAccount("bobo@gmail.com", true);
-
- testListener.assertListenerStatus();
}
@AfterMethod(groups = "slow")
public void afterMethod() throws Exception {
retryService.stop();
- testListener.assertListenerStatus();
-
eventBus.unregister(handler);
eventBus.unregister(testListener);
super.afterMethod();
diff --git a/subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteNoDB.java b/subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteNoDB.java
index b90587c..e42bc0d 100644
--- a/subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteNoDB.java
+++ b/subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteNoDB.java
@@ -151,6 +151,7 @@ public class SubscriptionTestSuiteNoDB extends GuicyKillbillTestSuiteNoDB {
subscriptionTestInitializer.stopTestFramework(testListener, busService, subscriptionBaseService);
}
+ @Override
protected void assertListenerStatus() {
testListener.assertListenerStatus();
}
diff --git a/subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteWithEmbeddedDB.java b/subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteWithEmbeddedDB.java
index e97f3e0..02ce1be 100644
--- a/subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteWithEmbeddedDB.java
+++ b/subscription/src/test/java/org/killbill/billing/subscription/SubscriptionTestSuiteWithEmbeddedDB.java
@@ -115,16 +115,10 @@ public class SubscriptionTestSuiteWithEmbeddedDB extends GuicyKillbillTestSuiteW
this.accountData = subscriptionTestInitializer.initAccountData();
final Account account = createAccount(accountData);
this.bundle = subscriptionTestInitializer.initBundle(account.getId(), subscriptionInternalApi, internalCallContext);
-
- // Make sure we start with a clean state
- assertListenerStatus();
}
@AfterMethod(groups = "slow")
public void afterMethod() throws Exception {
- // Make sure we finish in a clean state
- assertListenerStatus();
-
subscriptionTestInitializer.stopTestFramework(testListener, busService, subscriptionBaseService);
}
@@ -136,6 +130,7 @@ public class SubscriptionTestSuiteWithEmbeddedDB extends GuicyKillbillTestSuiteW
return account;
}
+ @Override
protected void assertListenerStatus() {
testListener.assertListenerStatus();
}
diff --git a/util/src/test/java/org/killbill/billing/GuicyKillbillTestSuite.java b/util/src/test/java/org/killbill/billing/GuicyKillbillTestSuite.java
index 6a60b18..79008a6 100644
--- a/util/src/test/java/org/killbill/billing/GuicyKillbillTestSuite.java
+++ b/util/src/test/java/org/killbill/billing/GuicyKillbillTestSuite.java
@@ -36,6 +36,8 @@ import org.killbill.clock.ClockMock;
import org.skife.config.ConfigSource;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.testng.IHookCallBack;
+import org.testng.IHookable;
import org.testng.ITestResult;
import org.testng.annotations.AfterMethod;
import org.testng.annotations.BeforeMethod;
@@ -44,7 +46,7 @@ import org.testng.annotations.Listeners;
import com.google.common.collect.ImmutableMap;
@Listeners(FlakyInvokedMethodListener.class)
-public class GuicyKillbillTestSuite {
+public class GuicyKillbillTestSuite implements IHookable {
// Use the simple name here to save screen real estate
protected static final Logger log = LoggerFactory.getLogger(KillbillTestSuite.class.getSimpleName());
@@ -146,6 +148,24 @@ public class GuicyKillbillTestSuite {
}
}
+ // Note: assertions should not be run in before / after hooks, as the associated test result won't be correctly updated.
+ // Use this wrapper instead.
+ @Override
+ public void run(final IHookCallBack callBack, final ITestResult testResult) {
+ // Make sure we start with a clean state
+ assertListenerStatus();
+
+ // Run the actual test
+ callBack.runTestMethod(testResult);
+
+ // Make sure we finish in a clean state
+ assertListenerStatus();
+ }
+
+ protected void assertListenerStatus() {
+ // No-op
+ }
+
public boolean hasFailed() {
return hasFailed;
}
diff --git a/util/src/test/java/org/killbill/billing/util/UtilTestSuiteWithEmbeddedDB.java b/util/src/test/java/org/killbill/billing/util/UtilTestSuiteWithEmbeddedDB.java
index 503a229..0569958 100644
--- a/util/src/test/java/org/killbill/billing/util/UtilTestSuiteWithEmbeddedDB.java
+++ b/util/src/test/java/org/killbill/billing/util/UtilTestSuiteWithEmbeddedDB.java
@@ -123,20 +123,15 @@ public abstract class UtilTestSuiteWithEmbeddedDB extends GuicyKillbillTestSuite
eventBus.start();
eventBus.register(eventsListener);
-
- // Make sure we start with a clean state
- assertListenerStatus();
}
@AfterMethod(groups = "slow")
public void afterMethod() throws Exception {
- // Make sure we finish in a clean state
- assertListenerStatus();
-
eventBus.unregister(eventsListener);
eventBus.stop();
}
+ @Override
protected void assertListenerStatus() {
eventsListener.assertListenerStatus();
}