killbill-memoizeit

Some code review feedback on static lookups/magic global things

11/30/2011 2:36:14 PM

Details

diff --git a/entitlement/src/main/java/com/ning/billing/entitlement/api/user/Subscription.java b/entitlement/src/main/java/com/ning/billing/entitlement/api/user/Subscription.java
index a87e73c..0d217b9 100644
--- a/entitlement/src/main/java/com/ning/billing/entitlement/api/user/Subscription.java
+++ b/entitlement/src/main/java/com/ning/billing/entitlement/api/user/Subscription.java
@@ -93,10 +93,17 @@ public class Subscription extends PrivateFields  implements ISubscription {
 
     public Subscription(SubscriptionBuilder builder, boolean rebuildTransition) {
         super();
+        
+        /**
+         * Why are these found via static lookup rather than passed in via DI? 
+         * See http://martinfowler.com/articles/injection.html for explanation of
+         * why DI is your friend. -brianm
+         */
         this.clock = InjectorMagic.getClock();
         this.dao = InjectorMagic.getEntitlementDao();
         this.catalog = InjectorMagic.getCatlog();
         this.planAligner = InjectorMagic.getPlanAligner();
+        
         this.id = builder.getId();
         this.bundleId = builder.getBundleId();
         this.startDate = builder.getStartDate();