killbill-memoizeit
Changes
beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationVoidInvoice.java 117(+117 -0)
Details
diff --git a/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationVoidInvoice.java b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationVoidInvoice.java
new file mode 100644
index 0000000..f388e42
--- /dev/null
+++ b/beatrix/src/test/java/org/killbill/billing/beatrix/integration/TestIntegrationVoidInvoice.java
@@ -0,0 +1,117 @@
+/*
+ * Copyright 2014-2018 Groupon, Inc
+ * Copyright 2014-2018 The Billing Project, LLC
+ *
+ * The Billing Project licenses this file to you under the Apache License, version 2.0
+ * (the "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.killbill.billing.beatrix.integration;
+
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.joda.time.DateTime;
+import org.joda.time.LocalDate;
+import org.killbill.billing.ErrorCode;
+import org.killbill.billing.ObjectType;
+import org.killbill.billing.account.api.Account;
+import org.killbill.billing.api.TestApiListener.NextEvent;
+import org.killbill.billing.beatrix.util.InvoiceChecker.ExpectedInvoiceItemCheck;
+import org.killbill.billing.catalog.api.BillingPeriod;
+import org.killbill.billing.catalog.api.ProductCategory;
+import org.killbill.billing.entitlement.api.DefaultEntitlement;
+import org.killbill.billing.invoice.api.Invoice;
+import org.killbill.billing.invoice.api.InvoiceApiException;
+import org.killbill.billing.invoice.api.InvoiceItemType;
+import org.killbill.billing.invoice.api.InvoiceStatus;
+import org.killbill.billing.payment.api.Payment;
+import org.killbill.billing.payment.api.PluginProperty;
+import org.killbill.billing.subscription.api.user.DefaultSubscriptionBase;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import com.google.common.collect.ImmutableList;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
+
+public class TestIntegrationVoidInvoice extends TestIntegrationBase {
+
+ @Test(groups = "slow")
+ public void testVoidInvoice() throws Exception {
+ final int billingDay = 14;
+ final DateTime initialCreationDate = new DateTime(2015, 5, 15, 0, 0, 0, 0, testTimeZone);
+ // set clock to the initial start date
+ clock.setTime(initialCreationDate);
+
+ log.info("Beginning test with BCD of " + billingDay);
+ final Account account = createAccountWithNonOsgiPaymentMethod(getAccountData(billingDay));
+
+ add_AUTO_PAY_OFF_Tag(account.getId(), ObjectType.ACCOUNT);
+
+ DefaultEntitlement baseEntitlement = createBaseEntitlementAndCheckForCompletion(account.getId(), "bundleKey", "Shotgun", ProductCategory.BASE, BillingPeriod.MONTHLY, NextEvent.CREATE, NextEvent.BLOCK, NextEvent.INVOICE);
+ DefaultSubscriptionBase subscription = subscriptionDataFromSubscription(baseEntitlement.getSubscriptionBase());
+
+ final List<ExpectedInvoiceItemCheck> expectedInvoices = new ArrayList<ExpectedInvoiceItemCheck>();
+ expectedInvoices.add(new ExpectedInvoiceItemCheck(new LocalDate(2015, 6, 14), new LocalDate(2015, 7, 14), InvoiceItemType.RECURRING, new BigDecimal("249.95")));
+
+ // Move through time and verify we get the same invoice
+ busHandler.pushExpectedEvents(NextEvent.PHASE, NextEvent.INVOICE);
+ clock.addDays(30);
+ assertListenerStatus();
+
+ List<Invoice> invoices = invoiceUserApi.getInvoicesByAccount(account.getId(), false, false, callContext);
+ invoiceChecker.checkInvoice(invoices.get(1).getId(), callContext, expectedInvoices);
+
+ // Void the invoice
+ invoiceUserApi.voidInvoice(invoices.get(1).getId(), callContext);
+
+ remove_AUTO_PAY_OFF_Tag(account.getId(), ObjectType.ACCOUNT);
+
+ // Move through time
+ busHandler.pushExpectedEvents(NextEvent.INVOICE, NextEvent.PAYMENT, NextEvent.INVOICE_PAYMENT);
+ clock.addDays(31);
+ assertListenerStatus();
+
+ // get all invoices including the VOIDED; includeVoidedInvoices = true;
+ invoices = invoiceUserApi.getInvoicesByAccount(account.getId(), false, true, callContext);
+ assertEquals(invoices.size(), 3);
+ // verify integrity of the voided
+ invoiceChecker.checkInvoice(invoices.get(1).getId(), callContext, expectedInvoices);
+ assertEquals(invoices.get(1).getStatus(), InvoiceStatus.VOID);
+ // verify that the new invoice contains current and VOIDED charge
+ expectedInvoices.add(new ExpectedInvoiceItemCheck(new LocalDate(2015, 7, 14), new LocalDate(2015, 8, 14), InvoiceItemType.RECURRING, new BigDecimal("249.95")));
+
+ invoiceChecker.checkInvoice(invoices.get(2).getId(), callContext, expectedInvoices);
+
+ // verify that the account balance is fully paid and a payment exists
+ final BigDecimal accountBalance = invoiceUserApi.getAccountBalance(account.getId(), callContext);
+ assertTrue(accountBalance.compareTo(BigDecimal.ZERO) == 0);
+
+ final List<Payment> payments = paymentApi.getAccountPayments(account.getId(), false, false, ImmutableList.<PluginProperty>of(), callContext);
+ assertEquals(payments.size(), 1);
+
+ final Payment payment = payments.get(0);
+ assertTrue(payment.getPurchasedAmount().compareTo(invoices.get(2).getChargedAmount()) == 0);
+
+ // try to void an invoice that is already paid, it should fail.
+ try {
+ invoiceUserApi.voidInvoice(invoices.get(2).getId(), callContext);
+ Assert.fail("Should fail to void invoice that is already paid");
+ } catch (final InvoiceApiException e) {
+ Assert.assertEquals(e.getCode(), ErrorCode.CAN_NOT_VOID_INVOICE_THAT_IS_PAID.getCode());
+ }
+
+ }
+}
\ No newline at end of file
diff --git a/invoice/src/test/java/org/killbill/billing/invoice/api/user/TestDefaultInvoiceUserApi.java b/invoice/src/test/java/org/killbill/billing/invoice/api/user/TestDefaultInvoiceUserApi.java
index 5b1a46a..3d5e624 100644
--- a/invoice/src/test/java/org/killbill/billing/invoice/api/user/TestDefaultInvoiceUserApi.java
+++ b/invoice/src/test/java/org/killbill/billing/invoice/api/user/TestDefaultInvoiceUserApi.java
@@ -24,11 +24,13 @@ import java.util.UUID;
import javax.annotation.Nullable;
+import org.joda.time.DateTime;
import org.killbill.billing.ErrorCode;
import org.killbill.billing.ObjectType;
import org.killbill.billing.account.api.Account;
import org.killbill.billing.api.TestApiListener.NextEvent;
import org.killbill.billing.callcontext.DefaultCallContext;
+import org.killbill.billing.callcontext.InternalCallContext;
import org.killbill.billing.catalog.api.Currency;
import org.killbill.billing.invoice.InvoiceTestSuiteWithEmbeddedDB;
import org.killbill.billing.invoice.TestInvoiceHelper.DryRunFutureDateArguments;
@@ -36,8 +38,11 @@ import org.killbill.billing.invoice.api.Invoice;
import org.killbill.billing.invoice.api.InvoiceApiException;
import org.killbill.billing.invoice.api.InvoiceItem;
import org.killbill.billing.invoice.api.InvoiceItemType;
+import org.killbill.billing.invoice.api.InvoicePayment;
+import org.killbill.billing.invoice.api.InvoicePaymentType;
import org.killbill.billing.invoice.api.InvoiceStatus;
import org.killbill.billing.invoice.api.InvoiceUserApi;
+import org.killbill.billing.invoice.model.DefaultInvoicePayment;
import org.killbill.billing.invoice.model.ExternalChargeInvoiceItem;
import org.killbill.billing.util.api.TagApiException;
import org.killbill.billing.util.callcontext.CallContext;
@@ -377,4 +382,38 @@ public class TestDefaultInvoiceUserApi extends InvoiceTestSuiteWithEmbeddedDB {
Assert.assertEquals(e.getCode(), ErrorCode.INVOICE_ALREADY_COMMITTED.getCode());
}
}
+
+ @Test(groups = "slow")
+ public void testVoidInvoice() throws Exception {
+ // try to void invoice
+ invoiceUserApi.voidInvoice(invoiceId, callContext);
+
+ final Invoice invoice = invoiceUserApi.getInvoice(invoiceId, callContext);
+ Assert.assertEquals(invoice.getStatus(), InvoiceStatus.VOID);
+ }
+
+ @Test(groups = "slow")
+ public void testVoidInvoiceThatIsPaid() throws Exception {
+ InternalCallContext context = internalCallContextFactory.createInternalCallContext(accountId, callContext);
+ // Verify the initial invoice balance
+ final BigDecimal invoiceBalance = invoiceUserApi.getInvoice(invoiceId, callContext).getBalance();
+ Assert.assertEquals(invoiceBalance.compareTo(BigDecimal.ZERO), 1);
+
+ // Verify the initial account balance
+ final BigDecimal accountBalance = invoiceUserApi.getAccountBalance(accountId, callContext);
+ Assert.assertEquals(accountBalance, invoiceBalance);
+
+ // create payment
+ final InvoicePayment payment = new DefaultInvoicePayment(InvoicePaymentType.ATTEMPT, UUID.randomUUID(), invoiceId, new DateTime(), invoiceBalance, Currency.USD, Currency.USD, null, true);
+ invoiceUtil.createPayment(payment, context);
+
+ // try to void invoice, it should fail
+ try {
+ invoiceUserApi.voidInvoice(invoiceId, callContext);
+ Assert.fail("Should fail to void invoice that is already paid");
+ } catch (final InvoiceApiException e) {
+ Assert.assertEquals(e.getCode(), ErrorCode.CAN_NOT_VOID_INVOICE_THAT_IS_PAID.getCode());
+ }
+
+ }
}
diff --git a/profiles/killbill/src/test/java/org/killbill/billing/jaxrs/TestInvoiceVoid.java b/profiles/killbill/src/test/java/org/killbill/billing/jaxrs/TestInvoiceVoid.java
new file mode 100644
index 0000000..2f36a3b
--- /dev/null
+++ b/profiles/killbill/src/test/java/org/killbill/billing/jaxrs/TestInvoiceVoid.java
@@ -0,0 +1,177 @@
+/*
+ * Copyright 2014-2018 Groupon, Inc
+ * Copyright 2014-2018 The Billing Project, LLC
+ *
+ * The Billing Project licenses this file to you under the Apache License, version 2.0
+ * (the "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at:
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.killbill.billing.jaxrs;
+
+import java.math.BigDecimal;
+import java.util.List;
+import java.util.UUID;
+
+import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;
+import org.killbill.billing.catalog.api.BillingPeriod;
+import org.killbill.billing.catalog.api.ProductCategory;
+import org.killbill.billing.client.KillBillClientException;
+import org.killbill.billing.client.model.Account;
+import org.killbill.billing.client.model.Invoice;
+import org.killbill.billing.client.model.InvoiceItem;
+import org.killbill.billing.client.model.InvoicePayment;
+import org.killbill.billing.client.model.InvoicePaymentTransaction;
+import org.killbill.billing.client.model.InvoicePayments;
+import org.killbill.billing.client.model.PaymentTransaction;
+import org.killbill.billing.invoice.api.InvoiceStatus;
+import org.killbill.billing.payment.api.TransactionType;
+import org.killbill.billing.util.api.AuditLevel;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotNull;
+import static org.testng.Assert.assertTrue;
+
+public class TestInvoiceVoid extends TestJaxrsBase {
+
+ @Test(groups = "slow", description = "Can void an invoice")
+ public void testInvoiceVoid() throws Exception {
+ final Account accountJson = createAccountWithExternalPMBundleAndSubscriptionAndManualPayTagAndWaitForFirstInvoice();
+ assertNotNull(accountJson);
+
+ // Verify we didn't get any invoicePayment
+ final List<InvoicePayment> noPaymentsFromJson = killBillClient.getInvoicePaymentsForAccount(accountJson.getAccountId(), requestOptions);
+ assertEquals(noPaymentsFromJson.size(), 0);
+
+ // Get the invoices
+ List<Invoice> invoices = killBillClient.getInvoicesForAccount(accountJson.getAccountId(), requestOptions);
+ // 2 invoices but look for the non zero dollar one
+ assertEquals(invoices.size(), 2);
+ // verify account balance
+ Account account = killBillClient.getAccount(accountJson.getAccountId(), true, true, requestOptions);
+ assertEquals(account.getAccountBalance().compareTo(invoices.get(1).getBalance()), 0);
+
+ // void the invoice
+ killBillClient.voidInvoice(invoices.get(1).getInvoiceId(), requestOptions);
+
+ // Get the invoices excluding voided
+ invoices = killBillClient.getInvoicesForAccount(accountJson.getAccountId(), requestOptions);
+ // the voided invoice should not be returned
+ assertEquals(invoices.size(), 1);
+
+ // Get the invoices including voided
+ invoices = killBillClient.getInvoicesForAccount(accountJson.getAccountId(), true, false, true, true, AuditLevel.NONE, requestOptions);
+ assertEquals(invoices.size(), 2);
+ assertEquals(invoices.get(1).getStatus(), InvoiceStatus.VOID.toString());
+ assertEquals(invoices.get(1).getBalance().compareTo(BigDecimal.ZERO), 0);
+
+ // check that account balance is zero
+ account = killBillClient.getAccount(accountJson.getAccountId(), true, true, requestOptions);
+ assertEquals(account.getAccountBalance().compareTo(BigDecimal.ZERO), 0);
+
+ // After invoice was voided verify the subscription is re-invoiced on a new invoice
+ // trigger an invoice generation
+ killBillClient.createInvoice(accountJson.getAccountId(), clock.getToday(DateTimeZone.forID(accountJson.getTimeZone())), requestOptions);
+
+ // Get the invoices excluding voided
+ invoices = killBillClient.getInvoicesForAccount(accountJson.getAccountId(), requestOptions);
+ // the voided invoice should not be returned
+ assertEquals(invoices.size(), 2);
+
+ // process payment
+ InvoicePayment invoicePayment = processPayment(accountJson, invoices.get(1), false);
+
+ // try to void invoice
+ try {
+ killBillClient.voidInvoice(invoices.get(1).getInvoiceId(), requestOptions);
+ Assert.fail("VoidInvoice call should fail with 400");
+ } catch (final KillBillClientException e) {
+ assertTrue(true);
+ }
+
+ //refund payment
+ refundPayment(invoicePayment);
+
+ // try to void invoice
+ try {
+ killBillClient.voidInvoice(invoices.get(1).getInvoiceId(), requestOptions);
+ } catch (final KillBillClientException e) {
+ assertTrue(false);
+ }
+
+ // check that account balance is zero
+ account = killBillClient.getAccount(accountJson.getAccountId(), true, true, requestOptions);
+ assertEquals(account.getAccountBalance().compareTo(BigDecimal.ZERO), 0);
+
+ }
+
+ @Test(groups = "slow", description = "Can not void an invoice with partial payment")
+ public void testInvoiceVoidWithPartialPay() throws Exception {
+ final Account accountJson = createAccountWithExternalPMBundleAndSubscriptionAndManualPayTagAndWaitForFirstInvoice();
+ assertNotNull(accountJson);
+
+ // Verify we didn't get any invoicePayment
+ final List<InvoicePayment> noPaymentsFromJson = killBillClient.getInvoicePaymentsForAccount(accountJson.getAccountId(), requestOptions);
+ assertEquals(noPaymentsFromJson.size(), 0);
+
+ // Get the invoices
+ List<Invoice> invoices = killBillClient.getInvoicesForAccount(accountJson.getAccountId(), requestOptions);
+ // 2 invoices but look for the non zero dollar one
+ assertEquals(invoices.size(), 2);
+ // verify account balance
+ Account account = killBillClient.getAccount(accountJson.getAccountId(), true, true, requestOptions);
+ assertEquals(account.getAccountBalance().compareTo(invoices.get(1).getBalance()), 0);
+
+ // process payment
+ InvoicePayment invoicePayment = processPayment(accountJson, invoices.get(1), true);
+
+ // try to void invoice
+ try {
+ killBillClient.voidInvoice(invoices.get(1).getInvoiceId(), requestOptions);
+ Assert.fail("VoidInvoice call should fail with 400");
+ } catch (final KillBillClientException e) {
+ assertTrue(true);
+ }
+
+ }
+
+ private InvoicePayment processPayment(Account accountJson, Invoice invoice, boolean partialPay) throws Exception {
+
+ final BigDecimal payAmount = partialPay ? invoice.getBalance().subtract(BigDecimal.TEN) : invoice.getBalance();
+ final InvoicePayment invoicePayment = new InvoicePayment();
+ invoicePayment.setPurchasedAmount(payAmount);
+ invoicePayment.setAccountId(accountJson.getAccountId());
+ invoicePayment.setTargetInvoiceId(invoice.getInvoiceId());
+
+ final InvoicePayment result = killBillClient.createInvoicePayment(invoicePayment, false, requestOptions);
+ assertEquals(result.getTransactions().size(), 1);
+ assertTrue(result.getTransactions().get(0).getAmount().compareTo(payAmount) == 0);
+
+ return result;
+ }
+
+ private void refundPayment(InvoicePayment payment) throws Exception {
+
+ final InvoicePaymentTransaction refund = new InvoicePaymentTransaction();
+ refund.setPaymentId(payment.getPaymentId());
+ refund.setAmount(payment.getPurchasedAmount());
+ killBillClient.createInvoicePaymentRefund(refund, requestOptions);
+
+ final InvoicePayments allPayments = killBillClient.getInvoicePaymentsForAccount(payment.getAccountId(), requestOptions);
+ assertEquals(allPayments.size(), 1);
+
+ final List<PaymentTransaction> objRefundFromJson = getPaymentTransactions(allPayments, TransactionType.REFUND.toString());
+ assertEquals(objRefundFromJson.size(), 1);
+ }
+}