killbill-memoizeit

invoice: catch only IllegalArgumentException if the currency

10/7/2015 5:47:34 PM

Details

diff --git a/invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java b/invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java
index b12e189..7ebb8d2 100644
--- a/invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java
+++ b/invoice/src/main/java/org/killbill/billing/invoice/template/formatters/DefaultInvoiceFormatter.java
@@ -232,19 +232,18 @@ public class DefaultInvoiceFormatter implements InvoiceFormatter {
     }
 
     // Returns the formatted amount with the correct currency symbol that is get from the invoice currency.
-    private String getFormattedAmountByLocaleAndInvoiceCurrency(BigDecimal amount) {
-
-        String invoiceCurrencyCode = invoice.getCurrency().toString();
-        CurrencyUnit currencyUnit = CurrencyUnit.of(invoiceCurrencyCode);
+    private String getFormattedAmountByLocaleAndInvoiceCurrency(final BigDecimal amount) {
+        final String invoiceCurrencyCode = invoice.getCurrency().toString();
+        final CurrencyUnit currencyUnit = CurrencyUnit.of(invoiceCurrencyCode);
 
         final DecimalFormat numberFormatter = (DecimalFormat) DecimalFormat.getCurrencyInstance(locale);
-        DecimalFormatSymbols dfs = numberFormatter.getDecimalFormatSymbols();
+        final DecimalFormatSymbols dfs = numberFormatter.getDecimalFormatSymbols();
         dfs.setInternationalCurrencySymbol(currencyUnit.getCurrencyCode());
 
         try {
             final java.util.Currency currency = java.util.Currency.getInstance(invoiceCurrencyCode);
             dfs.setCurrencySymbol(currency.getSymbol(currencyLocaleMap.get(currency)));
-        } catch (Exception e) {
+        } catch (final IllegalArgumentException e) {
             dfs.setCurrencySymbol(currencyUnit.getSymbol(locale));
         }