killbill-memoizeit

entitlement: remove nested else-if in DefaultEntitlementService Signed-off-by: …

1/25/2015 5:22:43 PM

Pierre-Alexandre Meyer <pierre@mouraf.org>

Pierre-Alexandre Meyer

Commit: b577bc8

Tree: f65f55e

Parents: 691bb38

Changes

entitlement/src/main/java/org/killbill/billing/entitlement/DefaultEntitlementService.java 10(+4 -6)

Details

entitlement/src/main/java/org/killbill/billing/entitlement/DefaultEntitlementService.java 10(+4 -6)

diff --git a/entitlement/src/main/java/org/killbill/billing/entitlement/DefaultEntitlementService.java b/entitlement/src/main/java/org/killbill/billing/entitlement/DefaultEntitlementService.java
index 389f75c..cd4e917 100644
--- a/entitlement/src/main/java/org/killbill/billing/entitlement/DefaultEntitlementService.java
+++ b/entitlement/src/main/java/org/killbill/billing/entitlement/DefaultEntitlementService.java
@@ -131,12 +131,10 @@ public class DefaultEntitlementService implements EntitlementService {
             if (EntitlementNotificationKeyAction.CHANGE.equals(entitlementNotificationKeyAction) ||
                 EntitlementNotificationKeyAction.CANCEL.equals(entitlementNotificationKeyAction)) {
                 ((DefaultEntitlement) entitlement).blockAddOnsIfRequired(key.getEffectiveDate(), callContext, internalCallContext);
-            } else {
-                if (EntitlementNotificationKeyAction.PAUSE.equals(entitlementNotificationKeyAction)) {
-                    entitlementApi.pause(key.getBundleId(), key.getEffectiveDate().toLocalDate(), callContext);
-                } else if (EntitlementNotificationKeyAction.RESUME.equals(entitlementNotificationKeyAction)) {
-                    entitlementApi.resume(key.getBundleId(), key.getEffectiveDate().toLocalDate(), callContext);
-                }
+            } else if (EntitlementNotificationKeyAction.PAUSE.equals(entitlementNotificationKeyAction)) {
+                entitlementApi.pause(key.getBundleId(), key.getEffectiveDate().toLocalDate(), callContext);
+            } else if (EntitlementNotificationKeyAction.RESUME.equals(entitlementNotificationKeyAction)) {
+                entitlementApi.resume(key.getBundleId(), key.getEffectiveDate().toLocalDate(), callContext);
             }
         } catch (final EntitlementApiException e) {
             log.error("Error processing event for entitlement {}" + entitlement.getId(), e);