killbill-memoizeit

If plugin returns a null result (Bad plugin), we transition …

7/17/2014 6:38:32 PM

into PLUGIN_FAILURE regarldess of whether or not it threw an exception.
PLUGIN_FAILURE does not mean call did not succeed at the gateway, it rather indicates that it is uncertain whether or not call has failed.

stephane brossier

Commit: e3d465c

Tree: 4c7714e

Parents: 880e3d7

Changes

payment/src/main/java/org/killbill/billing/payment/core/sm/PaymentEnteringStateCallback.java 2(+1 -1)

Details

payment/src/main/java/org/killbill/billing/payment/core/sm/PaymentEnteringStateCallback.java 2(+1 -1)

diff --git a/payment/src/main/java/org/killbill/billing/payment/core/sm/PaymentEnteringStateCallback.java b/payment/src/main/java/org/killbill/billing/payment/core/sm/PaymentEnteringStateCallback.java
index a60afa2..fd4d928 100644
--- a/payment/src/main/java/org/killbill/billing/payment/core/sm/PaymentEnteringStateCallback.java
+++ b/payment/src/main/java/org/killbill/billing/payment/core/sm/PaymentEnteringStateCallback.java
@@ -85,7 +85,7 @@ public abstract class PaymentEnteringStateCallback implements EnteringStateCallb
                 return TransactionStatus.PLUGIN_FAILURE;
             } else {
                 // The plugin completed the call but returned null?! Bad plugin...
-                return TransactionStatus.UNKNOWN;
+                return TransactionStatus.PLUGIN_FAILURE;
             }
         }