killbill-uncached
Details
beatrix/pom.xml 6(+3 -3)
diff --git a/beatrix/pom.xml b/beatrix/pom.xml
index c8497d9..16402d7 100644
--- a/beatrix/pom.xml
+++ b/beatrix/pom.xml
@@ -236,9 +236,9 @@
</goals>
<configuration>
<tasks>
- <copy file="${basedir}/../osgi-bundles/tests/beatrix/target/killbill-osgi-bundles-test-beatrix-${project.version}-jar-with-dependencies.jar" tofile="${basedir}/src/test/resources/killbill-osgi-bundles-test-beatrix-${project.version}-jar-with-dependencies.jar" />
- <copy file="${basedir}/../osgi-bundles/tests/payment/target/killbill-osgi-bundles-test-payment-${project.version}-jar-with-dependencies.jar" tofile="${basedir}/src/test/resources/killbill-osgi-bundles-test-payment-${project.version}-jar-with-dependencies.jar" />
- <copy file="${basedir}/../osgi-bundles/bundles/jruby/target/killbill-osgi-bundles-jruby-${project.version}.jar" tofile="${basedir}/src/test/resources/killbill-osgi-bundles-jruby-${project.version}.jar" />
+ <copy file="${basedir}/../osgi-bundles/tests/beatrix/target/killbill-osgi-bundles-test-beatrix-${project.version}-jar-with-dependencies.jar" tofile="${basedir}/src/test/resources/killbill-osgi-bundles-test-beatrix-${project.version}-jar-with-dependencies.jar"></copy>
+ <copy file="${basedir}/../osgi-bundles/tests/payment/target/killbill-osgi-bundles-test-payment-${project.version}-jar-with-dependencies.jar" tofile="${basedir}/src/test/resources/killbill-osgi-bundles-test-payment-${project.version}-jar-with-dependencies.jar"></copy>
+ <copy file="${basedir}/../osgi-bundles/bundles/jruby/target/killbill-osgi-bundles-jruby-${project.version}.jar" tofile="${basedir}/src/test/resources/killbill-osgi-bundles-jruby-${project.version}.jar"></copy>
</tasks>
</configuration>
</execution>
diff --git a/jaxrs/src/main/java/com/ning/billing/jaxrs/json/InvoiceItemJson.java b/jaxrs/src/main/java/com/ning/billing/jaxrs/json/InvoiceItemJson.java
index ab8c198..9d24510 100644
--- a/jaxrs/src/main/java/com/ning/billing/jaxrs/json/InvoiceItemJson.java
+++ b/jaxrs/src/main/java/com/ning/billing/jaxrs/json/InvoiceItemJson.java
@@ -40,6 +40,7 @@ public class InvoiceItemJson extends JsonBase {
private final String subscriptionId;
private final String planName;
private final String phaseName;
+ private final String itemType;
private final String description;
private final LocalDate startDate;
private final LocalDate endDate;
@@ -55,6 +56,7 @@ public class InvoiceItemJson extends JsonBase {
@JsonProperty("subscriptionId") final String subscriptionId,
@JsonProperty("planName") final String planName,
@JsonProperty("phaseName") final String phaseName,
+ @JsonProperty("itemType") final String itemType,
@JsonProperty("description") final String description,
@JsonProperty("startDate") final LocalDate startDate,
@JsonProperty("endDate") final LocalDate endDate,
@@ -70,6 +72,7 @@ public class InvoiceItemJson extends JsonBase {
this.subscriptionId = subscriptionId;
this.planName = planName;
this.phaseName = phaseName;
+ this.itemType = itemType;
this.description = description;
this.startDate = startDate;
this.endDate = endDate;
@@ -80,7 +83,8 @@ public class InvoiceItemJson extends JsonBase {
public InvoiceItemJson(final InvoiceItem item, @Nullable final List<AuditLog> auditLogs) {
this(toString(item.getId()), toString(item.getInvoiceId()), toString(item.getLinkedItemId()),
toString(item.getAccountId()), toString(item.getBundleId()), toString(item.getSubscriptionId()),
- item.getPlanName(), item.getPhaseName(), item.getDescription(), item.getStartDate(), item.getEndDate(),
+ item.getPlanName(), item.getPhaseName(), item.getInvoiceItemType().toString(),
+ item.getDescription(), item.getStartDate(), item.getEndDate(),
item.getAmount(), item.getCurrency(), toAuditLogJson(auditLogs));
}
@@ -120,6 +124,10 @@ public class InvoiceItemJson extends JsonBase {
return phaseName;
}
+ public String getItemType() {
+ return itemType;
+ }
+
public String getDescription() {
return description;
}
diff --git a/jaxrs/src/main/java/com/ning/billing/jaxrs/resources/AccountResource.java b/jaxrs/src/main/java/com/ning/billing/jaxrs/resources/AccountResource.java
index 34e7388..8538783 100644
--- a/jaxrs/src/main/java/com/ning/billing/jaxrs/resources/AccountResource.java
+++ b/jaxrs/src/main/java/com/ning/billing/jaxrs/resources/AccountResource.java
@@ -19,6 +19,7 @@ package com.ning.billing.jaxrs.resources;
import java.math.BigDecimal;
import java.util.ArrayList;
import java.util.Collection;
+import java.util.LinkedList;
import java.util.List;
import java.util.UUID;
@@ -61,6 +62,7 @@ import com.ning.billing.jaxrs.json.BundleJson;
import com.ning.billing.jaxrs.json.ChargebackJson;
import com.ning.billing.jaxrs.json.CustomFieldJson;
import com.ning.billing.jaxrs.json.InvoiceEmailJson;
+import com.ning.billing.jaxrs.json.InvoiceJson;
import com.ning.billing.jaxrs.json.OverdueStateJson;
import com.ning.billing.jaxrs.json.PaymentJson;
import com.ning.billing.jaxrs.json.PaymentMethodJson;
@@ -368,6 +370,47 @@ public class AccountResource extends JaxRsResourceBase {
return Response.status(Status.OK).build();
}
+
+ /*
+ * ************************** INVOICES ********************************
+ */
+
+ @GET
+ @Path("/{accountId:" + UUID_PATTERN + "}/" + INVOICES)
+ @Produces(APPLICATION_JSON)
+ public Response getInvoices(@PathParam("accountId") final String accountId,
+ @QueryParam(QUERY_INVOICE_WITH_ITEMS) @DefaultValue("false") final boolean withItems,
+ @QueryParam(QUERY_AUDIT) @DefaultValue("NONE") final AuditMode auditMode,
+ @javax.ws.rs.core.Context final HttpServletRequest request) throws AccountApiException {
+ final TenantContext tenantContext = context.createContext(request);
+
+ // Verify the account exists
+ accountUserApi.getAccountById(UUID.fromString(accountId), tenantContext);
+
+ final List<Invoice> invoices = invoiceApi.getInvoicesByAccount(UUID.fromString(accountId), tenantContext);
+ final AuditLogsForInvoices invoicesAuditLogs = auditUserApi.getAuditLogsForInvoices(invoices, auditMode.getLevel(), tenantContext);
+
+ if (withItems) {
+ final List<InvoiceJson> result = new LinkedList<InvoiceJson>();
+ for (final Invoice invoice : invoices) {
+ result.add(new InvoiceJson(invoice,
+ invoicesAuditLogs.getInvoiceAuditLogs().get(invoice.getId()),
+ invoicesAuditLogs.getInvoiceItemsAuditLogs()));
+ }
+
+ return Response.status(Status.OK).entity(result).build();
+ } else {
+ final List<InvoiceJson> result = new LinkedList<InvoiceJson>();
+ for (final Invoice invoice : invoices) {
+ result.add(new InvoiceJson(invoice,
+ invoicesAuditLogs.getInvoiceAuditLogs().get(invoice.getId())));
+ }
+
+ return Response.status(Status.OK).entity(result).build();
+ }
+ }
+
+
/*
* ************************** PAYMENTS ********************************
*/
diff --git a/jaxrs/src/main/java/com/ning/billing/jaxrs/resources/InvoiceResource.java b/jaxrs/src/main/java/com/ning/billing/jaxrs/resources/InvoiceResource.java
index a7c8d33..448d539 100644
--- a/jaxrs/src/main/java/com/ning/billing/jaxrs/resources/InvoiceResource.java
+++ b/jaxrs/src/main/java/com/ning/billing/jaxrs/resources/InvoiceResource.java
@@ -109,39 +109,6 @@ public class InvoiceResource extends JaxRsResourceBase {
this.invoiceNotifier = invoiceNotifier;
}
- @GET
- @Produces(APPLICATION_JSON)
- public Response getInvoices(@QueryParam(QUERY_ACCOUNT_ID) final String accountId,
- @QueryParam(QUERY_INVOICE_WITH_ITEMS) @DefaultValue("false") final boolean withItems,
- @QueryParam(QUERY_AUDIT) @DefaultValue("NONE") final AuditMode auditMode,
- @javax.ws.rs.core.Context final HttpServletRequest request) throws AccountApiException {
- final TenantContext tenantContext = context.createContext(request);
-
- // Verify the account exists
- accountUserApi.getAccountById(UUID.fromString(accountId), tenantContext);
-
- final List<Invoice> invoices = invoiceApi.getInvoicesByAccount(UUID.fromString(accountId), tenantContext);
- final AuditLogsForInvoices invoicesAuditLogs = auditUserApi.getAuditLogsForInvoices(invoices, auditMode.getLevel(), tenantContext);
-
- if (withItems) {
- final List<InvoiceJson> result = new LinkedList<InvoiceJson>();
- for (final Invoice invoice : invoices) {
- result.add(new InvoiceJson(invoice,
- invoicesAuditLogs.getInvoiceAuditLogs().get(invoice.getId()),
- invoicesAuditLogs.getInvoiceItemsAuditLogs()));
- }
-
- return Response.status(Status.OK).entity(result).build();
- } else {
- final List<InvoiceJson> result = new LinkedList<InvoiceJson>();
- for (final Invoice invoice : invoices) {
- result.add(new InvoiceJson(invoice,
- invoicesAuditLogs.getInvoiceAuditLogs().get(invoice.getId())));
- }
-
- return Response.status(Status.OK).entity(result).build();
- }
- }
@GET
@Path("/{invoiceId:" + UUID_PATTERN + "}/")
diff --git a/jaxrs/src/test/java/com/ning/billing/jaxrs/json/TestInvoiceItemJsonSimple.java b/jaxrs/src/test/java/com/ning/billing/jaxrs/json/TestInvoiceItemJsonSimple.java
index 11c9028..16e5b03 100644
--- a/jaxrs/src/test/java/com/ning/billing/jaxrs/json/TestInvoiceItemJsonSimple.java
+++ b/jaxrs/src/test/java/com/ning/billing/jaxrs/json/TestInvoiceItemJsonSimple.java
@@ -43,6 +43,7 @@ public class TestInvoiceItemJsonSimple extends JaxrsTestSuiteNoDB {
final String subscriptionId = UUID.randomUUID().toString();
final String planName = UUID.randomUUID().toString();
final String phaseName = UUID.randomUUID().toString();
+ final String type = "FIXED";
final String description = UUID.randomUUID().toString();
final LocalDate startDate = clock.getUTCToday();
final LocalDate endDate = clock.getUTCToday();
@@ -50,7 +51,7 @@ public class TestInvoiceItemJsonSimple extends JaxrsTestSuiteNoDB {
final Currency currency = Currency.MXN;
final List<AuditLogJson> auditLogs = createAuditLogsJson(clock.getUTCNow());
final InvoiceItemJson invoiceItemJson = new InvoiceItemJson(invoiceItemId, invoiceId, linkedInvoiceItemId, accountId,
- bundleId, subscriptionId, planName, phaseName, description,
+ bundleId, subscriptionId, planName, phaseName, type, description,
startDate, endDate, amount, currency, auditLogs);
Assert.assertEquals(invoiceItemJson.getInvoiceItemId(), invoiceItemId);
Assert.assertEquals(invoiceItemJson.getInvoiceId(), invoiceId);
@@ -60,6 +61,7 @@ public class TestInvoiceItemJsonSimple extends JaxrsTestSuiteNoDB {
Assert.assertEquals(invoiceItemJson.getSubscriptionId(), subscriptionId);
Assert.assertEquals(invoiceItemJson.getPlanName(), planName);
Assert.assertEquals(invoiceItemJson.getPhaseName(), phaseName);
+ Assert.assertEquals(invoiceItemJson.getItemType(), type);
Assert.assertEquals(invoiceItemJson.getDescription(), description);
Assert.assertEquals(invoiceItemJson.getStartDate(), startDate);
Assert.assertEquals(invoiceItemJson.getEndDate(), endDate);
diff --git a/jaxrs/src/test/java/com/ning/billing/jaxrs/json/TestRefundJson.java b/jaxrs/src/test/java/com/ning/billing/jaxrs/json/TestRefundJson.java
index 1d79e0c..544c23d 100644
--- a/jaxrs/src/test/java/com/ning/billing/jaxrs/json/TestRefundJson.java
+++ b/jaxrs/src/test/java/com/ning/billing/jaxrs/json/TestRefundJson.java
@@ -74,11 +74,12 @@ public class TestRefundJson extends JaxrsTestSuiteNoDB {
final String description = UUID.randomUUID().toString();
final LocalDate startDate = clock.getUTCToday();
final LocalDate endDate = clock.getUTCToday();
+ final String type = "FIXED";
final BigDecimal amount = BigDecimal.TEN;
final Currency currency = Currency.MXN;
final List<AuditLogJson> auditLogs = createAuditLogsJson(clock.getUTCNow());
return new InvoiceItemJson(invoiceItemId, invoiceId, linkedInvoiceItemId, accountId, bundleId, subscriptionId,
- planName, phaseName, description, startDate, endDate,
+ planName, phaseName, type, description, startDate, endDate,
amount, currency, auditLogs);
}
}
osgi-bundles/bundles/logger/pom.xml 2(+1 -1)
diff --git a/osgi-bundles/bundles/logger/pom.xml b/osgi-bundles/bundles/logger/pom.xml
index be41e50..0112912 100644
--- a/osgi-bundles/bundles/logger/pom.xml
+++ b/osgi-bundles/bundles/logger/pom.xml
@@ -56,7 +56,7 @@
<configuration>
<instructions>
<Bundle-Activator>com.ning.billing.osgi.bundles.logger.Activator</Bundle-Activator>
- <Export-Package />
+ <Export-Package></Export-Package>
<Private-Package>com.ning.billing.osgi.bundles.logger.*</Private-Package>
<!-- Optional resolution because exported by the Felix system bundle -->
<Import-Package>*;resolution:=optional</Import-Package>
diff --git a/server/src/test/java/com/ning/billing/jaxrs/KillbillClient.java b/server/src/test/java/com/ning/billing/jaxrs/KillbillClient.java
index 21fe660..0e257ed 100644
--- a/server/src/test/java/com/ning/billing/jaxrs/KillbillClient.java
+++ b/server/src/test/java/com/ning/billing/jaxrs/KillbillClient.java
@@ -483,10 +483,10 @@ public abstract class KillbillClient extends GuicyKillbillTestSuiteWithEmbeddedD
}
private <T> List<T> doGetInvoicesForAccount(final String accountId, final Boolean withItems, final TypeReference<List<T>> clazz, final AuditLevel auditLevel) throws IOException {
- final String invoicesURI = JaxrsResource.INVOICES_PATH;
+
+ final String invoicesURI = JaxrsResource.ACCOUNTS_PATH + "/" + accountId + "/" + JaxrsResource.INVOICES;
final Map<String, String> queryParams = new HashMap<String, String>();
- queryParams.put(JaxrsResource.QUERY_ACCOUNT_ID, accountId);
queryParams.put(JaxrsResource.QUERY_INVOICE_WITH_ITEMS, withItems.toString());
queryParams.put(JaxrsResource.QUERY_AUDIT, auditLevel.toString());
@@ -542,7 +542,7 @@ public abstract class KillbillClient extends GuicyKillbillTestSuiteWithEmbeddedD
}
final InvoiceItemJson adjustment = new InvoiceItemJson(invoiceItemId, null, null, accountId, null, null, null, null,
- null, null, null, amount, currency, null);
+ null, null, null, null, amount, currency, null);
final String adjustmentJson = mapper.writeValueAsString(adjustment);
final Response response = doPost(uri, adjustmentJson, queryParams, DEFAULT_HTTP_TIMEOUT_SEC);
Assert.assertEquals(response.getStatusCode(), Status.CREATED.getStatusCode());
@@ -567,7 +567,7 @@ public abstract class KillbillClient extends GuicyKillbillTestSuiteWithEmbeddedD
}
final InvoiceItemJson externalCharge = new InvoiceItemJson(null, invoiceId, null, accountId, bundleId, null, null, null,
- null, null, null, amount, currency, null);
+ null, null, null, null, amount, currency, null);
final String externalChargeJson = mapper.writeValueAsString(externalCharge);
final Response response = doPost(uri, externalChargeJson, queryParams, DEFAULT_HTTP_TIMEOUT_SEC);
Assert.assertEquals(response.getStatusCode(), Status.CREATED.getStatusCode());
@@ -787,7 +787,7 @@ public abstract class KillbillClient extends GuicyKillbillTestSuiteWithEmbeddedD
final List<InvoiceItemJson> adjustments = new ArrayList<InvoiceItemJson>();
for (final String itemId : itemAdjustments.keySet()) {
- adjustments.add(new InvoiceItemJson(itemId, null, null, null, null, null, null, null, null, null, null,
+ adjustments.add(new InvoiceItemJson(itemId, null, null, null, null, null, null, null, null, null, null, null,
itemAdjustments.get(itemId), null, null));
}
final RefundJson refundJson = new RefundJson(null, paymentId, amount, DEFAULT_CURRENCY, adjusted, null, null, adjustments, null);