killbill-uncached

analytics: update comment in BusinessTagRecorder Signed-off-by:

6/22/2012 12:19:09 AM

Details

diff --git a/analytics/src/main/java/com/ning/billing/analytics/BusinessTagRecorder.java b/analytics/src/main/java/com/ning/billing/analytics/BusinessTagRecorder.java
index 7b8488d..8aa4343 100644
--- a/analytics/src/main/java/com/ning/billing/analytics/BusinessTagRecorder.java
+++ b/analytics/src/main/java/com/ning/billing/analytics/BusinessTagRecorder.java
@@ -122,7 +122,11 @@ public class BusinessTagRecorder {
             return;
         }
 
-        // TODO - this stores tags for bundles?
+        /*
+         * Note: we store tags associated to bundles, not to subscriptions.
+         * Subscriptions are in the core of killbill and not exposed in Analytics to avoid a hard dependency
+         * (i.e. dashboards should not rely on killbill ids).
+         */
         final String externalKey = bundle.getKey();
         subscriptionTransitionTagSqlDao.addTag(externalKey, name);
     }
@@ -136,7 +140,6 @@ public class BusinessTagRecorder {
             return;
         }
 
-        // TODO - this stores tags for bundles?
         final String externalKey = bundle.getKey();
         subscriptionTransitionTagSqlDao.removeTag(externalKey, name);
     }