azkaban-aplcache

Shut down single server if startup fails (#2002) The single …

10/24/2018 12:40:07 PM

server first starts executor server, then web server.

If web server startup failed, the single server process was left running, making it harder to realize that there was an issue in startup.

This PR makes it easier to spot a startup error by stopping JVM in case of a startup error.
Without this change, the ERROR from web startup is buried in an earlier phase of the logs. The JVM keeps running despite an exception thrown by web start call because executor server's thread remains alive. As the executor server has already successfully started, it will keep logging some periodical stuff into the log file, making it harder to find out what was the last thing that happened on the web server's side.

Juho Autio

Commit: 0904033

Tree: 6b295cd

Parents: 4a224d3

Changes

azkaban-solo-server/src/main/java/azkaban/soloserver/AzkabanSingleServer.java 11(+10 -1)

Details

azkaban-solo-server/src/main/java/azkaban/soloserver/AzkabanSingleServer.java 11(+10 -1)

diff --git a/azkaban-solo-server/src/main/java/azkaban/soloserver/AzkabanSingleServer.java b/azkaban-solo-server/src/main/java/azkaban/soloserver/AzkabanSingleServer.java
index 33a05d7..fab9267 100644
--- a/azkaban-solo-server/src/main/java/azkaban/soloserver/AzkabanSingleServer.java
+++ b/azkaban-solo-server/src/main/java/azkaban/soloserver/AzkabanSingleServer.java
@@ -53,7 +53,16 @@ public class AzkabanSingleServer {
     this.executor = executor;
   }
 
-  public static void main(String[] args) throws Exception {
+  public static void main(String[] args) {
+    try {
+      start(args);
+    } catch (Exception e) {
+      log.error("Failed to start single server. Shutting down.", e);
+      System.exit(1);
+    }
+  }
+
+  public static void start(String[] args) throws Exception {
     log.info("Starting Azkaban Server");
 
     if (System.getSecurityManager() == null) {