azkaban-aplcache

#1947 wrong 'Host' header in http callbacks deleted. (#1961) Azkaban …

11/27/2018 11:36:05 PM

provide the ability to call HTTP resources as described in 'HTTP Job Callback' https://azkaban.github.io/azkaban/docs/latest/#common-configurations
job.notification.started.1.url=.. and etc

In the implementation https://github.com/azkaban/azkaban/blob/master/azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackManager.java#L263 'azkabanHostName' used as the value of 'Host' header. But the value should be the hostname of requested HTTP resource, not Azkaban's host.

For example for https://hooks.slack.com/services should be Host:hooks.slack.com

Vladislav Sidorovich

Commit: 35382d6

Tree: ce28b5b

Parents: 4f5f813

Changes

azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackManager.java 1(+0 -1)

Details

azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackManager.java 1(+0 -1)

diff --git a/azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackManager.java b/azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackManager.java
index 44bcc59..6922d1f 100644
--- a/azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackManager.java
+++ b/azkaban-exec-server/src/main/java/azkaban/execapp/event/JobCallbackManager.java
@@ -260,7 +260,6 @@ public class JobCallbackManager implements EventListener {
     for (final HttpRequestBase httpRequest : httpRequests) {
       httpRequest.addHeader(new BasicHeader("Date", this.gmtDateFormatter
           .format(new Date())));
-      httpRequest.addHeader(new BasicHeader("Host", this.azkabanHostName));
     }
 
   }