Details
diff --git a/azkaban-exec-server/src/test/java/azkaban/execapp/event/LocalFlowWatcherTest.java b/azkaban-exec-server/src/test/java/azkaban/execapp/event/LocalFlowWatcherTest.java
index b93e9aa..7597bd5 100644
--- a/azkaban-exec-server/src/test/java/azkaban/execapp/event/LocalFlowWatcherTest.java
+++ b/azkaban-exec-server/src/test/java/azkaban/execapp/event/LocalFlowWatcherTest.java
@@ -16,6 +16,8 @@
package azkaban.execapp.event;
+import static org.mockito.Mockito.mock;
+
import azkaban.execapp.EventCollectorListener;
import azkaban.execapp.FlowRunner;
import azkaban.executor.ExecutableFlow;
@@ -27,7 +29,6 @@ import azkaban.executor.MockExecutorLoader;
import azkaban.executor.Status;
import azkaban.flow.Flow;
import azkaban.jobtype.JobTypeManager;
-import azkaban.project.MockProjectLoader;
import azkaban.project.Project;
import azkaban.project.ProjectLoader;
import azkaban.utils.JSONUtils;
@@ -44,9 +45,7 @@ import org.junit.Test;
public class LocalFlowWatcherTest {
- private File workingDir;
private JobTypeManager jobtypeManager;
- private ProjectLoader fakeProjectLoader;
private int dirVal = 0;
@Before
@@ -54,7 +53,6 @@ public class LocalFlowWatcherTest {
this.jobtypeManager =
new JobTypeManager(null, null, this.getClass().getClassLoader());
this.jobtypeManager.getJobTypePluginSet().addPluginClass("java", JavaJob.class);
- this.fakeProjectLoader = new MockProjectLoader(this.workingDir);
}
@After
@@ -255,12 +253,9 @@ public class LocalFlowWatcherTest {
option.setPipelineLevel(pipeline);
option.setPipelineExecutionId(watcher.getExecId());
}
- // MockProjectLoader projectLoader = new MockProjectLoader(new
- // File(exFlow.getExecutionPath()));
-
loader.uploadExecutableFlow(exFlow);
- final FlowRunner runner =
- new FlowRunner(exFlow, loader, this.fakeProjectLoader, this.jobtypeManager, azkabanProps);
+ final FlowRunner runner = new FlowRunner(exFlow, loader, mock(ProjectLoader.class),
+ this.jobtypeManager, azkabanProps);
runner.setFlowWatcher(watcher);
runner.addListener(eventCollector);
diff --git a/azkaban-exec-server/src/test/java/azkaban/execapp/event/RemoteFlowWatcherTest.java b/azkaban-exec-server/src/test/java/azkaban/execapp/event/RemoteFlowWatcherTest.java
index c549120..ee3fe23 100644
--- a/azkaban-exec-server/src/test/java/azkaban/execapp/event/RemoteFlowWatcherTest.java
+++ b/azkaban-exec-server/src/test/java/azkaban/execapp/event/RemoteFlowWatcherTest.java
@@ -16,6 +16,8 @@
package azkaban.execapp.event;
+import static org.mockito.Mockito.mock;
+
import azkaban.execapp.EventCollectorListener;
import azkaban.execapp.FlowRunner;
import azkaban.executor.ExecutableFlow;
@@ -28,7 +30,6 @@ import azkaban.executor.MockExecutorLoader;
import azkaban.executor.Status;
import azkaban.flow.Flow;
import azkaban.jobtype.JobTypeManager;
-import azkaban.project.MockProjectLoader;
import azkaban.project.Project;
import azkaban.project.ProjectLoader;
import azkaban.utils.JSONUtils;
@@ -45,9 +46,7 @@ import org.junit.Test;
public class RemoteFlowWatcherTest {
- private File workingDir;
private JobTypeManager jobtypeManager;
- private ProjectLoader fakeProjectLoader;
private int dirVal = 0;
@Before
@@ -55,7 +54,6 @@ public class RemoteFlowWatcherTest {
this.jobtypeManager =
new JobTypeManager(null, null, this.getClass().getClassLoader());
this.jobtypeManager.getJobTypePluginSet().addPluginClass("java", JavaJob.class);
- this.fakeProjectLoader = new MockProjectLoader(this.workingDir);
}
@After
@@ -256,12 +254,10 @@ public class RemoteFlowWatcherTest {
options.setPipelineLevel(pipeline);
options.setPipelineExecutionId(watcher.getExecId());
}
- // MockProjectLoader projectLoader = new MockProjectLoader(new
- // File(exFlow.getExecutionPath()));
loader.uploadExecutableFlow(exFlow);
- final FlowRunner runner =
- new FlowRunner(exFlow, loader, this.fakeProjectLoader, this.jobtypeManager, azkabanProps);
+ final FlowRunner runner = new FlowRunner(exFlow, loader, mock(ProjectLoader.class),
+ this.jobtypeManager, azkabanProps);
runner.setFlowWatcher(watcher);
runner.addListener(eventCollector);
diff --git a/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerPipelineTest.java b/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerPipelineTest.java
index 7bff1db..eeca50d 100644
--- a/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerPipelineTest.java
+++ b/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerPipelineTest.java
@@ -16,6 +16,8 @@
package azkaban.execapp;
+import static org.mockito.Mockito.mock;
+
import azkaban.execapp.event.FlowWatcher;
import azkaban.execapp.event.LocalFlowWatcher;
import azkaban.executor.ExecutableFlow;
@@ -30,7 +32,6 @@ import azkaban.executor.Status;
import azkaban.flow.Flow;
import azkaban.jobtype.JobTypeManager;
import azkaban.jobtype.JobTypePluginSet;
-import azkaban.project.MockProjectLoader;
import azkaban.project.Project;
import azkaban.project.ProjectLoader;
import azkaban.utils.Props;
@@ -73,7 +74,6 @@ public class FlowRunnerPipelineTest {
private final Logger logger = Logger.getLogger(FlowRunnerTest2.class);
private File workingDir;
private JobTypeManager jobtypeManager;
- private ProjectLoader fakeProjectLoader;
private ExecutorLoader fakeExecutorLoader;
private Project project;
private Map<String, Flow> flowMap;
@@ -95,7 +95,6 @@ public class FlowRunnerPipelineTest {
pluginSet.addPluginClass("java", JavaJob.class);
pluginSet.addPluginClass("test", InteractiveTestJob.class);
- this.fakeProjectLoader = new MockProjectLoader(this.workingDir);
this.fakeExecutorLoader = new MockExecutorLoader();
this.project = new Project(1, "testProject");
@@ -689,7 +688,7 @@ public class FlowRunnerPipelineTest {
final FlowRunner runner =
new FlowRunner(this.fakeExecutorLoader.fetchExecutableFlow(exId),
- this.fakeExecutorLoader, this.fakeProjectLoader, this.jobtypeManager, azkabanProps);
+ this.fakeExecutorLoader, mock(ProjectLoader.class), this.jobtypeManager, azkabanProps);
runner.addListener(eventCollector);
diff --git a/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerPropertyResolutionTest.java b/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerPropertyResolutionTest.java
index 5ca8853..19b16b1 100644
--- a/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerPropertyResolutionTest.java
+++ b/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerPropertyResolutionTest.java
@@ -16,6 +16,8 @@
package azkaban.execapp;
+import static org.mockito.Mockito.mock;
+
import azkaban.executor.ExecutableFlow;
import azkaban.executor.ExecutableFlowBase;
import azkaban.executor.ExecutableNode;
@@ -25,7 +27,6 @@ import azkaban.executor.JavaJob;
import azkaban.executor.MockExecutorLoader;
import azkaban.flow.Flow;
import azkaban.jobtype.JobTypeManager;
-import azkaban.project.MockProjectLoader;
import azkaban.project.Project;
import azkaban.project.ProjectLoader;
import azkaban.utils.Props;
@@ -68,7 +69,6 @@ public class FlowRunnerPropertyResolutionTest {
private final Logger logger = Logger.getLogger(FlowRunnerTest2.class);
private File workingDir;
private JobTypeManager jobtypeManager;
- private ProjectLoader fakeProjectLoader;
private ExecutorLoader fakeExecutorLoader;
private Project project;
private Map<String, Flow> flowMap;
@@ -86,7 +86,6 @@ public class FlowRunnerPropertyResolutionTest {
this.jobtypeManager.getJobTypePluginSet().addPluginClass("java", JavaJob.class);
this.jobtypeManager.getJobTypePluginSet().addPluginClass("test",
InteractiveTestJob.class);
- this.fakeProjectLoader = new MockProjectLoader(this.workingDir);
this.fakeExecutorLoader = new MockExecutorLoader();
this.project = new Project(1, "testProject");
@@ -222,7 +221,7 @@ public class FlowRunnerPropertyResolutionTest {
final FlowRunner runner =
new FlowRunner(this.fakeExecutorLoader.fetchExecutableFlow(exId),
- this.fakeExecutorLoader, this.fakeProjectLoader, this.jobtypeManager, azkabanProps);
+ this.fakeExecutorLoader, mock(ProjectLoader.class), this.jobtypeManager, azkabanProps);
return runner;
}
diff --git a/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest.java b/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest.java
index 2041e78..6332159 100644
--- a/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest.java
+++ b/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest.java
@@ -33,7 +33,6 @@ import azkaban.flow.Flow;
import azkaban.jobExecutor.AllJobExecutorTests;
import azkaban.jobtype.JobTypeManager;
import azkaban.jobtype.JobTypePluginSet;
-import azkaban.project.MockProjectLoader;
import azkaban.project.Project;
import azkaban.project.ProjectLoader;
import azkaban.test.Utils;
@@ -56,7 +55,10 @@ public class FlowRunnerTest extends FlowRunnerTestBase {
"../test/src/test/resources/azkaban/test/executions/exectest1");
private File workingDir;
private JobTypeManager jobtypeManager;
+
+ @Mock
private ProjectLoader fakeProjectLoader;
+
@Mock
private ExecutorLoader loader;
@@ -75,7 +77,6 @@ public class FlowRunnerTest extends FlowRunnerTestBase {
final JobTypePluginSet pluginSet = this.jobtypeManager.getJobTypePluginSet();
pluginSet.setCommonPluginLoadProps(AllJobExecutorTests.setUpCommonProps());
pluginSet.addPluginClass("test", InteractiveTestJob.class);
- this.fakeProjectLoader = new MockProjectLoader(this.workingDir);
Utils.initServiceProvider();
JmxJobMBeanManager.getInstance().initialize(new Props());
diff --git a/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest2.java b/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest2.java
index 3dc55ad..6d02612 100644
--- a/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest2.java
+++ b/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest2.java
@@ -17,6 +17,7 @@
package azkaban.execapp;
import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.mock;
import azkaban.execapp.jmx.JmxJobMBeanManager;
import azkaban.executor.ExecutableFlow;
@@ -32,7 +33,6 @@ import azkaban.flow.Flow;
import azkaban.jobExecutor.AllJobExecutorTests;
import azkaban.jobtype.JobTypeManager;
import azkaban.jobtype.JobTypePluginSet;
-import azkaban.project.MockProjectLoader;
import azkaban.project.Project;
import azkaban.project.ProjectLoader;
import azkaban.test.Utils;
@@ -101,7 +101,6 @@ public class FlowRunnerTest2 extends FlowRunnerTestBase {
private final Logger logger = Logger.getLogger(FlowRunnerTest2.class);
private File workingDir;
private JobTypeManager jobtypeManager;
- private ProjectLoader fakeProjectLoader;
private ExecutorLoader fakeExecutorLoader;
private Project project;
private Map<String, Flow> flowMap;
@@ -121,7 +120,6 @@ public class FlowRunnerTest2 extends FlowRunnerTestBase {
pluginSet.setCommonPluginLoadProps(AllJobExecutorTests.setUpCommonProps());
pluginSet.addPluginClass("java", JavaJob.class);
pluginSet.addPluginClass("test", InteractiveTestJob.class);
- this.fakeProjectLoader = new MockProjectLoader(this.workingDir);
this.fakeExecutorLoader = new MockExecutorLoader();
this.project = new Project(1, "testProject");
Utils.initServiceProvider();
@@ -1118,7 +1116,7 @@ public class FlowRunnerTest2 extends FlowRunnerTestBase {
final FlowRunner runner = new FlowRunner(
this.fakeExecutorLoader.fetchExecutableFlow(exId), this.fakeExecutorLoader,
- this.fakeProjectLoader, this.jobtypeManager, azkabanProps);
+ mock(ProjectLoader.class), this.jobtypeManager, azkabanProps);
runner.addListener(eventCollector);