azkaban-aplcache

Fixing ReferenceEquality warnings (#1181) Original warning: "Servlet.java:111: …

6/8/2017 2:05:36 PM

warning: [ReferenceEquality] Comparison using reference equality instead of value equality
begin == "" ? -1 : DateTimeFormat.forPattern(FILTER_BY_DATE_PATTERN)
^
(see http://errorprone.info/bugpattern/ReferenceEquality)
Did you mean '"".equals(begin) ? -1 :
"

Also see
https://stackoverflow.com/questions/7520432/what-is-the-difference-between-vs-equals-in-java

Charlie Summers

Commit: 7eaf4ba

Tree: 61d89b1

Parents: c003e4e

Changes

azkaban-web-server/src/main/java/azkaban/webapp/servlet/HistoryServlet.java 4(+2 -2)

Details

azkaban-web-server/src/main/java/azkaban/webapp/servlet/HistoryServlet.java 4(+2 -2)

diff --git a/azkaban-web-server/src/main/java/azkaban/webapp/servlet/HistoryServlet.java b/azkaban-web-server/src/main/java/azkaban/webapp/servlet/HistoryServlet.java
index 7563760..574569d 100644
--- a/azkaban-web-server/src/main/java/azkaban/webapp/servlet/HistoryServlet.java
+++ b/azkaban-web-server/src/main/java/azkaban/webapp/servlet/HistoryServlet.java
@@ -105,12 +105,12 @@ public class HistoryServlet extends LoginAbstractAzkabanServlet {
       final String begin = getParam(req, "begin");
 
       final long beginTime =
-          begin == "" ? -1 : DateTimeFormat.forPattern(FILTER_BY_DATE_PATTERN)
+          "".equals(begin) ? -1 : DateTimeFormat.forPattern(FILTER_BY_DATE_PATTERN)
               .parseDateTime(begin).getMillis();
       final String end = getParam(req, "end");
 
       final long endTime =
-          end == "" ? -1 : DateTimeFormat.forPattern(FILTER_BY_DATE_PATTERN)
+          "".equals(end) ? -1 : DateTimeFormat.forPattern(FILTER_BY_DATE_PATTERN)
               .parseDateTime(end).getMillis();
       try {
         history =