azkaban-aplcache

Add logging when exception occurs in StatsServlet (#890) Added

2/1/2017 11:22:35 PM

Details

diff --git a/azkaban-web-server/src/main/java/azkaban/webapp/servlet/StatsServlet.java b/azkaban-web-server/src/main/java/azkaban/webapp/servlet/StatsServlet.java
index b2b3487..3fdcc45 100644
--- a/azkaban-web-server/src/main/java/azkaban/webapp/servlet/StatsServlet.java
+++ b/azkaban-web-server/src/main/java/azkaban/webapp/servlet/StatsServlet.java
@@ -40,11 +40,15 @@ import azkaban.user.User;
 import azkaban.user.UserManager;
 import azkaban.utils.Pair;
 import azkaban.webapp.AzkabanWebServer;
+import org.apache.log4j.Logger;
 
 /**
  * User facing servlet for Azkaban default metric display
  */
 public class StatsServlet extends LoginAbstractAzkabanServlet {
+
+  private static final Logger logger = Logger.getLogger(StatsServlet.class);
+
   private static final long serialVersionUID = 1L;
   private UserManager userManager;
   private ExecutorManager execManager;
@@ -114,6 +118,7 @@ public class StatsServlet extends LoginAbstractAzkabanServlet {
         ret.put("metricList", result.get("data"));
       }
     } catch (ExecutorManagerException e) {
+      logger.error(e.getMessage(), e);
       ret.put("error", "Failed to fetch metric names for executor : "
         + executorId);
     }
@@ -139,6 +144,7 @@ public class StatsServlet extends LoginAbstractAzkabanServlet {
           result.get(ConnectorParams.STATUS_PARAM));
       }
     } catch (ExecutorManagerException ex) {
+      logger.error(ex.getMessage(), ex);
       ret.put("error", "Failed to change config change");
     }
   }
@@ -163,6 +169,7 @@ public class StatsServlet extends LoginAbstractAzkabanServlet {
         ret.put("data", result.get("data"));
       }
     } catch (ExecutorManagerException ex) {
+      logger.error(ex.getMessage(), ex);
       ret.put("error", "Failed to fetch metric history");
     }
   }
@@ -195,6 +202,7 @@ public class StatsServlet extends LoginAbstractAzkabanServlet {
         page.add("metricList", result.get("data"));
       }
     } catch (Exception e) {
+      logger.error(e.getMessage(), e);
       page.add("errorMsg", "Failed to get a response from Azkaban exec server");
     }