azkaban-aplcache

Fix build warning : enums should be immutable. (#1031) An

4/27/2017 8:53:57 PM

Details

diff --git a/azkaban-web-server/src/main/java/azkaban/webapp/WebMetrics.java b/azkaban-web-server/src/main/java/azkaban/webapp/WebMetrics.java
index 8bc1c15..36ba760 100644
--- a/azkaban-web-server/src/main/java/azkaban/webapp/WebMetrics.java
+++ b/azkaban-web-server/src/main/java/azkaban/webapp/WebMetrics.java
@@ -16,7 +16,6 @@
 
 package azkaban.webapp;
 
-import azkaban.executor.ExecutorManager;
 import azkaban.metrics.MetricsManager;
 import azkaban.metrics.MetricsUtility;
 
@@ -24,7 +23,6 @@ import com.codahale.metrics.Meter;
 import com.codahale.metrics.MetricRegistry;
 
 import java.util.concurrent.atomic.AtomicLong;
-import java.util.function.Supplier;
 
 
 /**
@@ -34,20 +32,16 @@ import java.util.function.Supplier;
 public enum WebMetrics {
   INSTANCE;
 
-  private MetricRegistry registry;
+  private final MetricRegistry registry;
 
-  private Meter webGetCall;
-  private Meter webPostCall;
+  private final Meter webGetCall;
+  private final Meter webPostCall;
 
   // How long does user log fetch take when user call fetch-log api.
-  private AtomicLong logFetchLatency = new AtomicLong(0L);
+  private final AtomicLong logFetchLatency = new AtomicLong(0L);
 
   WebMetrics() {
     registry = MetricsManager.INSTANCE.getRegistry();
-    setupStaticMetrics();
-  }
-
-  private void setupStaticMetrics() {
     webGetCall = MetricsUtility.addMeter("Web-Get-Call-Meter", registry);
     webPostCall = MetricsUtility.addMeter("Web-Post-Call-Meter", registry);
     MetricsUtility.addGauge("fetchLogLatency", registry, logFetchLatency::get);