azkaban-aplcache

Fixed "Center" button in graph view context menu (#1338) The …

8/16/2017 1:28:58 PM

"centerNode" function calls getTransformToElement(), which was removed from the SVG spec and also from browsers such as Chrome and Firefox, so the "Center" context menu button that appears when right-clicking in the graph view doesn't work. Fortunately it doesn't seem to use this call for anything so simply removing the line makes the button work again.

Tested by injecting the modified svg-graph.js as a Greasemonkey script in Firefox 55.0.1, and locally modifying the script in the debugger in Chrome 60.0.3112.90.

Jack Li

Commit: bb6779c

Tree: 330a8a1

Parents: 3318803

Changes

azkaban-web-server/src/web/js/azkaban/view/svg-graph.js 1(+0 -1)

Details

azkaban-web-server/src/web/js/azkaban/view/svg-graph.js 1(+0 -1)

diff --git a/azkaban-web-server/src/web/js/azkaban/view/svg-graph.js b/azkaban-web-server/src/web/js/azkaban/view/svg-graph.js
index 8af7abc..c1d81ff 100644
--- a/azkaban-web-server/src/web/js/azkaban/view/svg-graph.js
+++ b/azkaban-web-server/src/web/js/azkaban/view/svg-graph.js
@@ -652,7 +652,6 @@ azkaban.SvgGraphView = Backbone.View.extend({
     // position.
     // Rather do this than to traverse backwards through the scene graph.
     var ctm = node.gNode.getCTM();
-    var transform = node.gNode.getTransformToElement();
     var globalCTM = this.mainG.getCTM().inverse();
     var otherTransform = globalCTM.multiply(ctm);
     // Also a beauty of affine transformation. The translate is always the