azkaban-aplcache

Update dev guide (#1467) * Update dev guide - Use slf4j

9/15/2017 11:48:28 PM

Changes

CONTRIBUTING.md 19(+19 -0)

Details

CONTRIBUTING.md 19(+19 -0)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b9adb02..dd230c3 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -104,3 +104,22 @@ It allows us to do following when saving a file:
   It's an exception rather than the rule to create custom mocking classes.
   
 - Use [AssertJ](http://joel-costigliola.github.io/assertj/) as the assertion library in unit tests.
+
+- Use slf4j instead of log4j. 
+
+  Use the form: 
+
+  `
+  private static final Logger logger = LoggerFactory.getLogger($CLASS_NAME$.class);
+  ` 
+
+- Add or update the copyright notice for most files. 
+
+# Misc
+
+- See [the dev tips wiki](https://github.com/azkaban/azkaban/wiki/Developer-Tools-and-Tips) for 
+tips.
+
+- Store images in the [azkaban-images repo](https://github.com/azkaban/azkaban-images)
+ 
+  This is useful to store images needed in the wiki pages for example.