azkaban-aplcache

Fix build warning DefaultCharset in test Utils class (#1043) *

5/1/2017 10:37:31 AM

Details

diff --git a/azkaban-common/src/test/java/azkaban/jobExecutor/PythonJobTest.java b/azkaban-common/src/test/java/azkaban/jobExecutor/PythonJobTest.java
index 7320c15..b8737c6 100644
--- a/azkaban-common/src/test/java/azkaban/jobExecutor/PythonJobTest.java
+++ b/azkaban-common/src/test/java/azkaban/jobExecutor/PythonJobTest.java
@@ -78,7 +78,7 @@ public class PythonJobTest {
   }
 
   @AfterClass
-  public static void cleanup() {
+  public static void cleanup() throws IOException {
     // remove the input file and error input file
     Utils.removeFile(scriptFile);
   }
diff --git a/azkaban-common/src/test/java/azkaban/jobExecutor/Utils.java b/azkaban-common/src/test/java/azkaban/jobExecutor/Utils.java
index ad5f353..ef23514 100644
--- a/azkaban-common/src/test/java/azkaban/jobExecutor/Utils.java
+++ b/azkaban-common/src/test/java/azkaban/jobExecutor/Utils.java
@@ -16,24 +16,24 @@
 
 package azkaban.jobExecutor;
 
-import java.io.File;
-import java.io.FileWriter;
 import java.io.IOException;
 import java.io.PrintWriter;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+
 
 public class Utils {
   private Utils() {
   }
 
-  public static void dumpFile(String filename, String filecontent)
-      throws IOException {
-    PrintWriter writer = new PrintWriter(new FileWriter(filename));
-    writer.print(filecontent);
-    writer.close();
+  static void dumpFile(String filename, String fileContent) throws IOException {
+    try (PrintWriter writer = new PrintWriter(filename, StandardCharsets.UTF_8.toString())) {
+      writer.print(fileContent);
+    }
   }
 
-  public static void removeFile(String filename) {
-    File file = new File(filename);
-    file.delete();
+  static void removeFile(String filename) throws IOException {
+    Files.delete(Paths.get(filename));
   }
 }