azkaban-aplcache

All executor servlets to use POST (#1711) ExecutorApiGateway

3/28/2018 10:07:06 PM
3.45.1

Details

diff --git a/azkaban-exec-server/src/main/java/azkaban/execapp/JMXHttpServlet.java b/azkaban-exec-server/src/main/java/azkaban/execapp/JMXHttpServlet.java
index 0cec41f..7da64d1 100644
--- a/azkaban-exec-server/src/main/java/azkaban/execapp/JMXHttpServlet.java
+++ b/azkaban-exec-server/src/main/java/azkaban/execapp/JMXHttpServlet.java
@@ -56,9 +56,19 @@ public class JMXHttpServlet extends HttpServlet implements ConnectorParams {
     return HttpRequestUtils.getParam(request, name);
   }
 
+  /**
+   * @deprecated GET available for seamless upgrade. azkaban-web now uses POST.
+   */
+  @Deprecated
   @Override
   protected void doGet(final HttpServletRequest req, final HttpServletResponse resp)
       throws ServletException, IOException {
+    doPost(req, resp);
+  }
+
+  @Override
+  protected void doPost(final HttpServletRequest req, final HttpServletResponse resp)
+      throws ServletException, IOException {
     final Map<String, Object> ret = new HashMap<>();
 
     if (hasParam(req, JMX_GET_MBEANS)) {
diff --git a/azkaban-exec-server/src/main/java/azkaban/execapp/ServerStatisticsServlet.java b/azkaban-exec-server/src/main/java/azkaban/execapp/ServerStatisticsServlet.java
index 82835a7..0354bf3 100644
--- a/azkaban-exec-server/src/main/java/azkaban/execapp/ServerStatisticsServlet.java
+++ b/azkaban-exec-server/src/main/java/azkaban/execapp/ServerStatisticsServlet.java
@@ -47,14 +47,21 @@ public class ServerStatisticsServlet extends HttpServlet {
   protected static ExecutorInfo cachedstats = null;
 
   /**
-   * Handle all get request to Statistics Servlet {@inheritDoc}
-   *
-   * @see javax.servlet.http.HttpServlet#doGet(javax.servlet.http.HttpServletRequest,
-   * javax.servlet.http.HttpServletResponse)
+   * @deprecated GET available for seamless upgrade. azkaban-web now uses POST.
    */
+  @Deprecated
   @Override
   protected void doGet(final HttpServletRequest req, final HttpServletResponse resp)
       throws ServletException, IOException {
+    doPost(req, resp);
+  }
+
+  /**
+   * Handle all requests to Statistics Servlet {@inheritDoc}
+   */
+  @Override
+  protected void doPost(final HttpServletRequest req, final HttpServletResponse resp)
+      throws ServletException, IOException {
 
     final boolean noCache = null != req && Boolean.valueOf(req.getParameter(noCacheParamName));
 
diff --git a/azkaban-exec-server/src/main/java/azkaban/execapp/StatsServlet.java b/azkaban-exec-server/src/main/java/azkaban/execapp/StatsServlet.java
index 1fa7b3f..dee7511 100644
--- a/azkaban-exec-server/src/main/java/azkaban/execapp/StatsServlet.java
+++ b/azkaban-exec-server/src/main/java/azkaban/execapp/StatsServlet.java
@@ -69,14 +69,21 @@ public class StatsServlet extends HttpServlet implements ConnectorParams {
   }
 
   /**
-   * Handle all get request to Stats Servlet {@inheritDoc}
-   *
-   * @see javax.servlet.http.HttpServlet#doGet(javax.servlet.http.HttpServletRequest,
-   * javax.servlet.http.HttpServletResponse)
+   * @deprecated GET available for seamless upgrade. azkaban-web now uses POST.
    */
+  @Deprecated
   @Override
   protected void doGet(final HttpServletRequest req, final HttpServletResponse resp)
       throws ServletException, IOException {
+    doPost(req, resp);
+  }
+
+  /**
+   * Handle all requests to Stats Servlet {@inheritDoc}
+   */
+  @Override
+  protected void doPost(final HttpServletRequest req, final HttpServletResponse resp)
+      throws ServletException, IOException {
     final Map<String, Object> ret = new HashMap<>();
 
     if (hasParam(req, ACTION_PARAM)) {