azkaban-aplcache

Fix ClassCanBeStatic warnings in common sub-project (#1006) *

4/24/2017 3:01:38 PM

Details

diff --git a/azkaban-common/src/main/java/azkaban/trigger/JdbcTriggerLoader.java b/azkaban-common/src/main/java/azkaban/trigger/JdbcTriggerLoader.java
index 007d872..ab773f1 100644
--- a/azkaban-common/src/main/java/azkaban/trigger/JdbcTriggerLoader.java
+++ b/azkaban-common/src/main/java/azkaban/trigger/JdbcTriggerLoader.java
@@ -266,7 +266,7 @@ public class JdbcTriggerLoader extends AbstractJdbcLoader implements
 
   }
 
-  public class TriggerResultHandler implements ResultSetHandler<List<Trigger>> {
+  public static class TriggerResultHandler implements ResultSetHandler<List<Trigger>> {
 
     @Override
     public List<Trigger> handle(ResultSet rs) throws SQLException {
diff --git a/azkaban-common/src/test/java/azkaban/executor/SelectorTest.java b/azkaban-common/src/test/java/azkaban/executor/SelectorTest.java
index e54b182..c341445 100644
--- a/azkaban-common/src/test/java/azkaban/executor/SelectorTest.java
+++ b/azkaban-common/src/test/java/azkaban/executor/SelectorTest.java
@@ -36,7 +36,7 @@ import azkaban.utils.JSONUtils;
 
 public class SelectorTest {
   // mock executor object.
-  protected class MockExecutorObject implements Comparable <MockExecutorObject>{
+  static class MockExecutorObject implements Comparable <MockExecutorObject>{
     public String name;
     public int    port;
     public double percentOfRemainingMemory;
@@ -78,7 +78,7 @@ public class SelectorTest {
   }
 
   // Mock flow object.
-  protected class MockFlowObject{
+  static class MockFlowObject{
     public String name;
     public int    requiredRemainingMemory;
     public int    requiredTotalMemory;
@@ -106,7 +106,7 @@ public class SelectorTest {
   }
 
   // mock Filter class.
-  protected class MockFilter
+  static class MockFilter
   extends CandidateFilter<MockExecutorObject,MockFlowObject>{
 
     @Override
@@ -182,7 +182,7 @@ public class SelectorTest {
   }
 
   // mock comparator class.
-  protected class MockComparator
+  static class MockComparator
   extends CandidateComparator<MockExecutorObject>{
 
     @Override
diff --git a/azkaban-common/src/test/java/azkaban/trigger/TriggerManagerDeadlockTest.java b/azkaban-common/src/test/java/azkaban/trigger/TriggerManagerDeadlockTest.java
index a2f672e..99d15fd 100644
--- a/azkaban-common/src/test/java/azkaban/trigger/TriggerManagerDeadlockTest.java
+++ b/azkaban-common/src/test/java/azkaban/trigger/TriggerManagerDeadlockTest.java
@@ -75,7 +75,7 @@ public class TriggerManagerDeadlockTest {
     System.out.println("No dead lock.");
   }
 
-  public class AlwaysOnChecker implements ConditionChecker {
+  public static class AlwaysOnChecker implements ConditionChecker {
 
     public static final String type = "AlwaysOnChecker";
 
diff --git a/azkaban-common/src/test/java/azkaban/trigger/TriggerManagerTest.java b/azkaban-common/src/test/java/azkaban/trigger/TriggerManagerTest.java
index 4021cc7..197fc14 100644
--- a/azkaban-common/src/test/java/azkaban/trigger/TriggerManagerTest.java
+++ b/azkaban-common/src/test/java/azkaban/trigger/TriggerManagerTest.java
@@ -122,7 +122,7 @@ public class TriggerManagerTest {
 
   }
 
-  public class MockTriggerLoader implements TriggerLoader {
+  public static class MockTriggerLoader implements TriggerLoader {
 
     private Map<Integer, Trigger> triggers = new HashMap<Integer, Trigger>();
     private int idIndex = 0;
diff --git a/azkaban-common/src/test/java/azkaban/utils/RestfulApiClientTest.java b/azkaban-common/src/test/java/azkaban/utils/RestfulApiClientTest.java
index 85b2666..8e1d3c6 100644
--- a/azkaban-common/src/test/java/azkaban/utils/RestfulApiClientTest.java
+++ b/azkaban-common/src/test/java/azkaban/utils/RestfulApiClientTest.java
@@ -44,7 +44,7 @@ import org.junit.Test;
  */
 public class RestfulApiClientTest {
 
-  protected class MockRestfulApiClient extends RestfulApiClient<String> {
+  static class MockRestfulApiClient extends RestfulApiClient<String> {
     private int  status = HttpStatus.SC_OK;
 
     @Override