azkaban-aplcache

Optimize slow test TriggerInstanceProcessorTest#testProcessTermination

2/18/2019 7:39:52 PM

Details

diff --git a/azkaban-web-server/src/test/java/azkaban/flowtrigger/TriggerInstanceProcessorTest.java b/azkaban-web-server/src/test/java/azkaban/flowtrigger/TriggerInstanceProcessorTest.java
index 2990b24..93c9f9f 100644
--- a/azkaban-web-server/src/test/java/azkaban/flowtrigger/TriggerInstanceProcessorTest.java
+++ b/azkaban-web-server/src/test/java/azkaban/flowtrigger/TriggerInstanceProcessorTest.java
@@ -16,7 +16,9 @@
 package azkaban.flowtrigger;
 
 import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+import static org.junit.Assert.assertEquals;
 import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyBoolean;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
@@ -116,7 +118,7 @@ public class TriggerInstanceProcessorTest {
     doAnswer(invocation -> {
       this.sendEmailLatch.countDown();
       return null;
-    }).when(this.emailer).sendEmail(any(), any(), any());
+    }).when(this.emailer).sendEmail(any(EmailMessage.class), anyBoolean(), anyString());
 
     this.submitFlowLatch = new CountDownLatch(1);
     doAnswer(invocation -> {
@@ -149,6 +151,7 @@ public class TriggerInstanceProcessorTest {
     final TriggerInstance triggerInstance = createTriggerInstance();
     this.processor.processTermination(triggerInstance);
     this.sendEmailLatch.await(10L, TimeUnit.SECONDS);
+    assertEquals(0, sendEmailLatch.getCount());
     verify(this.message).setSubject(
         "flow trigger for flow 'flowId', project 'proj' has been cancelled on azkaban");
     assertThat(TestUtils.readResource("/emailTemplate/flowtriggerfailureemail.html", this))